Hi Shahrokh and Miller. I've sent this before, but now I'm sending again with a more explicit subject and also a Pull Request.
I've tested the new expr (v0.55 released in pd 0.48) and I still have some remaining bugs to report. These are bugs I really think should be fixed, and some suggested feature requests.
One of the bugs is plain simple, the fact that fexpr~ doesn't allow a float input in its left inlet. That doesn't seem intentional, by the way, because [expr~] allows it. Anyway, here's a simple Pull Request I created about it, see if it's cool: https://github.com/pure-data/pure-data/pull/219
cheers
By the way, checking the code, I see a "verbose" message. What does it do?
2017-09-16 11:36 GMT-03:00 Alexandre Torres Porres porres@gmail.com:
Hi Shahrokh and Miller. I've sent this before, but now I'm sending again with a more explicit subject and also a Pull Request.
I've tested the new expr (v0.55 released in pd 0.48) and I still have some remaining bugs to report. These are bugs I really think should be fixed, and some suggested feature requests.
One of the bugs is plain simple, the fact that fexpr~ doesn't allow a float input in its left inlet. That doesn't seem intentional, by the way, because [expr~] allows it. Anyway, here's a simple Pull Request I created about it, see if it's cool: https://github.com/pure- data/pure-data/pull/219
cheers
please ignore the trig functions bug, they have actually been fixed already
2017-09-16 11:41 GMT-03:00 Alexandre Torres Porres porres@gmail.com:
By the way, checking the code, I see a "verbose" message. What does it do?
2017-09-16 11:36 GMT-03:00 Alexandre Torres Porres porres@gmail.com:
Hi Shahrokh and Miller. I've sent this before, but now I'm sending again with a more explicit subject and also a Pull Request.
I've tested the new expr (v0.55 released in pd 0.48) and I still have some remaining bugs to report. These are bugs I really think should be fixed, and some suggested feature requests.
One of the bugs is plain simple, the fact that fexpr~ doesn't allow a float input in its left inlet. That doesn't seem intentional, by the way, because [expr~] allows it. Anyway, here's a simple Pull Request I created about it, see if it's cool: https://github.com/pure- data/pure-data/pull/219
cheers
Dear Alexandre and all,
Miller and I both agree that it is better not to change the behavior of expr~ and fexpr~ in respect to requiring the first inlet to be a signal. See Miller's response below:
If the object has a method for "signal" then its first inlet (i.e., itself) is then passed a signal to process. I think this means it would be a bit confusing not to use the first inlet as a
signal...
Pd would allow signal connections to it that you'd then ignore in favor of the float or symbol value it gets sent. Also, it's funny to send it a message like "float" and not have that trigger a computation. So I
think
it's probably just as well to leave it as is.
However, I will look into why fexpr~ does not convert float to signal.
After receiving a few other requests for avg() and Avg() to come back, I will also soon include these functions and possibly others to the list of functions.
Thank you very much for your update of the documentation patch.
cheers, Shahrokh
On Sat, Sep 16, 2017 at 7:36 AM, Alexandre Torres Porres porres@gmail.com wrote:
Hi Shahrokh and Miller. I've sent this before, but now I'm sending again with a more explicit subject and also a Pull Request.
I've tested the new expr (v0.55 released in pd 0.48) and I still have some remaining bugs to report. These are bugs I really think should be fixed, and some suggested feature requests.
One of the bugs is plain simple, the fact that fexpr~ doesn't allow a float input in its left inlet. That doesn't seem intentional, by the way, because [expr~] allows it. Anyway, here's a simple Pull Request I created about it, see if it's cool: https://github.com/pure- data/pure-data/pull/219
cheers
2017-09-18 13:34 GMT-03:00 Shahrokh Yadegari sdy@ucsd.edu:
Dear Alexandre and all,
Miller and I both agree that it is better not to change the behavior of expr~ and fexpr~ in respect to requiring the first inlet to be a signal.
Let us just be clear. You mean the request to allow the first inlet to be a float or symbol variable (such as $f1 or $s1) rather than a signal ($v1 for expr~ and $x1[0] for fexpr~) - right?
I think this means it would be a bit confusing not to use the first inlet
as a signal... Pd would allow signal connections to it that you'd then ignore in favor of the float or symbol value it gets sent.
Hmm, I see that now! Unlike secondary inlets, which would not allow a signal connection, the left/main inlet would still allow it. So this is a good reasoning... in fact it'd be better if it would not allow a signal inlet, and that would require too much surgery.
Anyway, I only brought it up cause it said so in the source code this could be considered in the future. So yeah, just leave it as it is and remove that remark from the source code.
However, I will look into why fexpr~ does not convert float to signal.
It's coz it doesn't have CLASS_MAINSIGNALIN in the setup method. But expr~ has it, so it converts floats to signals.
So I just added CLASS_MAINSIGNALIN(fexpr_tilde_class, t_expr, exp_f) to fexpr~'s setup and it worked fine.
Though now I think the class_addmethod(fexpr_tilde_class, nullfn, gensym(" signal"), 0) is unnecessary, as well as it is not necessary for expr~. Well, you and Miller should know better, I must be the most ignorant object developer for Pd :)
After receiving a few other requests for avg() and Avg() to come back, I will also soon include these functions and possibly others to the list of functions.
Awesome :)
Thank you very much for your update of the documentation patch.
my pleasure
Cheers
On Sat, Sep 16, 2017 at 7:36 AM, Alexandre Torres Porres porres@gmail.com
wrote:
Hi Shahrokh and Miller. I've sent this before, but now I'm sending again with a more explicit subject and also a Pull Request.
I've tested the new expr (v0.55 released in pd 0.48) and I still have some remaining bugs to report. These are bugs I really think should be fixed, and some suggested feature requests.
One of the bugs is plain simple, the fact that fexpr~ doesn't allow a float input in its left inlet. That doesn't seem intentional, by the way, because [expr~] allows it. Anyway, here's a simple Pull Request I created about it, see if it's cool: https://github.com/pure- data/pure-data/pull/219
cheers
-- Shahrokh Yadegari Professor, Music Department University of California, San Diego Director, Sonic Arts R&D and IDEAS Qualcomm Institute Email: sdy@ucsd.edu Web: http://yadegari.org
Hi Shahrokh, with the new release of pd 0.48-1 around the corner, I was wondering if we could have a look into that minor issue with [fexpr~], in which it doesn't convert float to signals in the main left inlet.
However, I will look into why fexpr~ does not convert float to signal.
I've actually already made a Pull Request for that a while ago, see: https://github.com/pure-data/pure-data/pull/219
All I did was add *CLASS_MAINSIGNALIN(fexpr_tilde_class, t_expr, exp_f) *to fexpr~'s setup and it all works fine now. This is now the same as in expr~ setup, so it is consistent between each other and also how we expect a signaal object to behave.
I would also go ahead and remove *class_addmethod(fexpr_tilde_class, nullfn, gensym("signal"), 0**) *cause I think it's unnecessary, (expr~ has it too). But I'll leave that to you and Miller.
And, also, I guess this would call for an update to the version... to something like "0.56".
About the documentation, I can also send a fix for the help file saying fexpr~ now promotes floats to signal, if this is accepted. I'm actually already working on a new help file because the new upcoming version of Pd has a different font size, so I'm just realigning things.
cheers
2017-09-18 13:50 GMT-03:00 Alexandre Torres Porres porres@gmail.com:
2017-09-18 13:34 GMT-03:00 Shahrokh Yadegari sdy@ucsd.edu:
Dear Alexandre and all,
Miller and I both agree that it is better not to change the behavior of expr~ and fexpr~ in respect to requiring the first inlet to be a signal.
Let us just be clear. You mean the request to allow the first inlet to be a float or symbol variable (such as $f1 or $s1) rather than a signal ($v1 for expr~ and $x1[0] for fexpr~) - right?
I think this means it would be a bit confusing not to use the first inlet
as a signal... Pd would allow signal connections to it that you'd then ignore in favor of the float or symbol value it gets sent.
Hmm, I see that now! Unlike secondary inlets, which would not allow a signal connection, the left/main inlet would still allow it. So this is a good reasoning... in fact it'd be better if it would not allow a signal inlet, and that would require too much surgery.
Anyway, I only brought it up cause it said so in the source code this could be considered in the future. So yeah, just leave it as it is and remove that remark from the source code.
However, I will look into why fexpr~ does not convert float to signal.
It's coz it doesn't have CLASS_MAINSIGNALIN in the setup method. But expr~ has it, so it converts floats to signals.
So I just added CLASS_MAINSIGNALIN(fexpr_tilde_class, t_expr, exp_f) to fexpr~'s setup and it worked fine.
Though now I think the class_addmethod(fexpr_tilde_class, nullfn, gensym(" signal"), 0) is unnecessary, as well as it is not necessary for expr~. Well, you and Miller should know better, I must be the most ignorant object developer for Pd :)
After receiving a few other requests for avg() and Avg() to come back, I will also soon include these functions and possibly others to the list of functions.
Awesome :)
Thank you very much for your update of the documentation patch.
my pleasure
Cheers
On Sat, Sep 16, 2017 at 7:36 AM, Alexandre Torres Porres <porres@gmail.com
wrote:
Hi Shahrokh and Miller. I've sent this before, but now I'm sending again with a more explicit subject and also a Pull Request.
I've tested the new expr (v0.55 released in pd 0.48) and I still have some remaining bugs to report. These are bugs I really think should be fixed, and some suggested feature requests.
One of the bugs is plain simple, the fact that fexpr~ doesn't allow a float input in its left inlet. That doesn't seem intentional, by the way, because [expr~] allows it. Anyway, here's a simple Pull Request I created about it, see if it's cool: https://github.com/pure- data/pure-data/pull/219
cheers
-- Shahrokh Yadegari Professor, Music Department University of California, San Diego Director, Sonic Arts R&D and IDEAS Qualcomm Institute Email: sdy@ucsd.edu Web: http://yadegari.org
2017-09-18 13:34 GMT-03:00 Shahrokh Yadegari sdy@ucsd.edu:
After receiving a few other requests for avg() and Avg() to come back, I will also soon include these functions and possibly others to the list of functions.
Well, perhaps avg() and Avg() are easy enough to come back right now as well? :)
Hi Alexandre,
I am sorry for my late reply. Yes, if it is not too late with Miller, I will fix the fexpr float to signal matter and add avg() and Avg() before the year is over. Thanks for attending to the help file.
cheers, Shahrokh
On Tue, Dec 5, 2017 at 10:48 AM, Alexandre Torres Porres porres@gmail.com wrote:
2017-09-18 13:34 GMT-03:00 Shahrokh Yadegari sdy@ucsd.edu:
After receiving a few other requests for avg() and Avg() to come back, I will also soon include these functions and possibly others to the list of functions.
Well, perhaps avg() and Avg() are easy enough to come back right now as well? :)
Yes, if it is not too late with Miller, I will fix the fexpr float to
signal matter and
add avg() and Avg() before the year is over.
Great, I have a new Pull Request now, for an update to the help file of expr, but this is mostly aesthetical as it now aligns to the new font size from 0.48-1
here it is https://github.com/pure-data/pure-data/pull/272
If we have the expr updates ready for the next release, I'll also make a new Pull Request to include the new changes
I don't know if it's too late, I hope not :) - we only need the same time since the last test release was out for the end of the year, so it could be doable. I don't know what else is in plan for the final release though.
cheers
2017-12-15 21:00 GMT-02:00 Shahrokh Yadegari sdy@ucsd.edu:
Hi Alexandre,
I am sorry for my late reply. Yes, if it is not too late with Miller, I will fix the fexpr float to signal matter and add avg() and Avg() before the year is over. Thanks for attending to the help file.
cheers, Shahrokh
On Tue, Dec 5, 2017 at 10:48 AM, Alexandre Torres Porres <porres@gmail.com
wrote:
2017-09-18 13:34 GMT-03:00 Shahrokh Yadegari sdy@ucsd.edu:
After receiving a few other requests for avg() and Avg() to come back, I will also soon include these functions and possibly others to the list of functions.
Well, perhaps avg() and Avg() are easy enough to come back right now as well? :)
-- Shahrokh Yadegari Professor, Music Department University of California, San Diego Director, Sonic Arts R&D and IDEAS Qualcomm Institute Email: sdy@ucsd.edu Web: http://yadegari.org
-
Alexandre Torres Porres -
Shahrokh Yadegari