Reading all of these GUI wish-list posts, I just finished adding colored signal patch cords. It seemed like the easiest. I should probably test it a little more before I release a patch (probably later tonight). It was pretty simple, just check whether the connecting outlet is a signal with obj_sigoutletindex() in canvas_drawlines() and canvas_doconnect().
I was wondering if anyone had an opinion as to what the signal patch cords should look like. I think Max/MSP does yellow with ~'s. My personal preference is a slightly thicker solid blue line. Tk does have a -dash parameter for canvas objects, but I think it looks pretty awful.
Joe
Here is the patch. It was diff'd against 0.35-test17. I decided to go with yellow since blue is the 'editing' color. I didn't have much time to test it, but it seems to work ok. This is really just a quick hack, there might be a cleaner and better way to do it.
Joe
On Tue, 23 Apr 2002, Joseph A. Sarlo wrote:
Reading all of these GUI wish-list posts, I just finished adding colored signal patch cords. It seemed like the easiest. I should probably test it a little more before I release a patch (probably later tonight). It was pretty simple, just check whether the connecting outlet is a signal with obj_sigoutletindex() in canvas_drawlines() and canvas_doconnect().
I was wondering if anyone had an opinion as to what the signal patch cords should look like. I think Max/MSP does yellow with ~'s. My personal preference is a slightly thicker solid blue line. Tk does have a -dash parameter for canvas objects, but I think it looks pretty awful.
Joe
Neat :) That does improve readability. How hard would it be to make the color and thickness user options?
On Tue, Apr 23, 2002 at 06:44:12PM -0400, Joseph A. Sarlo wrote:
Here is the patch. It was diff'd against 0.35-test17. I decided to go with yellow since blue is the 'editing' color. I didn't have much time to test it, but it seems to work ok. This is really just a quick hack, there might be a cleaner and better way to do it.
Joe
Hi,
congrats. I think that in fact is a very useful feature, as it signals a conceptually different thing optically and is much straighter than MSP's striped chords. I changed the mustard like color on my system to a dark bloodlike red, though (#99000 instead of #999900) not intending to get too metaphorical ;) and would vote to integrate it into pd.
-- Orm
Am Dienstag, den 23. April 2002 um 21:48:08 Uhr (-0500) schrieb Ben Saylor:
Neat :) That does improve readability. How hard would it be to make the color and thickness user options?
On Tue, Apr 23, 2002 at 06:44:12PM -0400, Joseph A. Sarlo wrote:
Here is the patch. It was diff'd against 0.35-test17. I decided to go with yellow since blue is the 'editing' color. I didn't have much time to test it, but it seems to work ok. This is really just a quick hack, there might be a cleaner and better way to do it.
Joe
On second thought: What do you think of changing the color or brightness if dsp is on/off? Couldn't that get implemented easily?
-- Orm
Am Dienstag, den 23. April 2002 um 21:48:08 Uhr (-0500) schrieb Ben Saylor:
Neat :) That does improve readability. How hard would it be to make the color and thickness user options?
On Tue, Apr 23, 2002 at 06:44:12PM -0400, Joseph A. Sarlo wrote:
Here is the patch. It was diff'd against 0.35-test17. I decided to go with yellow since blue is the 'editing' color. I didn't have much time to test it, but it seems to work ok. This is really just a quick hack, there might be a cleaner and better way to do it.
Joe
It probably wouldn't be too hard, but I'm not sure I understand why you would want this ;).
Joe
On Wed, 24 Apr 2002, Orm Finnendahl wrote:
On second thought: What do you think of changing the color or brightness if dsp is on/off? Couldn't that get implemented easily?
-- Orm
Am Dienstag, den 23. April 2002 um 21:48:08 Uhr (-0500) schrieb Ben Saylor:
Neat :) That does improve readability. How hard would it be to make the color and thickness user options?
On Tue, Apr 23, 2002 at 06:44:12PM -0400, Joseph A. Sarlo wrote:
Here is the patch. It was diff'd against 0.35-test17. I decided to go with yellow since blue is the 'editing' color. I didn't have much time to test it, but it seems to work ok. This is really just a quick hack, there might be a cleaner and better way to do it.
Joe
Not too hard, depending on how you wanted it done. Some kind of global PD gui properties option might be nice (some day). For now, you can just edit the patch file and re-compile :).
Joe
On Tue, 23 Apr 2002, Ben Saylor wrote:
Neat :) That does improve readability. How hard would it be to make the color and thickness user options?
On Tue, Apr 23, 2002 at 06:44:12PM -0400, Joseph A. Sarlo wrote:
Here is the patch. It was diff'd against 0.35-test17. I decided to go with yellow since blue is the 'editing' color. I didn't have much time to test it, but it seems to work ok. This is really just a quick hack, there might be a cleaner and better way to do it.
Joe
Hi,
here's another quick hack: segmented patch cords (sort of...)
I've just replaced the straight line cord with three lines. the horizontal part is allways exactly in the middle between outlet and inlet. The line one has to delete when deleting the connection is still a straight (and invissible) line between outlet and inlet (couln't find the corresponding code). The second known bug is the behaviour when an object is moved. This produces a straight line again...
The modyfied files (based on 0.35 test 17) can be downloaded at http://www.akustische-kunst.de/puredata/segcords.zip. To compile Pd 'SEGCORD' has to be defined (/DSEGCORD or -DSEGCORD) to get the segmented cords. It's really a fast hack, so please don't expect too much...
My personal wishlist for this would be:
cords (this could be: normal behaviour as allways + segmented patch cords when pressing alt-key on creation of cord)
often happens to me that I delete the wrong cords in overcrowded patches...)
Olaf
"Joseph A. Sarlo" schrieb:
Here is the patch. It was diff'd against 0.35-test17. I decided to go with yellow since blue is the 'editing' color. I didn't have much time to test it, but it seems to work ok. This is really just a quick hack, there might be a cleaner and better way to do it.
Joe
On Tue, 23 Apr 2002, Joseph A. Sarlo wrote:
Reading all of these GUI wish-list posts, I just finished adding colored signal patch cords. It seemed like the easiest. I should probably test it a little more before I release a patch (probably later tonight). It was pretty simple, just check whether the connecting outlet is a signal with obj_sigoutletindex() in canvas_drawlines() and canvas_doconnect().
I was wondering if anyone had an opinion as to what the signal patch cords should look like. I think Max/MSP does yellow with ~'s. My personal preference is a slightly thicker solid blue line. Tk does have a -dash parameter for canvas objects, but I think it looks pretty awful.
Joe
-- ______________________________ | | Joseph A. Sarlo | | jsarlo@mambo.peabody.jhu.edu |______________________________
Name: patch.diff
patch.diff Type: Plain Text (TEXT/PLAIN) Encoding: BASE64
hi Joseph,
very nice! I think you should have edited canvas_connect() in the same way, because otherwise one loses color after pasting/duplicating (use `obj_sigoutletindex(objsrc, outno)' in the condition).
Could you also evaluate my fix needed if `duplicate connections' are to be banned? It is in my post from 04/22/02. Since the two are related, maybe it would be better to submit them to Miller in one batch (or maybe not -- you be the judge).
Krzysztof
Joseph A. Sarlo wrote:
Here is the patch. It was diff'd against 0.35-test17. I decided to go with yellow since blue is the 'editing' color. I didn't have much time to test it, but it seems to work ok. This is really just a quick hack, there might be a cleaner and better way to do it.
I think you should have edited canvas_connect() in the same way, because otherwise one loses color after pasting/duplicating (use `obj_sigoutletindex(objsrc, outno)' in the condition).
Oops. I knew there was something else I needed to check. I remembered save/load, but forgot cut/paste. Thanks.
Could you also evaluate my fix needed if `duplicate connections' are to be banned? It is in my post from 04/22/02. Since the two are related, maybe it would be better to submit them to Miller in one batch (or maybe not -- you be the judge).
I just looked over your patch and at first glance it seems in order. I think this is probably a good thing, although, if PD had segmented patch cords I could see an argument for multiple connections as a feature.
As far as this color patch goes, I think the right way to do it would be to have the style strings (color, width, etc.) for signal and control patch cords defined somewhere so later they could be user defined at run-time, or at least so there would be only one place in the code to change them. For the quick hack patch I submitted, I wanted to change as few files as possible. I'm not sure I'm the person who should decide where these things should really go :).
| | Joseph A. Sarlo | | jsarlo@mambo.peabody.jhu.edu |______________________________