Hi
I'm experiencing an issue with ggee/shell object on linux : It makes pd crash if I create a gem window after having used shell.
On 19.03.19 12:20, Jean-Yves Gratius wrote:
Hi
I'm experiencing an issue with ggee/shell object on linux : It makes pd crash if I create a gem window after having used shell.
did you check https://github.com/umlaeute/Gem/issues/224 ?
fgmasdr IOhannes
On 19/03/2019 12:37, IOhannes m zmoelnig wrote:
did you check https://github.com/umlaeute/Gem/issues/224 ?
Thanks for the link, it is exactly the described problem.
So I changed |execvp()| instead of |system() in shell.c and it works now.| | | |I'll make a PR.| | | |Jean-Yves |
Well, I'd like to do a pull request for ggee/shell external. Which repository should I refer to ? https://github.com/pd-externals/ggee%C2%A0 ? https://github.com/reduzent/pd-ggee ?
On 19/03/2019 13:00, Jean-Yves Gratius wrote:
On 19/03/2019 12:37, IOhannes m zmoelnig wrote:
did you check https://github.com/umlaeute/Gem/issues/224 ?
Thanks for the link, it is exactly the described problem.
So I changed |execvp()| instead of |system() in shell.c and it works now.| | | |I'll make a PR.| | | |Jean-Yves |
Hi Jean-Yves
On Tue, 2019-03-19 at 18:26 +0100, Jean-Yves Gratius wrote:
Well, I'd like to do a pull request for ggee/shell external. Which repository should I refer to ? https://github.com/pd-externals/ggee ? https://github.com/reduzent/pd-ggee ?
The latter is mine and I created it from git2svn read-only repo because I was interested in having ggee has a Deken package. It seems, though, that the former has more recent commits. Personally, I'd prefer if the library was hosted at a central place and I don't actually need my personal fork.
I don't have access to the pd-externals group, so unless someone makes me a member, I'm not able to pull in your changes there. I could incorporate your changes in my fork, but I'd rather delete it than having two deviating forks on GitHub.
Roman
On 20.03.19 13:36, Roman Haefeli wrote:
Hi Jean-Yves
On Tue, 2019-03-19 at 18:26 +0100, Jean-Yves Gratius wrote:
Well, I'd like to do a pull request for ggee/shell external. Which repository should I refer to ? https://github.com/pd-externals/ggee ? https://github.com/reduzent/pd-ggee ?
The latter is mine and I created it from git2svn read-only repo because I was interested in having ggee has a Deken package. It seems, though, that the former has more recent commits.
the more recent commits are mostly me merging in your commits :-)
Personally, I'd prefer if the library was hosted at a central place and I don't actually need my personal fork.
+1
I don't have access to the pd-externals group, so unless someone makes me a member,
you now.
fgasdr IOhannes
On Wed, 2019-03-20 at 13:42 +0100, IOhannes m zmoelnig wrote:
Personally, I'd prefer if the library was hosted at a central place and I don't actually need my personal fork.
+1
Glad we agree.
I don't have access to the pd-externals group, so unless someone makes me a member,
you now.
Thanks! So, Jean-Yves, you probably know now where to put your pull requests ;-)
Roman