This is more likely related to platform margins and with the newer version of Tk, the metrics might be slightly different. Also, the zoom font sizing change may have lead to this as well.
The Pd extended styling adjusted the margins in slightly different ways to account for this and I've started a PR start experiment with porting over these tweaks: https://github.com/pure-data/pure-data/pull/162 https://github.com/pure-data/pure-data/pull/162
If this can't be adjusted, it would be good to know if the _new_ box sizes will be the canonical sizes.
Was there a canonical size before? We don't even have the same font on all platforms yet. I wouldn't plan on pixel perfect sizing yet...
It's way more than changing just the numbers in pd-gui.tcl and making per-platform metric numbers is probably a hack at best and headache at worst. In either case, IMO it's a lot of work and testing and thus may not happen *right now*.
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
Actually, one thing to try might be to re-enable forcing the Tk scaling value. It's commented out in pd-gui.tcl.
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
On Fre, 2017-08-11 at 10:54 +0200, Dan Wilcox wrote:
Actually, one thing to try might be to re-enable forcing the Tk scaling value. It's commented out in pd-gui.tcl.
Tk scaling seems to affect only: * Log-font in the Pd main window * Labels of iemguis * "Audio on/off" in the Pd main window
but not: * font size in objects, messages, float- and symbolatoms * box sizes of any of the above * Appearance of any dialogs
So: No, tk scaling doesn't help here.
Roman
On Fre, 2017-08-11 at 10:46 +0200, Dan Wilcox wrote:
Up until Pd 0.47 on macOS and up to somewhere between 0.46 and 0.47 on Linux, box sizes have been somewhat consistent, as far as I remember. At least non of my patches broke. On Windows, it was more of a gamble, it was not the same with every release and box sizing is dependent on whether you have "DejaVu Sans Mono" installed.
We don't even have the same font on all platforms yet. I wouldn't plan on pixel perfect sizing yet...
I do not plan on it, but trying my best make the current situation at least not worse.
Hm, I tested the numbers already in that I took care of getting the same box sizes for font size 10 on every platform as before (and between platforms). If there are more tests required to not break anything, I'm happy to test and report back.
I understand you're in a total different position than me and probably feel much more responsibility on your shoulders and thus I understand your reluctance. I don't have the skills to fix the issue the "clean" way, but I'm willing to invest some resources in this - presumably bytesting things - and I have access to Ubuntu 16.04, macOS 10.11 to 10.12 and Windows 10. If that can help in anyway, I'd be glad.
Roman
If we had a weekend, a few people, and enough different systems, we could probably find a solution.
In my thinking, I'm kind of pushing things in steps:
We're still working on Step 1 as the auto tools build is not working yet on Windows. I will probably get to that next at some point. I already have plans laid out for Step 2, but this relies on Step 1 working, etc. Having Step 1 means we can much more easily spread out the testing and tweaking to other people.
At the very least, it seems like Tk 8.4 is out on macOS 10.13 so it's a good thing I did the work to update Pd for Tk 8.5 on Mac, even if it does introduce a few wrinkles.
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
Thanks for the heads-up.
On Fre, 2017-08-11 at 12:03 +0200, Dan Wilcox wrote:
macOS and Linux are on the same page now, aren't they?
OK, cool. I hope to be part of the thourough-testing-department.
Really great work! Thanks.
Roman