I was trying to compile comport from cvs today and I noticed that it crashes pd when you close the port, so I looked into the code and found that the memcpy calls have the source and destination backwards, and the memset size and destination were reversed. Now closing a com port doesn't crash pd.
I'm wondering if the version I got from anonymous cvs yesterday (in externals/iem/comport) is really the latest version...
Martin
Sounds like a bug, please send a patch to the list and I'll apply
it. Piotr Majdak, Winfried Ritsch, and I all recently made changes
(past two months) so bugs are not surprising.
.hc
On Jun 4, 2006, at 12:08 AM, martinrp@alcor.concordia.ca wrote:
I was trying to compile comport from cvs today and I noticed that
it crashes pd when you close the port, so I looked into the code and found that
the memcpy calls have the source and destination backwards, and the memset
size and destination were reversed. Now closing a com port doesn't crash pd.I'm wondering if the version I got from anonymous cvs yesterday (in externals/iem/comport) is really the latest version...
Martin
--
PD-list@iem.at mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/ listinfo/pd-list
"I have the audacity to believe that peoples everywhere can have
three meals a day for their bodies, education and culture for their
minds, and dignity, equality and freedom for their spirits."
- Martin Luther King, Jr.
I have attached a 'cvs diff -uw' file for comport.c. I also made a bunch of formatting changes to make it more readable and conform to pd standard coding style. Sorry. The important parts are the lines with memcpy and memset. Also a use of errno when GetLastError should be used. Also the diff contains a __declspec(dllexport) on comport_setup that you probably don't want but it seems there should be an EXTERN there.
Martin
Quoting Hans-Christoph Steiner hans@eds.org:
Sounds like a bug, please send a patch to the list and I'll apply
it. Piotr Majdak, Winfried Ritsch, and I all recently made changes
(past two months) so bugs are not surprising..hc
On Jun 4, 2006, at 12:08 AM, martinrp@alcor.concordia.ca wrote:
I was trying to compile comport from cvs today and I noticed that
it crashes pd when you close the port, so I looked into the code and found that
the memcpy calls have the source and destination backwards, and the memset
size and destination were reversed. Now closing a com port doesn't crash pd.I'm wondering if the version I got from anonymous cvs yesterday (in externals/iem/comport) is really the latest version...
Martin
--
PD-list@iem.at mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/ listinfo/pd-list
"I have the audacity to believe that peoples everywhere can have
three meals a day for their bodies, education and culture for their
minds, and dignity, equality and freedom for their spirits." - Martin Luther King, Jr.
PD-list@iem.at mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/listinfo/pd-list
Didn't you request developer access? Did you ever get added? If
not, it seems to me that you should be. Then you could make these
changes directly.
.hc
On Jun 5, 2006, at 1:25 AM, martinrp@alcor.concordia.ca wrote:
I have attached a 'cvs diff -uw' file for comport.c. I also made a
bunch of formatting changes to make it more readable and conform to pd
standard coding style. Sorry. The important parts are the lines with memcpy and memset. Also a
use of errno when GetLastError should be used. Also the diff contains a __declspec(dllexport) on comport_setup
that you probably don't want but it seems there should be an EXTERN there.Martin
Quoting Hans-Christoph Steiner hans@eds.org:
Sounds like a bug, please send a patch to the list and I'll apply it. Piotr Majdak, Winfried Ritsch, and I all recently made changes (past two months) so bugs are not surprising.
.hc
On Jun 4, 2006, at 12:08 AM, martinrp@alcor.concordia.ca wrote:
I was trying to compile comport from cvs today and I noticed that it crashes pd when you close the port, so I looked into the code and found that the memcpy calls have the source and destination backwards, and the memset size and destination were reversed. Now closing a com port doesn't crash pd.
I'm wondering if the version I got from anonymous cvs yesterday (in externals/iem/comport) is really the latest version...
Martin
--
PD-list@iem.at mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/ listinfo/pd-list
"I have the audacity to believe that peoples everywhere can have three meals a day for their bodies, education and culture for their minds, and dignity, equality and freedom for their spirits." - Martin Luther King,
Jr.
PD-list@iem.at mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/listinfo/pd-list
-- <comport_diff.txt>
http://at.or.at/hans/
Quoting Hans-Christoph Steiner hans@eds.org:
Didn't you request developer access? Did you ever get added? If
not, it seems to me that you should be. Then you could make these
changes directly.
Well I'm not on the list here: https://sourceforge.net/project/memberlist.php?group_id=55736 I haven't tried logging on to cvs as mrpeach yet.
Martin
On Jun 11, 2006, at 1:57 PM, martinrp@alcor.concordia.ca wrote:
Quoting Hans-Christoph Steiner hans@eds.org:
Didn't you request developer access? Did you ever get added? If not, it seems to me that you should be. Then you could make these changes directly.
Well I'm not on the list here: https://sourceforge.net/project/memberlist.php?group_id=55736 I haven't tried logging on to cvs as mrpeach yet.
Sorry for the long delay, I just added you. I haven't committed the
comport patch yet if you want to do it.
.hc
Man has survived hitherto because he was too ignorant to know how to
realize his wishes. Now that he can realize them, he must either
change them, or perish. -William Carlos Williams