Hi,
The Jamoma library [1] fails to build since 035844b2 [2] with : multiple definition of "glist_reloadingabstraction". If I add "EXTERN" before glist_reloadingabstraction declaration in g_canvas.h and forward the declaration to g_canvas.c then the library builds fine (see [3]). But I'm not sure if this the right way to fix my issue. Please help me to figure out if I should open a PR or find another way to fix the issue.
Cheers
Antoine
[1] : https://github.com/jamoma/JamomaPureData [2] : https://sourceforge.net/p/pure-data/pure-data/ci/035844b25c066685ec9c21569f0... [3] : https://github.com/avilleret/pure-data/commit/1ecc6aae381039fafc641b5b3d2f06... -- do it yourself http://antoine.villeret.free.fr
I've updated the Pd source to make the change... I think you can just update your Pd submodule to fix it in your project.
cheers Miller
On Mon, Jun 20, 2016 at 11:32:23PM +0200, Antoine Villeret wrote:
Hi,
The Jamoma library [1] fails to build since 035844b2 [2] with : multiple definition of "glist_reloadingabstraction". If I add "EXTERN" before glist_reloadingabstraction declaration in g_canvas.h and forward the declaration to g_canvas.c then the library builds fine (see [3]). But I'm not sure if this the right way to fix my issue. Please help me to figure out if I should open a PR or find another way to fix the issue.
Cheers
Antoine
[1] : https://github.com/jamoma/JamomaPureData [2] : https://sourceforge.net/p/pure-data/pure-data/ci/035844b25c066685ec9c21569f0... [3] : https://github.com/avilleret/pure-data/commit/1ecc6aae381039fafc641b5b3d2f06... -- do it yourself http://antoine.villeret.free.fr
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management -> https://lists.puredata.info/listinfo/pd-list
hi Miller,
thanks, but it seems that you forgot to commit g_canvas.c. At least, I can't build pure-data at a02bdc4 [1]. FYI there is a pending PR on Github [2] that fixes the issue with [3]
cheers
Antoine
[1] : https://sourceforge.net/p/pure-data/pure-data/ci/a02bdc4118b625d82ceecb21a30... [2] : https://github.com/pure-data/pure-data/pull/21 [3] : https://github.com/pure-data/pure-data/pull/21/commits/1ecc6aae381039fafc641...
-- do it yourself http://antoine.villeret.free.fr
2016-06-22 22:37 GMT+02:00 Miller Puckette msp@ucsd.edu:
I've updated the Pd source to make the change... I think you can just update your Pd submodule to fix it in your project.
cheers Miller
On Mon, Jun 20, 2016 at 11:32:23PM +0200, Antoine Villeret wrote:
Hi,
The Jamoma library [1] fails to build since 035844b2 [2] with : multiple definition of "glist_reloadingabstraction". If I add "EXTERN" before glist_reloadingabstraction declaration in g_canvas.h and forward the declaration to g_canvas.c then the library builds fine (see [3]). But I'm not sure if this the right way to fix my issue. Please help me to figure out if I should open a PR or find another way to fix the issue.
Cheers
Antoine
[1] : https://github.com/jamoma/JamomaPureData [2] :
https://sourceforge.net/p/pure-data/pure-data/ci/035844b25c066685ec9c21569f0...
[3] :
https://github.com/avilleret/pure-data/commit/1ecc6aae381039fafc641b5b3d2f06...
-- do it yourself http://antoine.villeret.free.fr
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management ->
-
Antoine Villeret -
Miller Puckette