Is this compatible with https://github.com/pure-data/pure-data/pull/347/files? https://github.com/pure-data/pure-data/pull/347/files? Are there pros/cons between the implementations?
On Apr 17, 2018, at 12:00 PM, pd-list-request@lists.iem.at wrote:
From: Jonathan Wilkes <jancsika@yahoo.com mailto:jancsika@yahoo.com> To: pd-list <pd-list@iem.at mailto:pd-list@iem.at>, Christof Ressi <christof.ressi@gmx.at mailto:christof.ressi@gmx.at> Subject: Re: [PD] suggestion: $0 in messages Message-ID: <90704651.1049256.1523926967685@mail.yahoo.com mailto:90704651.1049256.1523926967685@mail.yahoo.com> Content-Type: text/plain; charset="utf-8"
On Saturday, April 7, 2018, 10:23:31 PM EDT, Jonathan Wilkes via Pd-list <pd-list@lists.iem.at mailto:pd-list@lists.iem.at> wrote:
On Friday, April 6, 2018, 11:21:05 AM EDT, Christof Ressi <christof.ressi@gmx.at mailto:christof.ressi@gmx.at> wrote:
here's an alternative implementation which uses no additional memory >> allocations but is more invasive: https://github.com/pure-data/pure-data/pull/347 https://github.com/pure-data/pure-data/pull/347Here's the beginning of another implementation with some performance tests:https://git.purrdata.net/jwilkes/purr-data/merge_requests/199 https://git.purrdata.net/jwilkes/purr-data/merge_requests/199
This has now been merged into 2.5.1. -Jonathan
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
I am biased of course, but checking for t_message_responder class within canvas_getdollarzero seems a bit weird to me. I rather preferred to add a function which gets the canvas $0 from a glist (which can be useful anyway) and made both binbuf_dorealizedollarsym and binbuf_doeval take the $0 value explicitly. but it's a matter of taste I guess.
Gesendet: Dienstag, 17. April 2018 um 14:10 Uhr Von: "Dan Wilcox" danomatika@gmail.com An: "Jonathan Wilkes" jancsika@yahoo.com Cc: Pd-List pd-list@lists.iem.at, "Christof Ressi" christof.ressi@gmx.at Betreff: Re: [PD] suggestion: $0 in messages
Is this compatible with https://github.com/pure-data/pure-data/pull/347/files?%C2%A0Are there pros/cons between the implementations? On Apr 17, 2018, at 12:00 PM, pd-list-request@lists.iem.at[mailto:pd-list-request@lists.iem.at] wrote: From: Jonathan Wilkes <jancsika@yahoo.com[mailto:jancsika@yahoo.com]> To: pd-list <pd-list@iem.at[mailto:pd-list@iem.at]>, Christof Ressi <christof.ressi@gmx.at[mailto:christof.ressi@gmx.at]> Subject: Re: [PD] suggestion: $0 in messages Message-ID: <90704651.1049256.1523926967685@mail.yahoo.com[mailto:90704651.1049256.1523926967685@mail.yahoo.com]> Content-Type: text/plain; charset="utf-8" On Saturday, April 7, 2018, 10:23:31 PM EDT, Jonathan Wilkes via Pd-list <pd-list@lists.iem.at[mailto:pd-list@lists.iem.at]> wrote: On Friday, April 6, 2018, 11:21:05 AM EDT, Christof Ressi <christof.ressi@gmx.at[mailto:christof.ressi@gmx.at]> wrote: here's an alternative implementation which uses no additional memory >> allocations but is more invasive: https://github.com/pure-data/pure-data/pull/347%5Bhttps://github.com/pure-da... the beginning of another implementation with some performance tests:https://git.purrdata.net/jwilkes/purr-data/merge_requests/199%5Bhttps://git.... has now been merged into 2.5.1. -Jonathan
Dan Wilcox @danomatika[http://twitter.com/danomatika] danomatika.com[http://danomatika.com] robotcowboy.com[http://robotcowboy.com]
On Tuesday, April 17, 2018, 8:43:26 AM EDT, Christof Ressi christof.ressi@gmx.at wrote:
I am biased of course, but checking for t_message_responder class within canvas_getdollarzero seems a bit weird to me.
Yeah, it should probably be renamed to something like pd_getdollarzero. It's not a public function so it's easy to change. -Jonathan
> On Tuesday, April 17, 2018, 8:10:47 AM EDT, Dan Wilcox <danomatika@gmail.com> wrote:
Is this compatible with https://github.com/pure-data/pure-data/pull/347/files?%C2%A0Are there pros/cons between the implementations?
This implementation doesn't require a change to binbuf_eval's interface. It also caches a glist instead of the dollarzero value. That seems a little cleaner since glist is public data and dollarzero isn't. Performance looks ok to me. -Jonathan
Ok, cool. We should port this as an alternate implementation PR on Github. I think it's worth trying to backport stuff like this and stay more in sync, when possible. Thanks for posting :)
enohp ym morf tnes
Dan Wilcox danomatika.com robotcowboy.com
On Apr 17, 2018, at 2:48 PM, Jonathan Wilkes jancsika@yahoo.com wrote:
On Tuesday, April 17, 2018, 8:10:47 AM EDT, Dan Wilcox danomatika@gmail.com wrote:
Is this compatible with https://github.com/pure-data/pure-data/pull/347/files? Are there pros/cons between the implementations?
This implementation doesn't require a change to binbuf_eval's interface. It also caches a glist instead of the dollarzero value. That seems a little cleaner since glist is public data and dollarzero isn't.
Performance looks ok to me.
-Jonathan
On Tuesday, April 17, 2018, 8:10:47 AM EDT, Dan Wilcox danomatika@gmail.com wrote:
Is this compatible with https://github.com/pure-data/pure-data/pull/347/files?%C2%A0Are there pros/cons between the implementations?
Also-- the code I merged into Purr Data adds a binbuf_error routine which links evaluation errors to the relevant object. Like when a user loads some monstrously large patch with many levels of nested abstractions and gets an error about an out-of-range argument. Now in Purr Data they can click a link to highlight the relevant message box (if it exists). Finally, there's an additional branch that was merged after this to add some simple regression tests. -Jonathan
-
Christof Ressi -
Dan Wilcox -
Jonathan Wilkes