Hi list,I found an issue when compiling zexy with msys2 on Windows: rawprint.c:28:5: error: conflicting types for '_get_output_format' int _get_output_format( void ){ return 0; } ^ In file included from C:/msys32/home/Owner/purr-data/pd/src/m_pd.h:68:0, from zexy.h:63, from rawprint.c:20: C:/msys32/mingw32/i686-w64-mingw32/include/stdio.h:520:32: note: previous declaration of '_get_output_format' was here _CRTIMP unsigned int __cdecl _get_output_format(void); ^ Makefile:1436: recipe for target 'rawprint.lo' failed
***Here's the relevant code snippet:#if !defined( _MSC_VER ) && defined (_WIN32) int _get_output_format( void ){ return 0; } #endif
-Jonathan
On 03/20/2016 03:53 AM, Jonathan Wilkes via Pd-list wrote:
Hi list,I found an issue when compiling zexy with msys2 on Windows:
(not so) cool. since i only every compile Pd for w32 with either VisualStudio or mingw64 (cross-compiling from linux), i'll happily accept patches, preferrably in some git-compatible format.
either send them by email, or via [github]. or by bribing gitlab.com into supporting cross-instance merge requests.
gmadsr IOhannes
I don't know how to differentiate between mingw64 and msys2, so unfortunately I can't offer you a patch. -Jonathan
On Sunday, March 20, 2016 3:29 PM, IOhannes m zmölnig <zmoelnig@iem.at> wrote:
On 03/20/2016 03:53 AM, Jonathan Wilkes via Pd-list wrote:
Hi list,I found an issue when compiling zexy with msys2 on Windows:
(not so) cool. since i only every compile Pd for w32 with either VisualStudio or mingw64 (cross-compiling from linux), i'll happily accept patches, preferrably in some git-compatible format.
either send them by email, or via [github]. or by bribing gitlab.com into supporting cross-instance merge requests.
gmadsr IOhannes
[github] https://github.com/iem-projects/pd-zexy
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/listinfo/pd-list
On 03/20/2016 08:43 PM, Jonathan Wilkes via Pd-list wrote:
I don't know how to differentiate between mingw64 and msys2, so unfortunately I can't offer you a patch.
hmm, too bad.
anyhow, older versions of zexy included a dummy replacement for _get_output_format(), but this has been dropped because it was no longer needed for "newer" versions of mingw. the commit-log says:
commit fc2548593f90df6f18de3d0e80c3804da98a0e9d Author: IOhannes m zmölnig zmoelnig@users.sourceforge.net Date: Wed Apr 22 21:32:58 2015 +0000
avoid redeclaration of _get_output_format() newer MinGW ships it. no idea how to detect this automatically
which suggests that the solution is to update your MinGW installatin (though i don't know what version you would need).
a workaround might be to just patch rawprint.c to enable the fix (rawprint.c:29)
gfmda IOhannes
On 03/20/2016 08:56 PM, IOhannes m zmölnig wrote:
which suggests that the solution is to update your MinG
hmm, no. actually, on re-reading your report it seems that the problem is, that you are using an outdated version of zexy, that still had the fix enabled (which breaks with "newer" MinGW").
please use the *current* release of zexy (which - at the time of writing
is v2.2.6)
gfmasdr IOhannes
Before I pin to a newer version, here's the only revision I could find from Pd-l2ork that needs to be merged upsteam. It just adds an A_CANT arg to the "dsp" method of signal objects for the off-chance that a user sends a "dsp" message manually. -Jonathan
On Sunday, March 20, 2016 4:46 PM, IOhannes m zmölnig <zmoelnig@iem.at> wrote:
On 03/20/2016 08:56 PM, IOhannes m zmölnig wrote:
which suggests that the solution is to update your MinG
hmm, no. actually, on re-reading your report it seems that the problem is, that you are using an outdated version of zexy, that still had the fix enabled (which breaks with "newer" MinGW").
please use the *current* release of zexy (which - at the time of writing
- is v2.2.6)
https://git.iem.at/pd/zexy/tags
gfmasdr IOhannes
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/listinfo/pd-list
On 2016-03-21 00:10, Jonathan Wilkes via Pd-list wrote:
Before I pin to a newer version, here's the only revision I could find from Pd-l2ork that needs to be merged upsteam. It just adds an A_CANT arg to the "dsp" method of signal objects for the off-chance that a user sends a "dsp" message manually.
thanks for the patch.
however: against which version of zexy is it supposed to apply? i tried both git-HEAD, the v2.2.6 release and the last master branch in the svn (before i dumped it) and the patch fails on all of these.
i also tried it on v2.2.5, where i at least succeeded to apply it, but still with some fuzz.
is there any specific reason to not use v2.2.6?
fgm,asdr IOhannes
On 2016-03-21 10:50, IOhannes m zmoelnig wrote:
is there any specific reason to not use v2.2.6?
also: would it be possible to send the patch in a format that git am
recognizes?
$ git am /tmp/acant.patch Patch format detection failed $ git --version git version 2.7.0
fgmasdr IOhannes
Yeah, I can do that. I'm not sure why it would fuzz, as the only changes are inserting A_CANT. -Jonathan
On Monday, March 21, 2016 5:58 AM, IOhannes m zmoelnig <zmoelnig@iem.at> wrote:
On 2016-03-21 10:50, IOhannes m zmoelnig wrote:
is there any specific reason to not use v2.2.6?
also: would it be possible to send the patch in a format that git am
recognizes?
$ git am /tmp/acant.patch Patch format detection failed $ git --version git version 2.7.0
fgmasdr IOhannes
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/listinfo/pd-list
Try the attached patch.
On Monday, March 21, 2016 10:43 AM, IOhannes m zmoelnig zmoelnig@iem.at wrote:
On 2016-03-21 15:38, Jonathan Wilkes via Pd-list wrote:
Yeah, I can do that. I'm not sure why it would fuzz, as the only changes are inserting A_CANT.
most likely because i'm trying to apply the patch onto another version of zexy than you.
fgmasdr IOhannes
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/listinfo/pd-list
There's no way msys2 ships an out of date version of mingw.
Looking at the repo you linked, it appears pd-l2ork is pinned to an older version of zexy-- one before that commit was applied. So once I pull from a more recent version this issue will go away-- no patches necessary. :)
Thanks,Jonathan
On Sunday, March 20, 2016 3:58 PM, IOhannes m zmölnig <zmoelnig@iem.at> wrote:
On 03/20/2016 08:43 PM, Jonathan Wilkes via Pd-list wrote:
I don't know how to differentiate between mingw64 and msys2, so unfortunately I can't offer you a patch.
hmm, too bad.
anyhow, older versions of zexy included a dummy replacement for _get_output_format(), but this has been dropped because it was no longer needed for "newer" versions of mingw. the commit-log says:
commit fc2548593f90df6f18de3d0e80c3804da98a0e9d Author: IOhannes m zmölnig zmoelnig@users.sourceforge.net Date: Wed Apr 22 21:32:58 2015 +0000
avoid redeclaration of _get_output_format()
newer MinGW ships it. no idea how to detect this automatically
which suggests that the solution is to update your MinGW installatin (though i don't know what version you would need).
a workaround might be to just patch rawprint.c to enable the fix (rawprint.c:29)
gfmda IOhannes
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/listinfo/pd-list
-
IOhannes m zmoelnig -
IOhannes m zmölnig
-
Jonathan Wilkes