Yes, please do so with all the relevant info: OS, behavior, steps you tried etc.
On Mar 22, 2022, at 3:00 AM, pd-list-request@lists.iem.at wrote:
Do you think it's worth opening an issue on pd's github?
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
Hi Dan,
Iohannes solution (change "use callbacks" state) seems to solve the problem. Anyway, I can open an issue to describe that in my case DSP only works with callbacks on.
Thanks for the answer and instructions,
cheers
Em ter., 22 de mar. de 2022 às 06:37, Dan Wilcox danomatika@gmail.com escreveu:
Yes, please do so with all the relevant info: OS, behavior, steps you tried etc.
On Mar 22, 2022, at 3:00 AM, pd-list-request@lists.iem.at wrote:
Do you think it's worth opening an issue on pd's github?
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com robotcowboy.com
Anyway, I can open an issue to describe that in my case DSP only works with callbacks on.
Yes, please! The Jack backend is supposed to work regardless of the "callback" setting.
Christof
On 22.03.2022 14:52, Bruno Rohde wrote:
Hi Dan,
Iohannes solution (change "use callbacks" state) seems to solve the problem. Anyway, I can open an issue to describe that in my case DSP only works with callbacks on.
Thanks for the answer and instructions,
cheers
Em ter., 22 de mar. de 2022 às 06:37, Dan Wilcox danomatika@gmail.com escreveu:
Yes, please do so with all the relevant info: OS, behavior, steps you tried etc.On Mar 22, 2022, at 3:00 AM, pd-list-request@lists.iem.at wrote: Do you think it's worth opening an issue on pd's github?-------- Dan Wilcox @danomatika <http://twitter.com/danomatika> danomatika.com <http://danomatika.com> robotcowboy.com <http://robotcowboy.com>-- Bruno Faria Rohde
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management ->https://lists.puredata.info/listinfo/pd-list
On Tue, 2022-03-22 at 14:56 +0100, Christof Ressi wrote:
Anyway, I can open an issue to describe that in my case DSP only works with callbacks on.
Yes, please! The Jack backend is supposed to work regardless of the "callback" setting.
But not regardless of the "delay (ms)" setting. If it is too low, Pd won't process audio. I don't know if there is a way to know beforehand what 'too low' is. It isn't necessarily a bug in Pd, I'd say.
Roman
On 3/22/22 15:06, Roman Haefeli wrote:
On Tue, 2022-03-22 at 14:56 +0100, Christof Ressi wrote:
Anyway, I can open an issue to describe that in my case DSP only works with callbacks on.
Yes, please! The Jack backend is supposed to work regardless of the "callback" setting.
But not regardless of the "delay (ms)" setting. If it is too low, Pd won't process audio. I don't know if there is a way to know beforehand what 'too low' is. It isn't necessarily a bug in Pd, I'd say.
it's probably a bug in Pd if the DSP and the GUI both freeze. (e.g. a solution as suggested by christof is to ensure the value is sane
- at least if we have some possibility to determine that beforehand)
gfmadr IOhannes
On Tue, 2022-03-22 at 15:23 +0100, IOhannes m zmoelnig wrote:
On 3/22/22 15:06, Roman Haefeli wrote:
On Tue, 2022-03-22 at 14:56 +0100, Christof Ressi wrote:
Anyway, I can open an issue to describe that in my case DSP only works with callbacks on.
Yes, please! The Jack backend is supposed to work regardless of the "callback" setting.
But not regardless of the "delay (ms)" setting. If it is too low, Pd won't process audio. I don't know if there is a way to know beforehand what 'too low' is. It isn't necessarily a bug in Pd, I'd say.
it's probably a bug in Pd if the DSP and the GUI both freeze.
Indeed, if the buffer is set too small, then Pd GUI freezes!
From my anecdotal testing, it looks like the critical value is predictable. As Christof said, the buffer cannot be smaller than JACK's blocksize.
For instance with JACK @ 256 samples @ 44.1kHz (5.8ms):
- Pd works with 6ms
- Pd freezes with 5ms
I guess the dialog could be designed in a way to set a lower boundary that is dependent on the detected JACK blocksize. I don't know, however, if Pd is able to detect the blocksize before DSP is turned on.
Roman
Actually, I just remember that I fixed a very similar issue with the ASIO backend. However, it was a bit more nasty, because Pd would simply crash if the "Delay" value was too low :-) My solution was too simply cap the value at the hardware blocksize:
https://github.com/pure-data/pure-data/blob/3ae0388c2ba354e2b5d818c1422b7484...
The problem with the Jack backend is that it caps at *Pd's* blocksize (64 samples) - which is often lower than the Jack buffersize. Consequently, the Jack callback might never have a chance to fill the ring buffer.
I think the solution is simple:
In /jack_open_audio()/ replace
if (advance_samples < DEFDACBLKSIZE) advance_samples = DEFDACBLKSIZE;
with
if (advance_samples < jack_blocksize) advance_samples = jack_blocksize;
@Roman: can you give this a try?
Christof
On 22.03.2022 15:39, Roman Haefeli wrote:
On Tue, 2022-03-22 at 15:23 +0100, IOhannes m zmoelnig wrote:
On 3/22/22 15:06, Roman Haefeli wrote:
On Tue, 2022-03-22 at 14:56 +0100, Christof Ressi wrote:
Anyway, I can open an issue to describe that in my case DSP only works with callbacks on.
Yes, please! The Jack backend is supposed to work regardless of the "callback" setting.
But not regardless of the "delay (ms)" setting. If it is too low, Pd won't process audio. I don't know if there is a way to know beforehand what 'too low' is. It isn't necessarily a bug in Pd, I'd say.
it's probably a bug in Pd if the DSP and the GUI both freeze.
Indeed, if the buffer is set too small, then Pd GUI freezes!
From my anecdotal testing, it looks like the critical value is predictable. As Christof said, the buffer cannot be smaller than JACK's blocksize.
For instance with JACK @ 256 samples @ 44.1kHz (5.8ms):
- Pd works with 6ms
- Pd freezes with 5ms
I guess the dialog could be designed in a way to set a lower boundary that is dependent on the detected JACK blocksize. I don't know, however, if Pd is able to detect the blocksize before DSP is turned on.
Roman
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management ->https://lists.puredata.info/listinfo/pd-list
On Tue, 2022-03-22 at 16:00 +0100, Christof Ressi wrote:
I think the solution is simple:
In jack_open_audio() replace
if (advance_samples < DEFDACBLKSIZE) advance_samples = DEFDACBLKSIZE; with
if (advance_samples < jack_blocksize) advance_samples = jack_blocksize; @Roman: can you give this a try?
Yeah, it works. Now - without callbacks - it works with any setting for 'delay (ms)'. Of course, now the displayed settings doesn't always reflect the setting used internally.
Roman
Of course, now the displayed settings doesn't always reflect the setting used internally.
We could post a little notice that the delay setting has been capped. Probably also for the ASIO backend. But that's just cosmetics.
@umlaeute: should I push the quick fix below to develop?
Christof
On 22.03.2022 16:26, Roman Haefeli wrote:
On Tue, 2022-03-22 at 16:00 +0100, Christof Ressi wrote:
I think the solution is simple:
In jack_open_audio() replace
if (advance_samples < DEFDACBLKSIZE) advance_samples = DEFDACBLKSIZE; with
if (advance_samples < jack_blocksize) advance_samples = jack_blocksize; @Roman: can you give this a try?
Yeah, it works. Now - without callbacks - it works with any setting for 'delay (ms)'. Of course, now the displayed settings doesn't always reflect the setting used internally.
Roman
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management -> https://lists.puredata.info/listinfo/pd-list
As it looks like you guys are working on a quick and simple solution, I'll wait a bit to see if it's really necessary to file a bug. If it's still relevant, I can do it later.
Em ter., 22 de mar. de 2022 às 12:33, Christof Ressi info@christofressi.com escreveu:
Of course, now the displayed settings doesn't always reflect the setting
used internally. We could post a little notice that the delay setting has been capped. Probably also for the ASIO backend. But that's just cosmetics.
@umlaeute: should I push the quick fix below to develop?
Christof
On 22.03.2022 16:26, Roman Haefeli wrote:
On Tue, 2022-03-22 at 16:00 +0100, Christof Ressi wrote:
I think the solution is simple:
In jack_open_audio() replace
if (advance_samples < DEFDACBLKSIZE) advance_samples = DEFDACBLKSIZE; with
if (advance_samples < jack_blocksize) advance_samples = jack_blocksize; @Roman: can you give this a try?
Yeah, it works. Now - without callbacks - it works with any setting for 'delay (ms)'. Of course, now the displayed settings doesn't always reflect the setting used internally.
Roman
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management ->
https://lists.puredata.info/listinfo/pd-list
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management -> https://lists.puredata.info/listinfo/pd-list
I think the bug report isn't needed, thanks.
Meanwhile, yes, it would be appropriate to print a message that the delay got reset, and yes, please do throw it in the develop PR.
thanks M
On Tue, Mar 22, 2022 at 12:43:08PM -0300, Bruno Rohde wrote:
As it looks like you guys are working on a quick and simple solution, I'll wait a bit to see if it's really necessary to file a bug. If it's still relevant, I can do it later.
Em ter., 22 de mar. de 2022 Ã s 12:33, Christof Ressi info@christofressi.com escreveu:
Of course, now the displayed settings doesn't always reflect the setting
used internally. We could post a little notice that the delay setting has been capped. Probably also for the ASIO backend. But that's just cosmetics.
@umlaeute: should I push the quick fix below to develop?
Christof
On 22.03.2022 16:26, Roman Haefeli wrote:
On Tue, 2022-03-22 at 16:00 +0100, Christof Ressi wrote:
I think the solution is simple:
In jack_open_audio() replace
if (advance_samples < DEFDACBLKSIZE) advance_samples = DEFDACBLKSIZE; with
if (advance_samples < jack_blocksize) advance_samples = jack_blocksize; @Roman: can you give this a try?
Yeah, it works. Now - without callbacks - it works with any setting for 'delay (ms)'. Of course, now the displayed settings doesn't always reflect the setting used internally.
Roman
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management ->
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.puredata.info_lis...
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management -> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.puredata.info_lis...
-- Bruno Faria Rohde
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management -> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.puredata.info_lis...
Cool, thanks. Even if there is an (easy) solution, it's good to submit the point that Pd probably shouldn't stop working completely when a checkbox is changed in the settings. :)
On Mar 22, 2022, at 2:52 PM, Bruno Rohde brunorohde@gmail.com wrote:
Hi Dan,
Iohannes solution (change "use callbacks" state) seems to solve the problem. Anyway, I can open an issue to describe that in my case DSP only works with callbacks on.
Thanks for the answer and instructions,
cheers
Em ter., 22 de mar. de 2022 às 06:37, Dan Wilcox <danomatika@gmail.com mailto:danomatika@gmail.com> escreveu: Yes, please do so with all the relevant info: OS, behavior, steps you tried etc.
On Mar 22, 2022, at 3:00 AM, pd-list-request@lists.iem.at mailto:pd-list-request@lists.iem.at wrote:
Do you think it's worth opening an issue on pd's github?
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
-- Bruno Faria Rohde
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
Cool, thanks. Even if there is an (easy) solution, it's good to submit the point that Pd probably shouldn't stop working completely when a checkbox is changed in the settings. :)
Done!
Em ter., 22 de mar. de 2022 às 13:28, Dan Wilcox danomatika@gmail.com escreveu:
Cool, thanks. Even if there is an (easy) solution, it's good to submit the point that Pd probably shouldn't stop working completely when a checkbox is changed in the settings. :)
On Mar 22, 2022, at 2:52 PM, Bruno Rohde brunorohde@gmail.com wrote:
Hi Dan,
Iohannes solution (change "use callbacks" state) seems to solve the problem. Anyway, I can open an issue to describe that in my case DSP only works with callbacks on.
Thanks for the answer and instructions,
cheers
Em ter., 22 de mar. de 2022 às 06:37, Dan Wilcox danomatika@gmail.com escreveu:
Yes, please do so with all the relevant info: OS, behavior, steps you tried etc.
On Mar 22, 2022, at 3:00 AM, pd-list-request@lists.iem.at wrote:
Do you think it's worth opening an issue on pd's github?
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com robotcowboy.com
-- Bruno Faria Rohde
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com robotcowboy.com
What does the 'use callbacks' exactly do? I guess PD always fills the audio buffer by callback (?).
Obtén l'Outlook per a l'Androidhttps://aka.ms/AAb9ysg ________________________________ From: Pd-list pd-list-bounces@lists.iem.at on behalf of Bruno Rohde brunorohde@gmail.com Sent: Tuesday, March 22, 2022 2:52:25 PM To: Dan Wilcox danomatika@gmail.com Cc: Pd-List pd-list@lists.iem.at Subject: Re: [PD] Pd 0.52-1 - frozen dsp and gui in ubuntu 20.04
Hi Dan,
Iohannes solution (change "use callbacks" state) seems to solve the problem. Anyway, I can open an issue to describe that in my case DSP only works with callbacks on.
Thanks for the answer and instructions,
cheers
Em ter., 22 de mar. de 2022 às 06:37, Dan Wilcox <danomatika@gmail.commailto:danomatika@gmail.com> escreveu: Yes, please do so with all the relevant info: OS, behavior, steps you tried etc.
On Mar 22, 2022, at 3:00 AM, pd-list-request@lists.iem.atmailto:pd-list-request@lists.iem.at wrote:
Do you think it's worth opening an issue on pd's github?
Dan Wilcox @danomatikahttp://twitter.com/danomatika danomatika.comhttp://danomatika.com robotcowboy.comhttp://robotcowboy.com
-- Bruno Faria Rohde
Hi Jeppi,
I have already explained it in a previous mail.
Christof
On 22.03.2022 17:55, Jeppi Jeppi wrote:
What does the 'use callbacks' exactly do? I guess PD always fills the audio buffer by callback (?).
Obtén l'Outlook per a l'Android https://aka.ms/AAb9ysg
*From:* Pd-list pd-list-bounces@lists.iem.at on behalf of Bruno Rohde brunorohde@gmail.com *Sent:* Tuesday, March 22, 2022 2:52:25 PM *To:* Dan Wilcox danomatika@gmail.com *Cc:* Pd-List pd-list@lists.iem.at *Subject:* Re: [PD] Pd 0.52-1 - frozen dsp and gui in ubuntu 20.04 Hi Dan,
Iohannes solution (change "use callbacks" state) seems to solve the problem. Anyway, I can open an issue to describe that in my case DSP only works with callbacks on.
Thanks for the answer and instructions,
cheers
Em ter., 22 de mar. de 2022 às 06:37, Dan Wilcox danomatika@gmail.com escreveu:
Yes, please do so with all the relevant info: OS, behavior, steps you tried etc.On Mar 22, 2022, at 3:00 AM, pd-list-request@lists.iem.at wrote: Do you think it's worth opening an issue on pd's github?-------- Dan Wilcox @danomatika <http://twitter.com/danomatika> danomatika.com <http://danomatika.com> robotcowboy.com <http://robotcowboy.com>-- Bruno Faria Rohde
Pd-list@lists.iem.at mailing list UNSUBSCRIBE and account-management ->https://lists.puredata.info/listinfo/pd-list
-
Bruno Rohde -
Christof Ressi -
Dan Wilcox -
IOhannes m zmoelnig -
Jeppi Jeppi -
Miller Puckette -
Roman Haefeli