I agree that 0 makes much more sense for turning off.

I've always found it easiest to put [; (patch name) editmode 1, (commands), editmode 0] into one message box so that I would always avoid problems, but it makes sense to fix it anyway.

On the same topic, last time I experimented with this command, I found it necessary to put "vis 1" and "vis 0" surrounding my editmode commands if the edited patch wasn't already visible. This seemed to make sense to me at the time, but it could be cumbersome to deal with in situations where the edited patch may or may not need to be/stay visible.

I've experienced no graphical problems due to the "vis" messages (when they're that fast), but in any case where you might like to delay between the editing commands, you would probably need to resend the "vis" and "editmode" commands to avoid having the edited window pop up momentarily.

-Stephen

On Sat, Jan 9, 2010 at 5:46 PM, Miller Puckette mpuckett@imusic1.ucsd.eduwrote:

Hi all,

I think it would be much better to have '0' turn editmode off -- I'm not sure if anyone else has patches that depend on sending canvases 'editmode' messages, though, so if someone does, please speak up.

cheers Miller

On Sat, Jan 09, 2010 at 04:54:05PM -0500, Hans-Christoph Steiner wrote:

...

Hey all,

I'm just looking at the editmode message internal message. It takes a float of 0 or 1, but that 0 or 1 means something unexpected:

1 = turn on editmode (logical) 0 = toggle editmode (not quite)

Anyone see any reason to leave it like that? Now that the GUI is totally new code, it would be an easy change.

.hc

---

...

News is what people want to keep hidden and everything else is publicity. - Bill Moyers

---

Pd-list@iem.at mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/listinfo/pd-list

---

Pd-list@iem.at mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/listinfo/pd-list

On Jan 11, 2010, at 3:47 AM, IOhannes m zmoelnig wrote:

Miller Puckette wrote:

...

Hi all,

I think it would be much better to have '0' turn editmode off -- I'm not sure if anyone else has patches that depend on sending canvases 'editmode' messages, though, so if someone does, please
speak up.

a request to change this to set rather than toggle has been in the bugtracker since 2007. https://sourceforge.net/tracker/index.php?func=detail&aid=1722081&gr...

i fully agree that it should be changed, so that "editmode 0" means "runmode".

fgmasdr IOhannes

Done on pd-gui-rewrite branch: http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=...

The C change was small, but it made handling the Edit Mode menu item
soooo much easier :-D

.hc

                         kill your television