On Wed, 2021-01-27 at 22:59 -0300, Alexandre Torres Porres wrote:
It's only missing binaries for windows64 bits, linux64 bits and raspberry pi versions. Hopefully other people can build and upload them.
I'd be glad to help out here. I don't know how to build it, though.
Simply running make
gives me errors¹. I tested on Linux amd64 and
i386.
To my (not so well-trained) eyes, things look still a bit rough on the edges. It's not using pd-lib-builder, it comes with an included m_pd.h, it seems to want to create a pd_darwin file (don't know how to override this). Before doing any release, it should be IMHO in a more mature state, much preferably with a pd-lib-builder Makefile.
And - please ! - do not commit building artifacts to a source code repository. It's generally considered bad practice.
For me to be able to help providing binaries, it needs to be as simple as running make. I won't be able to spend much time on it otherwise.
That said, I welcome your efforts bringing interesting externals to the masses. But we should acknowledge the amount of work it requires and not rush things through.
Roman
¹:
pd-soundtouch/src[(HEAD detached at 0.9)]$ make
g++ -DPD -O3 -Wall -W -Wshadow -Wno-unused -Wno-parentheses -Wno-switch -fcheck-new -fvisibility=hidden -I ./include -c *.cpp
soundtouch~.cpp: In function ‘void soundtouch_tilde_setup()’:
soundtouch~.cpp:312:67: warning: cast between incompatible function types from ‘void* (*)(t_floatarg, t_floatarg)’ {aka ‘void* (*)(float, float)’} to ‘t_newmethod’ {aka ‘void* (*)()’} [-Wcast-function-type]
312 | soundtouch_class = class_new(gensym("soundtouch~"), (t_newmethod)soundtouch_new,
| ^~~~~~~~~~~~~~
g++ -bundle -undefined suppress -flat_namespace -o soundtouch~.pd_darwin *.o
g++: error: suppress: No such file or directory
g++: error: unrecognized command line option ‘-bundle’
g++: error: unrecognized command line option ‘-flat_namespace’
make: *** [Makefile:47: soundtouch~.pd_darwin] Error 1