Yup, and we already have such checks for the ttk stuff at the top of pd-gui.tcl. If tabs aren’t supported, then dialogs and their related menu items should be added, otherwise the single menu item for the preferences.
enohp ym morf tnes
Dan Wilcox danomatika.com robotcowboy.com
On Jun 21, 2023, at 1:43 PM, Christof Ressi info@christofressi.com wrote:
Thanks for clarifying!
Anyway, my take-away is that a simple runtime check for Tcl/Tk 8.x+ could be a viable solution.
On 21.06.2023 13:39, Dan Wilcox wrote: It nominally uses the Tk frameworks in the .app bundle *but* someone could always build using a different Tk which could lead to issues. Also, people trying to run Pd on the command line from the build folder without making an app bundle end up using the system Tk. This works ok for testing basic things but is bad news for normal usage.
enohp ym morf tnes
Dan Wilcox danomatika.com robotcowboy.com
On Jun 21, 2023, at 12:55 PM, Christof Ressi info@christofressi.com wrote:
Thanks for chiming in!
Tabs should default unless a min version check on the platform fails.
That's what I figured.
especially the buggy one that used to be included with macOS itself.
Wouldn't the Pd app prefer the bundled Tk version? (I don't know these things work on macOS.)
Christof
On 21.06.2023 12:42, Dan Wilcox wrote: I think min Tk version for macOS and tabs should be 8.6.10 or 11. We may possible also need an os version check, hopefully not.
The main thing to avoid is if anyone runs an older Tk 8.6, especially the buggy one that used to be included with macOS itself.
enohp ym morf tnes
Dan Wilcox danomatika.com robotcowboy.com
On Jun 21, 2023, at 12:38 PM, Dan Wilcox danomatika@gmail.com wrote:
I agree. Tabs should default unless a min version check on the platform fails. The original suggestion for making the option to still host dialogs in windows was mine, I believe, large for this reason, ie. building for OS X 10.6 and Tk 8.4 which doesn’t have the tabs widget.
enohp ym morf tnes
Dan Wilcox danomatika.com robotcowboy.com
On Jun 21, 2023, at 12:07 PM, Christof Ressi info@christofressi.com wrote:
> basically, because some TclTk versions on macOS would just crash when using tabs. Wow, Tk never ceases to amaze me...
Does this also happen with the Tcl/Tk version that is included in the "official" macOS app bundle?
Could we do a runtime check for specific Tcl/Tk versions that are known to work?
I think the tabbed preferences are just so nice and it would be shame to hide them from the user by default...
(At the very least, we should use tabbed preference by default on Windows and Linux :-)
Christof
> On 21.06.2023 00:07, IOhannes m zmölnig wrote: >>> On 6/20/23 20:35, Christof Ressi wrote: >>> First off: thanks Miller for this historic release :-) >>> >>> I just discovered the new tabbed preferences and I really like them! Thanks IOhannes! >>> >>> Question: why do we have both tabbed and non-tabbed preferences? This feels very weird to me. I don't see any advantages in the non-tabbed preferences... (I find them rather grotesque). > basically, because some TclTk versions on macOS would just crash when using tabs. > so I needed a fallback for this case anyhow (that, albeit grotesque, is still somewhat useable) > > > > gmds > IOhannes > > _______________________________________________ > Pd-list@lists.iem.at mailing list > UNSUBSCRIBE and account-management -> https://lists.puredata.info/listinfo/pd-list