Here is one:
- Don't check the type of the atoms. Just output inside the loop using outlet_list That way you don't have to care if there happen to be other types of atoms (like gpointers, blobs, etc.)
To complete it in 10 mins:
- git diff filename.pd > whatever.patch
- submitting patch to tracker == emailing Miller and list (if not then you must have left something out of your general outline of free software dev process)
-Jonathan
On Friday, October 10, 2014 2:00 AM, Chris McCormick chris@mccormick.cx wrote:
On 02/10/14 09:24, Jonathan Wilkes via Pd-list wrote:
If that's all [list foreach] is supposed to do I'll go ahead and implement this in Pd-l2ork when I get a spare 10 mins.
The actual code took me about half an hour to adapt from other list objects. I realise that is slow. What took a bit longer was:
- Updating the help patch.
- Making the correctly formatted patch.
- Submitting the patch to Sourceforge.
- Emailing Miller and the list.
The patch may well come back with comments in which case that time will be longer. My patch lacks some of the features you outlined. Would have taken me longer if I had added those features too. I feel like "spare 10 mins" is lowballing the time required in any case and maybe that is one of the reasons nobody else did it.
Note that if you implemented it with your specification in Pd-l2ork and I implemented it my way and it got accepted into Pd-miller then we would have incompatible binaries. Urgk! I guess that's an advantage of mailing list consensus before action.
Cheers,
Chris.