On 03/21/2013 03:12 PM, Ivica Ico Bukvic wrote:
IOhannes,
Your patch has one regression:
--- a/src/x_connective.c +++ b/src/x_connective.c @@ -991,6 +991,8 @@ static void trigger_list(t_trigger *x, t_symbol *s, int argc, t_atom *argv) else if (u->u_type == TR_SYMBOL) outlet_symbol(u->u_outlet, (argc ? atom_getsymbol(argv) : &s_symbol));
else if (u->u_type == TR_ANYTHING)
outlet_anything(u->u_outlet, s, argc, argv); else if (u->u_type == TR_POINTER) { if (!argc || argv->a_type != TR_POINTER)
This part causes pointers to not properly propagate through the trigger objects. If you run scalar-help.pd file (part of pd-extended/pd-l2ork documentation developed by Jonathan and others), clicking on scalars that should animate generates an error. Removing this works fine for scalars but I wonder if it then disables functionality of the patch you provided.
Any thoughts?
As of right now, I cannot see any regressions by removing that part since at the end it does output_list call anyhow. Can you test this/confirm?