Pd-dev December 2012

pd-dev@lists.iem.at

14 participants
173 discussions

[ pure-data-Patches-3594735 ] Win32: unicode support for files with public API for externs
by SourceForge.net 17 Dec '12

17 Dec '12

Patches item #3594735, was opened at 2012-12-10 19:14 Message generated for change (Settings changed) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix >Status: Closed >Resolution: Accepted Priority: 7 Private: No Submitted By: Hans-Christoph Steiner (eighthave) Assigned to: Miller Puckette (millerpuckette) Summary: Win32: unicode support for files with public API for externs Initial Comment: Right now, Pd on Windows does really badly if there are any non-ASCII characters in the path or filename. It makes it freeze for a while, and sometimes crashes it. These patches fix that. Pd and Tcl/Tk is UTF-8 internally, and UNIXes all use UTF-8 for filenames and paths. Windows uses UCS-2 everywhere, which is a 16-bit format. The only place this affects Pd is reading and writing filenames, and printing to the console. The POSIX-style functions open() and fopen() exist on Windows, but only work for ASCII filenames. To support Unicode filenames, we have to convert the UTF-8 to UCS-2, then use Win32-specific functions. Since any external that opens files will also be affected the same way, this patch provides a public API: sys_open()/sys_close(), and sys_fopen()/sys_fclose(). For non-Win32 platforms, they are just names that point to the normal POSIX versions. On Win32, they are special functions to handle UTF-8 to UCS-2 conversion. I have built and run this on Windows XP, Mac OS X 10.6, and Debian/squeeze amd64. These patches are also included in Pd-extended 0.43.4. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2012-12-16 16:29 Message: Got 'em & pushed to repo... will re-apply the other patches later. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2012-12-16 15:34 Message: OK -- I'll see if I can unwind the other patch and apply this one - if that works I'll go and fix the stdint stuff somehow that I can live with :) ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-16 12:28 Message: I agree that its good to avoid putting #includes in m_pd.h stdint.h is a stable and widespread as stddef.h, which has been part of m_pd.h for a long time. I put '#include <stdint.h>" because that's the only header that was already included everywhere that needs types defined in stdint.h. Another option would be to put the int32_t, etc. definitions in s_stuff.h or some other header, and then add that header everywhere its needed. As for the patches not applying, that's because you accepted 3 patches from Marvin Humpreys that removes lots of code from s_utf8.* and that conflicts with these patches. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2012-12-15 18:39 Message: For some reason I can't apply the first patch (I get: error: patch failed: src/s_utf8.c:26 error: src/s_utf8.c: patch does not apply error: patch failed: src/s_utf8.h:1 error: src/s_utf8.h: patch does not apply --- even though my eyeballs can't see any reason that would fail. Anyway, I'd like not to have m_pd.h be in the business of pulling in other include files (except as needed to define its own data structures) as I think that's a threat to future portability - can this be fixed to leave m_pd.h, d_soundfile.h, etc., alone and just "do the necessary" to the UTF-8 code? thanks Miller ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-11 21:44 Message: These are all the externals in Pd-extended that need changes to support Unicode filenames: http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio… http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio… http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio… Basically, you just need to change open() to sys_open() and fopen() to sys_fopen(). You can remove sys_bashfilename() since its included in those new open functions when needed. ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-11 21:25 Message: and a couple more for good measure ;) ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-11 19:37 Message: I added a fifth patch. Microsoft says that the POSIX close() was deprecated in 2005, and to use their ISO C++ _close() instead. http://msdn.microsoft.com/en-US/library/ms235443(v=vs.80).aspx http://msdn.microsoft.com/en-US/library/5fzwd5ss(v=vs.80).aspx ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_…

1 0

[ pure-data-Patches-3594735 ] Win32: unicode support for files with public API for externs
by SourceForge.net 17 Dec '12

17 Dec '12

Patches item #3594735, was opened at 2012-12-10 19:14 Message generated for change (Comment added) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix Status: Open Resolution: None Priority: 7 Private: No Submitted By: Hans-Christoph Steiner (eighthave) Assigned to: Miller Puckette (millerpuckette) Summary: Win32: unicode support for files with public API for externs Initial Comment: Right now, Pd on Windows does really badly if there are any non-ASCII characters in the path or filename. It makes it freeze for a while, and sometimes crashes it. These patches fix that. Pd and Tcl/Tk is UTF-8 internally, and UNIXes all use UTF-8 for filenames and paths. Windows uses UCS-2 everywhere, which is a 16-bit format. The only place this affects Pd is reading and writing filenames, and printing to the console. The POSIX-style functions open() and fopen() exist on Windows, but only work for ASCII filenames. To support Unicode filenames, we have to convert the UTF-8 to UCS-2, then use Win32-specific functions. Since any external that opens files will also be affected the same way, this patch provides a public API: sys_open()/sys_close(), and sys_fopen()/sys_fclose(). For non-Win32 platforms, they are just names that point to the normal POSIX versions. On Win32, they are special functions to handle UTF-8 to UCS-2 conversion. I have built and run this on Windows XP, Mac OS X 10.6, and Debian/squeeze amd64. These patches are also included in Pd-extended 0.43.4. ---------------------------------------------------------------------- >Comment By: Miller Puckette (millerpuckette) Date: 2012-12-16 16:29 Message: Got 'em & pushed to repo... will re-apply the other patches later. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2012-12-16 15:34 Message: OK -- I'll see if I can unwind the other patch and apply this one - if that works I'll go and fix the stdint stuff somehow that I can live with :) ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-16 12:28 Message: I agree that its good to avoid putting #includes in m_pd.h stdint.h is a stable and widespread as stddef.h, which has been part of m_pd.h for a long time. I put '#include <stdint.h>" because that's the only header that was already included everywhere that needs types defined in stdint.h. Another option would be to put the int32_t, etc. definitions in s_stuff.h or some other header, and then add that header everywhere its needed. As for the patches not applying, that's because you accepted 3 patches from Marvin Humpreys that removes lots of code from s_utf8.* and that conflicts with these patches. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2012-12-15 18:39 Message: For some reason I can't apply the first patch (I get: error: patch failed: src/s_utf8.c:26 error: src/s_utf8.c: patch does not apply error: patch failed: src/s_utf8.h:1 error: src/s_utf8.h: patch does not apply --- even though my eyeballs can't see any reason that would fail. Anyway, I'd like not to have m_pd.h be in the business of pulling in other include files (except as needed to define its own data structures) as I think that's a threat to future portability - can this be fixed to leave m_pd.h, d_soundfile.h, etc., alone and just "do the necessary" to the UTF-8 code? thanks Miller ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-11 21:44 Message: These are all the externals in Pd-extended that need changes to support Unicode filenames: http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio… http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio… http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio… Basically, you just need to change open() to sys_open() and fopen() to sys_fopen(). You can remove sys_bashfilename() since its included in those new open functions when needed. ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-11 21:25 Message: and a couple more for good measure ;) ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-11 19:37 Message: I added a fifth patch. Microsoft says that the POSIX close() was deprecated in 2005, and to use their ISO C++ _close() instead. http://msdn.microsoft.com/en-US/library/ms235443(v=vs.80).aspx http://msdn.microsoft.com/en-US/library/5fzwd5ss(v=vs.80).aspx ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_…

1 0

[ pure-data-Patches-3594735 ] Win32: unicode support for files with public API for externs
by SourceForge.net 17 Dec '12

17 Dec '12

Patches item #3594735, was opened at 2012-12-10 19:14 Message generated for change (Comment added) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix Status: Open Resolution: None Priority: 7 Private: No Submitted By: Hans-Christoph Steiner (eighthave) Assigned to: Miller Puckette (millerpuckette) Summary: Win32: unicode support for files with public API for externs Initial Comment: Right now, Pd on Windows does really badly if there are any non-ASCII characters in the path or filename. It makes it freeze for a while, and sometimes crashes it. These patches fix that. Pd and Tcl/Tk is UTF-8 internally, and UNIXes all use UTF-8 for filenames and paths. Windows uses UCS-2 everywhere, which is a 16-bit format. The only place this affects Pd is reading and writing filenames, and printing to the console. The POSIX-style functions open() and fopen() exist on Windows, but only work for ASCII filenames. To support Unicode filenames, we have to convert the UTF-8 to UCS-2, then use Win32-specific functions. Since any external that opens files will also be affected the same way, this patch provides a public API: sys_open()/sys_close(), and sys_fopen()/sys_fclose(). For non-Win32 platforms, they are just names that point to the normal POSIX versions. On Win32, they are special functions to handle UTF-8 to UCS-2 conversion. I have built and run this on Windows XP, Mac OS X 10.6, and Debian/squeeze amd64. These patches are also included in Pd-extended 0.43.4. ---------------------------------------------------------------------- >Comment By: Miller Puckette (millerpuckette) Date: 2012-12-16 15:34 Message: OK -- I'll see if I can unwind the other patch and apply this one - if that works I'll go and fix the stdint stuff somehow that I can live with :) ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-16 12:28 Message: I agree that its good to avoid putting #includes in m_pd.h stdint.h is a stable and widespread as stddef.h, which has been part of m_pd.h for a long time. I put '#include <stdint.h>" because that's the only header that was already included everywhere that needs types defined in stdint.h. Another option would be to put the int32_t, etc. definitions in s_stuff.h or some other header, and then add that header everywhere its needed. As for the patches not applying, that's because you accepted 3 patches from Marvin Humpreys that removes lots of code from s_utf8.* and that conflicts with these patches. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2012-12-15 18:39 Message: For some reason I can't apply the first patch (I get: error: patch failed: src/s_utf8.c:26 error: src/s_utf8.c: patch does not apply error: patch failed: src/s_utf8.h:1 error: src/s_utf8.h: patch does not apply --- even though my eyeballs can't see any reason that would fail. Anyway, I'd like not to have m_pd.h be in the business of pulling in other include files (except as needed to define its own data structures) as I think that's a threat to future portability - can this be fixed to leave m_pd.h, d_soundfile.h, etc., alone and just "do the necessary" to the UTF-8 code? thanks Miller ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-11 21:44 Message: These are all the externals in Pd-extended that need changes to support Unicode filenames: http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio… http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio… http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio… Basically, you just need to change open() to sys_open() and fopen() to sys_fopen(). You can remove sys_bashfilename() since its included in those new open functions when needed. ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-11 21:25 Message: and a couple more for good measure ;) ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-11 19:37 Message: I added a fifth patch. Microsoft says that the POSIX close() was deprecated in 2005, and to use their ISO C++ _close() instead. http://msdn.microsoft.com/en-US/library/ms235443(v=vs.80).aspx http://msdn.microsoft.com/en-US/library/5fzwd5ss(v=vs.80).aspx ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_…

1 0

[ pure-data-Patches-3594735 ] Win32: unicode support for files with public API for externs
by SourceForge.net 16 Dec '12

16 Dec '12

Patches item #3594735, was opened at 2012-12-10 19:14 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix Status: Open Resolution: None Priority: 7 Private: No Submitted By: Hans-Christoph Steiner (eighthave) Assigned to: Miller Puckette (millerpuckette) Summary: Win32: unicode support for files with public API for externs Initial Comment: Right now, Pd on Windows does really badly if there are any non-ASCII characters in the path or filename. It makes it freeze for a while, and sometimes crashes it. These patches fix that. Pd and Tcl/Tk is UTF-8 internally, and UNIXes all use UTF-8 for filenames and paths. Windows uses UCS-2 everywhere, which is a 16-bit format. The only place this affects Pd is reading and writing filenames, and printing to the console. The POSIX-style functions open() and fopen() exist on Windows, but only work for ASCII filenames. To support Unicode filenames, we have to convert the UTF-8 to UCS-2, then use Win32-specific functions. Since any external that opens files will also be affected the same way, this patch provides a public API: sys_open()/sys_close(), and sys_fopen()/sys_fclose(). For non-Win32 platforms, they are just names that point to the normal POSIX versions. On Win32, they are special functions to handle UTF-8 to UCS-2 conversion. I have built and run this on Windows XP, Mac OS X 10.6, and Debian/squeeze amd64. These patches are also included in Pd-extended 0.43.4. ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-16 12:28 Message: I agree that its good to avoid putting #includes in m_pd.h stdint.h is a stable and widespread as stddef.h, which has been part of m_pd.h for a long time. I put '#include <stdint.h>" because that's the only header that was already included everywhere that needs types defined in stdint.h. Another option would be to put the int32_t, etc. definitions in s_stuff.h or some other header, and then add that header everywhere its needed. As for the patches not applying, that's because you accepted 3 patches from Marvin Humpreys that removes lots of code from s_utf8.* and that conflicts with these patches. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2012-12-15 18:39 Message: For some reason I can't apply the first patch (I get: error: patch failed: src/s_utf8.c:26 error: src/s_utf8.c: patch does not apply error: patch failed: src/s_utf8.h:1 error: src/s_utf8.h: patch does not apply --- even though my eyeballs can't see any reason that would fail. Anyway, I'd like not to have m_pd.h be in the business of pulling in other include files (except as needed to define its own data structures) as I think that's a threat to future portability - can this be fixed to leave m_pd.h, d_soundfile.h, etc., alone and just "do the necessary" to the UTF-8 code? thanks Miller ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-11 21:44 Message: These are all the externals in Pd-extended that need changes to support Unicode filenames: http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio… http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio… http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio… Basically, you just need to change open() to sys_open() and fopen() to sys_fopen(). You can remove sys_bashfilename() since its included in those new open functions when needed. ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-11 21:25 Message: and a couple more for good measure ;) ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-11 19:37 Message: I added a fifth patch. Microsoft says that the POSIX close() was deprecated in 2005, and to use their ISO C++ _close() instead. http://msdn.microsoft.com/en-US/library/ms235443(v=vs.80).aspx http://msdn.microsoft.com/en-US/library/5fzwd5ss(v=vs.80).aspx ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_…

1 0

Re: [PD-dev] [ pure-data-Patches-3584286 ] Win32: fix mouse wheel scrolling by setting the scroll incr
by IOhannes m zmölnig 16 Dec '12

16 Dec '12

On 12/16/2012 21:01, SourceForge.net wrote: > I've been marking bug reports as "fixed" when I add a patch that fixes the > bug. i would expect that any "patch" that addresses a given bug will "fix" it, so marking the reports as "fixed" seems to be somewhat unnecessary. i guess the original idea of "fixed" is something along the lines of "this is already fixed in current beta" (as opposed to "out-of-date" which would mean "this has been fixed 3 release cycles ago). > We've been using "Accepted" as the status for when a page as been. so "resolution" would become a state machine, where a ticket could undergo several states until it finally is accepted to a Pd-vanilla release? i believe that this is probably too complicated for practical uses. fgmsdr IOhannes

1 0

[ pure-data-Patches-3432654 ] pkg-config improvement
by SourceForge.net 16 Dec '12

16 Dec '12

Patches item #3432654, was opened at 2011-11-03 02:53 Message generated for change (Settings changed) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3432654&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata-dev Group: bugfix Status: Open >Resolution: None Priority: 5 Private: No Submitted By: IOhannes m zmölnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) Summary: pkg-config improvement Initial Comment: with the new autotools-based build system, Pd also generates a pkg-config [1] file (it's pd.pc, generated from pd.pc.in). the purpose of this file is to sease compilation of externals in a standardized way, by providing information on where to find header files (e.g. /usr/include/pd) and which libraries we need to link too (e.g. link against pd.lib" on w32, but not on other platforms) unfortunately i was a bit too eager, when i first created this file, adding lots of flags and bells and whistles, which have turned out to be more confusing than helping. attached patch therefore simplifies the generated pd.pc to only hold the relevant information (see in-patch description for more details) [1] ---------------------------------------------------------------------- Comment By: IOhannes m zmölnig (zmoelnig) Date: 2012-12-16 12:02 Message: i updated the patch to apply against today's git/master (rev.3b876c63b) ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2012-12-15 13:30 Message: Not sure what to do with this - it looks like it might still be useful but it doesn't apply cleanly and I don't know y way around configure.ac to fix it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3432654&group_…

1 0

[ pure-data-Patches-3432654 ] pkg-config improvement
by SourceForge.net 16 Dec '12

16 Dec '12

Patches item #3432654, was opened at 2011-11-03 02:53 Message generated for change (Comment added) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3432654&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata-dev Group: bugfix >Status: Open Resolution: Out of Date Priority: 5 Private: No Submitted By: IOhannes m zmölnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) Summary: pkg-config improvement Initial Comment: with the new autotools-based build system, Pd also generates a pkg-config [1] file (it's pd.pc, generated from pd.pc.in). the purpose of this file is to sease compilation of externals in a standardized way, by providing information on where to find header files (e.g. /usr/include/pd) and which libraries we need to link too (e.g. link against pd.lib" on w32, but not on other platforms) unfortunately i was a bit too eager, when i first created this file, adding lots of flags and bells and whistles, which have turned out to be more confusing than helping. attached patch therefore simplifies the generated pd.pc to only hold the relevant information (see in-patch description for more details) [1] ---------------------------------------------------------------------- >Comment By: IOhannes m zmölnig (zmoelnig) Date: 2012-12-16 12:02 Message: i updated the patch to apply against today's git/master (rev.3b876c63b) ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2012-12-15 13:30 Message: Not sure what to do with this - it looks like it might still be useful but it doesn't apply cleanly and I don't know y way around configure.ac to fix it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3432654&group_…

1 0

[ pure-data-Patches-3584286 ] Win32: fix mouse wheel scrolling by setting the scroll incr
by SourceForge.net 16 Dec '12

16 Dec '12

Patches item #3584286, was opened at 2012-11-05 10:14 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3584286&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Miller Puckette (millerpuckette) Summary: Win32: fix mouse wheel scrolling by setting the scroll incr Initial Comment: Instead of scrolling step by step it goes directly to the end of the canvas (using the mousewheel). That is true for vanilla and ext releases of pd0.43 (windows). Worked in pd0.42.5 Bye ---------------------------------------------------------------------- >Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-16 12:01 Message: I've been marking bug reports as "fixed" when I add a patch that fixes the bug. We've been using "Accepted" as the status for when a page as been accepted. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2012-12-15 14:16 Message: I applpied this even though it said 'fixed' - hope this is OK. Leaving open for now just in case. ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-14 20:27 Message: Win32: fix mouse wheel scrolling by setting the scroll increment. For some crazy reason, win32 mousewheel scrolling is in units of 120, and this forces Tk to interpret 120 to mean 1 scroll unit. http://pure-data.git.sourceforge.net/git/gitweb.cgi?p=pure-data/pd-extended… ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3584286&group_…

1 0

[ pure-data-Patches-3424988 ] add proper quoting of filenames to GUI prefs
by SourceForge.net 16 Dec '12

16 Dec '12

Patches item #3424988, was opened at 2011-10-17 13:35 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3424988&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix Status: Open Resolution: None Priority: 7 Private: No Submitted By: Hans-Christoph Steiner (eighthave) Assigned to: Miller Puckette (millerpuckette) Summary: add proper quoting of filenames to GUI prefs Initial Comment: On Mac OS X, then GUI prefs system was not handling quoting of filenames at all. The first patch adds proper quoting, then the second patch brings pd_guiprefs.tcl inline with the coding style of the rest of the Pd GUI code (using namespaces, the 'else' keyword, etc). ---------------------------------------------------------------------- >Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-16 11:57 Message: sometimes 'git am' can be fussy. You can do this when it fails on stupid things git am changes.patch patch -p1 < changes.patch git am --resolved That will keep the description, etc. in the commit. Or you can commit it by hand. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2012-12-15 13:20 Message: The first two appear to have been appplied already, but not the last one (and it doens't apply cleanly) - should I just aply 0003 by hand? Not sure it's still relevant but if so I'll put it in. ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-12-14 17:22 Message: one more bugfix patch to include support for unicode chars and better quoting ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2011-11-04 21:45 Message: updated with a quoting bug fix ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3424988&group_…

1 0

[ pure-data-Patches-3587384 ] Replacing deprecated functions
by SourceForge.net 16 Dec '12

16 Dec '12

Patches item #3587384, was opened at 2012-11-14 21:06 Message generated for change (Settings changed) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3587384&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix >Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Miller Puckette (millerpuckette) Summary: Replacing deprecated functions Initial Comment: vexp_fun.c currently uses the old BSD-style functions drem and finite. These functions have been removed from XCode 4.4 and later, so that the expr~ family of externals fails to compile now. This patch replaces drem with remainder and finite with isfinite, which should work everywhere. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2012-12-03 20:32 Message: accepted for 0.44 ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2012-11-20 12:34 Message: Makes sense to me. remainder() is the C99 replacement for drem(), and isfinite() is the C99 replacement for finite(). C99 marks drem() and finite() as deprecated. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3587384&group_…

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
18
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pd-dev December 2012