Patches item #3411732, was opened at 2011-09-20 00:39
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3411732&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Pending
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Thomas Klausner (thomasklausner)
Assigned to: Nobody/Anonymous (nobody)
Summary: Patches for supporting NetBSD
Initial Comment:
The attached patches (against 0.43-0) fix various issues when building on NetBSD.
They are described in detail in the patches, here's a short list:
Add missing include (for SIGPIPE).
Define extensions for NetBSD.
Detect endianness on NetBSD.
Use proper soundcard.h include on NetBSD and add missing argument
to ioctl().
File handling under NetBSD is the same as under Linux.
Use OSS on NetBSD.
Define missing symbol the same as on FreeBSD/Mac OS X.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3411732&group_…
Patches item #3411730, was opened at 2011-09-20 00:35
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3411730&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Pending
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Thomas Klausner (thomasklausner)
Assigned to: Nobody/Anonymous (nobody)
Summary: alloca.h not portable
Initial Comment:
The alloca.h header file is not portable, it doesn't exist e.g. on many BSDs or AIX.
I've changed the configure script to check for its existence and the users to check for the symbol before including alloca.h, or including malloc.h instead.
If Windows doesn't use the configure script, an "|| or defined(WIN32)" needs to be added at the end of the "defined(MALLOC_H)" lines.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3411730&group_…
Patches item #3464413, was opened at 2011-12-23 06:20
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3464413&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Pending
Resolution: Fixed
Priority: 7
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Miller Puckette (millerpuckette)
Summary: Most Recently Used files list stay empty, and related issues
Initial Comment:
0.43.1-extended-20111221 - the MRU list is always empty when I open the software: then I open several file and the MRU list fills up. Then I close pd- extended, and when il open it again the MRU files is empty once again.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-01-15 19:32
Message:
I found the bug, and attached the patch that fixes it. It is included in
Pd-extended. Miller, this is a simple bug fix that should be included in
any future 0.43 releases. It also requires that two other simple patches
are applied first, which also are simple fixes to bugs in the GUI. Apply
them in order, i.e. 0001, 0002, then 0003. These are all included in
Pd-extended
----------------------------------------------------------------------
Comment By: https://www.google.com/accounts ()
Date: 2011-12-23 06:21
Message:
ubuntu 11.10, oneiric ocelot
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3464413&group_…
Patches item #3411735, was opened at 2011-09-20 00:42
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3411735&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Thomas Klausner (thomasklausner)
Assigned to: Nobody/Anonymous (nobody)
Summary: pd-0.43: Unportable test(1) construct in src/configure
Initial Comment:
pd-0.43-0 is using an unportable bash extension "==" for test(1) in t/test-lib.sh. This is not supported by most
other shells or even test(1) from GNU coreutils. Please use "=" instead. A patch is attached.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-15 10:40
Message:
obsolete - build system completely replaced.
----------------------------------------------------------------------
Comment By: Thomas Klausner (thomasklausner)
Date: 2011-09-20 08:42
Message:
You are right, the new one is unaffected.
On the other hand, it's a simple fix :)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-09-20 08:39
Message:
There is currently two parallel build systems, old and new. We are moving
to the new build system that is in the root, i.e. pd/configure.ac, the old
one is pd/src/configure.in. I think the new build system is unaffected.
Have you tried that?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3411735&group_…
Patches item #3420438, was opened at 2011-10-07 13:57
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3420438&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Pending
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Miller Puckette (millerpuckette)
Summary: Ctrl-Enter doesn't accept the entered text (in 0.42 works)
Initial Comment:
Create an object, start writting and press Ctrl-Enter:
0.42: It accepts the entered text and it is ready to move with arrow keys.
0.43: Ctrl-Enter works like Enter.
The same if I click in any object. I would have to mark a rectangle to select only a box to start moving with keys. It was faster to click, Ctrl-Enter, move.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-10-07 14:23
Message:
Oops, yes, that was an oversight in the GUI rewrite. I attached a patch to
fix it, as well as GUI plugin to fix it now.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3420438&group_…
Patches item #3577728, was opened at 2012-10-16 14:22
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3577728&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pd-extended
Group: None
>Status: Pending
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Miller Puckette (millerpuckette)
Summary: menu edit - undo & redo command error
Initial Comment:
Pd-extended 0.43.1, Windows 7 64, Intel Core i7
Undo and redo command from edit menu show this error message:
wrong # args: should be "menu_undo"
wrong # args: should be "menu_undo"
while executing
"menu_undo $::focused_window"
(menu invoke)
wrong # args: should be "menu_redo"
wrong # args: should be "menu_redo"
while executing
"menu_redo $::focused_window"
(menu invoke)
CTRL+Z and SHIFT+CTRL+Z works well
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3577728&group_…
Patches item #3581737, was opened at 2012-10-29 16:36
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3581737&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Pending
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Federico Schwindt (fgsch)
Assigned to: Nobody/Anonymous (nobody)
Summary: OpenBSD support
Initial Comment:
FIrst round of patches to add support for OpenBSD.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-11-26 11:44
Message:
OK, added the ifdefs, tested on linux (makefile.gnu) and MSVC
(makefile.msvc) , and pushed to git - please report
back if there are problems on other platforms.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-11-20 12:00
Message:
that looks good to me, Miller, but I don't know the BSD stuff.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-11-20 09:08
Message:
I think HAVE_ALLOCA_H is traditionally used to indicate the existence of a
file, "alloca.h" which apparently
doesn't exist in MSVC. I'm no longer worried about how we can get teh
makefiles set up but rather what should go
in the C code... at teh moment I believe it
#ifdef HAVE_ALLOCA_H
# include <alloca.h> /* linux, mac, mingw, cygwin */
#elif defined _MSC_VER
# include <malloc.h> /* MSVC */
#else
# include <stddef.h> /* BSDs for example */
#endif
... and that I can put that in, clean out the "old" autoconf stuff and
voila. Do we all think that that work OK?
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-11-20 08:51
Message:
or don't use config.h at all, add /D=HAVE_ALLOCA_H to makefile.nt (for
those compiling on w32 using msvc) and use AC_CONFIG_HEADERS(alloca.h) for
the systems that use autoconf.
i doubt whether anybody involved in writing configure.ac has done the
testing on all platforms known to compile Pd before submitting changes.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-11-19 19:46
Message:
if you really think its worth your time, then go ahead and prepare a patch
that you've tested on OpenBSD, GNU/Linux, Windows, Mac OS X, iOS, Android,
Rockbox, and Microsoft Visual Studio. IMHO, things are working well as
they are.
----------------------------------------------------------------------
Comment By: Federico Schwindt (fgsch)
Date: 2012-11-19 15:01
Message:
Not necessarily. You can supply pre-generated config.h for some platforms
(that are obviously not going to change) and generate one for the rest.
So basically if you're using autoconf you could use AC_CONFIG_HEADERS, if
not just supply a config.h with all the defines for that platform.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-11-19 11:02
Message:
AC_CONFIG_HEADERS works fine if your code is only built by the single
autotools build system. In Pd's case, there are multiple build systems
because of all of the platforms it runs on. There is configure.ac for UNIX
and MinGW, src/makefile.nt for Microsoft Visual Studio, libpd for Android,
iOS and more. Pd is also included in Rockbox.
So using some auto-tools things makes it harder on the other platforms.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-11-19 08:03
Message:
I'm preparing to throw out the old "configure" stuff (which, by the way, I
didn't originate
and which I've tried and failed to understand; for some reason I never got
AC_CONFIG_HEADERS()
to work). But I'd still like to know what a good way to declare alloca(0
in a C file is. The autoconf
web site suggests that I cut and past a 16-line #ifdef mess into every c
file using alloca() .. perhaps under
the "new" (autogen) system something shorter would work, but I'd want to
have some confidence I'm
doing something reasonable.
----------------------------------------------------------------------
Comment By: Federico Schwindt (fgsch)
Date: 2012-11-17 19:37
Message:
unfortunately you're wrong. alloca is not posix so i wouldn't expect any
agreement here.
as i said openbsd doesn't have alloca.h. i would not be surprised if other
bsd are the same. malloc.h is also incorrect. here alloca's prototype is in
stdlib.h.
i will prepare a diff to add the maze of defines in all the configures and
what not but I really fail to see why you can simply use
AC_CONFIG_HEADERS() since you're already depending on configure.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-11-17 15:03
Message:
I went ahead and applied the patch by hand. I could be wrong, but isn't
there now an alloca()
function and an alloca.h on all unix-likes? and an alloca() defined in
Windows? If so we can blow
off all the configuration stuff and just conditionall include alloca or
malloc.h depending on whether
we're Windows.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-11-13 15:45
Message:
no not really. afaiu the plan is to add a check for "alloca.h" to
configure, which willl define HAVE_ALLOCA_H if the file is found. if
HAVE_ALLOCA_H is defined alloca.h will get included.
now the current behaviour is to include alloca.h in any case.
but if the include is protected, then the build-system has to actively
define HAVE_ALLOCA_H in order keep the old behaviour.
simply ignoring the other build-systems might break them.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-11-13 11:45
Message:
I think you'll be safe only touching the ./configure.ac and Makefile.ams.
Miller seems to want to hold only to the old, crufty src/configure.in
build, but he doesn't use OpenBSD.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-11-06 05:13
Message:
#1 yes, the build-system is messed up (or rather, it is in a state of
transition)
#2 .../src/configure adds HAVE_foo to CPPFLAGS (and .../configure adds it
to DEFS), which get expanded in the resp. makefiles (so technically you are
right, they don't get added to CFLAGS)
#3 i said "makefile.nt" and not "makefile.in", which is the 3rd(!)
build-system that is there and which is used to build on w32 using MSVC.
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2012-11-06 04:45
Message:
I might be missing something but unless you add it manually I don't see
where configures adds the HAVE_XXX to CFLAGS unless you do it manually.
And src/makefile.in is processed by src/configure(.in) so only
../configure.ac and ../src/configure.in need to be modified.
<rant>
You have a pretty messed up build system.
</rant>
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-11-06 03:57
Message:
if the patch comes from git, then please create a branch, commit to that
and then create a patch-set using "git format-patch master".
as for the HAVE_ALLOCA_H: if you don't instruct configure to write defines
into config.h, it will add them to the CFLAGS, so that the compilation will
still work. thus, no need to change the build-system.
bear in mind though, that currently Pd uses to separate build-systems:
.../configure.ac and .../src/configure.in (and .../src/makefile.nt); you
might need to modify all 3 in order to get accepted (yes, it's a PITA)
----------------------------------------------------------------------
Comment By: Federico Schwindt (fgsch)
Date: 2012-11-06 02:48
Message:
@zmoelnig:
The patch comes from git. My main concern is how to proceed with the other
changes that require more changes than just extending an existing ifdef.
For example the exclusion of alloca.h, etc.
In my git clone I've modified configure to use config headers and so I can
do ifdef HAVE_ALLOCA_H, etc. but I'm not sure if such patches will be
accepted.
The reason I've break them down is so they can be committed while I
understand what your preference is.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-11-06 02:39
Message:
this patch is simple enough (almost trivial) as it only adds "#ifdef
__OpenBSD__" to the clauses that are already handled by "__FreeBSD__".
i don't see a reason to not include it (but of course this all depends on
miller).
small note on patches:
- the patch doesn't apply here (`patch` thinks the diff is garbage)
- Pd is developped in git; it would be great if you could generate your
patches using git as well; see [1]
- as for atomicity of patches: personally i think creating a (few) smaller
patches is not a real problem; make sure that those patches are logical
units rather than reflecting your iterative trial-and-error history to fix
a problem. then attach all patch files to this ticket (rather than creating
a new patchtracker-ticket for each file)
[1] http://puredata.info/docs/developer/GitWorkflows/
----------------------------------------------------------------------
Comment By: Federico Schwindt (fgsch)
Date: 2012-11-06 02:03
Message:
Comments please? I'd really to move forward with this.
Thanks.
----------------------------------------------------------------------
Comment By: Federico Schwindt (fgsch)
Date: 2012-10-29 19:01
Message:
That'd be ideal but since I'm not sure about the other changes (using
config headers, etc.) I'm submitting what I know for certain that won't
change depending on the approach.
For example what should I do if alloca.h doesn't exist? In my git repo I
have #ifdef HAVE_ALLOCA_H where the define is driven from autotools header
check but I'm still unclear whether you want to use the headers or not (and
the reason you might not want to do it since you're already using
autotools).
Happy to submit everything in one go if you can suggest what the best
course of action is.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-10-29 18:57
Message:
The best thing to do would be to make a single patch that includes
everything needed for OpenBSD support.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3581737&group_…
Patches item #3587384, was opened at 2012-11-14 21:06
Message generated for change (Comment added) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3587384&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Pending
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Miller Puckette (millerpuckette)
Summary: Replacing deprecated functions
Initial Comment:
vexp_fun.c currently uses the old BSD-style functions drem and finite. These functions have been removed from XCode 4.4 and later, so that the expr~ family of externals fails to compile now. This patch replaces drem with remainder and finite with isfinite, which should work everywhere.
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2012-12-15 08:53
Message:
your title got my hopes on with instant goldBy Coolmatt701 electronic
2009-09-01
[url=http://diablo3goldok.smartlog.dk/]Arianne Parmentier's inexpensive
market[/url]
<a href="http://diablo3goldok.smartlog.dk/" title="Arianne Parmentier's
inexpensive market">Arianne Parmentier's inexpensive market</a>
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-03 20:32
Message:
accepted for 0.44
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-11-20 12:34
Message:
Makes sense to me. remainder() is the C99 replacement for drem(), and
isfinite() is the C99 replacement for finite(). C99 marks drem() and
finite() as deprecated.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3587384&group_…
Patches item #3584286, was opened at 2012-11-05 10:14
Message generated for change (Settings changed) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3584286&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
>Group: None
Status: Open
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Miller Puckette (millerpuckette)
>Summary: Win32: fix mouse wheel scrolling by setting the scroll incr
Initial Comment:
Instead of scrolling step by step it goes directly to the end of the canvas (using the mousewheel).
That is true for vanilla and ext releases of pd0.43 (windows). Worked in pd0.42.5
Bye
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-14 20:27
Message:
Win32: fix mouse wheel scrolling by setting the scroll increment. For some
crazy reason, win32 mousewheel scrolling is in units of 120, and this
forces Tk to interpret 120 to mean 1 scroll unit.
http://pure-data.git.sourceforge.net/git/gitweb.cgi?p=pure-data/pd-extended…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3584286&group_…
Patches item #3589133, was opened at 2012-11-22 04:18
Message generated for change (Settings changed) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3589133&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Jamie Bullock (postlude)
Assigned to: Miller Puckette (millerpuckette)
Summary: Patcher windows always open on "primary" monitor
Initial Comment:
Pd version tested with: 0.43.3 Vanilla
Steps to reproduce:
- connect a second monitor
- open Pd
- create a new patch and move it to the second monitor
- create a subpatch
Expected behaviour:
- the subpatch window opens on the same monitor as the parent patch
Actual behaviour:
- the subpatch window opens on the primary monitor
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-14 18:36
Message:
The code was just always placing the new subpatch windows in the top left
corner of the main screen. I did two things in Pd-extended:
1. made the window placement logic aware of the full desktop size, not just
the main screen
http://pure-data.git.sourceforge.net/git/gitweb.cgi?p=pure-data/pd-extended…
2. made the window of new subpatches open near where the object was
placed.
http://pure-data.git.sourceforge.net/git/gitweb.cgi?p=pure-data/pd-extended…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3589133&group_…