Patches item #3594735, was opened at 2012-12-10 19:14
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: Win32: unicode support for files with public API for externs
Initial Comment:
Right now, Pd on Windows does really badly if there are any non-ASCII characters in the path or filename. It makes it freeze for a while, and sometimes crashes it. These patches fix that.
Pd and Tcl/Tk is UTF-8 internally, and UNIXes all use UTF-8 for filenames
and paths. Windows uses UCS-2 everywhere, which is a 16-bit format. The
only place this affects Pd is reading and writing filenames, and printing
to the console. The POSIX-style functions open() and fopen() exist on
Windows, but only work for ASCII filenames. To support Unicode filenames,
we have to convert the UTF-8 to UCS-2, then use Win32-specific functions.
Since any external that opens files will also be affected the same
way, this patch provides a public API: sys_open()/sys_close(), and
sys_fopen()/sys_fclose(). For non-Win32 platforms, they are just
names that point to the normal POSIX versions. On Win32, they are
special functions to handle UTF-8 to UCS-2 conversion.
I have built and run this on Windows XP, Mac OS X 10.6, and Debian/squeeze amd64. These patches are also included in Pd-extended 0.43.4.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-15 18:39
Message:
For some reason I can't apply the first patch (I get:
error: patch failed: src/s_utf8.c:26
error: src/s_utf8.c: patch does not apply
error: patch failed: src/s_utf8.h:1
error: src/s_utf8.h: patch does not apply
--- even though my eyeballs can't see any reason that would fail.
Anyway, I'd like not to have m_pd.h be in the business of pulling in other
include files
(except as needed to define its own data structures) as I think that's a
threat to future
portability - can this be fixed to leave m_pd.h, d_soundfile.h, etc., alone
and just "do the
necessary" to the UTF-8 code?
thanks
Miller
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 21:44
Message:
These are all the externals in Pd-extended that need changes to support
Unicode filenames:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…
Basically, you just need to change open() to sys_open() and fopen() to
sys_fopen(). You can remove sys_bashfilename() since its included in those
new open functions when needed.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 21:25
Message:
and a couple more for good measure ;)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 19:37
Message:
I added a fifth patch. Microsoft says that the POSIX close() was deprecated
in 2005, and to use
their ISO C++ _close() instead.
http://msdn.microsoft.com/en-US/library/ms235443(v=vs.80).aspxhttp://msdn.microsoft.com/en-US/library/5fzwd5ss(v=vs.80).aspx
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_…
Patches item #3413809, was opened at 2011-09-25 11:06
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3413809&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: use Ctrl-< and Ctrl-> to cycle thru open windows
Initial Comment:
This patch allows you to use Ctrl/Cmd < and > to cycle through all of the open windows in different directions.
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-15 17:36
Message:
yes, that's what is intended. I think each WM will have different ideas of
how this should work, like for people who have focus changing based on
mouse presence not clicking. But I think this is the most common paradigm.
Others can be implemented in plugins
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-15 11:02
Message:
I tried this and got funny behavior - ctrl < focussed the previous window
OK, but also sent it to the back of
the window stacking order.. Can this be what was intended???
----------------------------------------------------------------------
Comment By: max (maxn)
Date: 2011-09-26 05:01
Message:
That's the standard on german keyboard layouts for cycling through the
windows of the active application on OS X. I'd very much apprechiate if
this would work in Pd. That said, i think it might actually be a bug in
Tcl/Tk that it isn't working right now.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3413809&group_…
Patches item #3591986, was opened at 2012-12-02 20:15
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3591986&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Pending
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: for set/label, only draw updates when the value changes
Initial Comment:
Lots of patches just hook up fast streams of events directly to GUI
objects. If these streams of events include multiples of the same value,
the GUI object draws each one. The first patch makes it so it only draws if the
value has changed. The second patch does the same for the labels.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-15 15:09
Message:
applied for 0.44.
Really the test should be more stringent but this is better than nothing
and I'm not likely to get around to improving it.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3591986&group_…
Patches item #3589133, was opened at 2012-11-22 04:18
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3589133&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Pending
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Jamie Bullock (postlude)
Assigned to: Miller Puckette (millerpuckette)
Summary: Patcher windows always open on "primary" monitor
Initial Comment:
Pd version tested with: 0.43.3 Vanilla
Steps to reproduce:
- connect a second monitor
- open Pd
- create a new patch and move it to the second monitor
- create a subpatch
Expected behaviour:
- the subpatch window opens on the same monitor as the parent patch
Actual behaviour:
- the subpatch window opens on the primary monitor
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-15 15:04
Message:
I didn't see the need to place the wondw over the object (patch number 2)
but applied the
first one to vanilla. Will mark this 'pending' pending...
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-14 18:36
Message:
The code was just always placing the new subpatch windows in the top left
corner of the main screen. I did two things in Pd-extended:
1. made the window placement logic aware of the full desktop size, not just
the main screen
http://pure-data.git.sourceforge.net/git/gitweb.cgi?p=pure-data/pd-extended…
2. made the window of new subpatches open near where the object was
placed.
http://pure-data.git.sourceforge.net/git/gitweb.cgi?p=pure-data/pd-extended…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3589133&group_…
Patches item #3587384, was opened at 2012-11-14 21:06
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3587384&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Pending
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Miller Puckette (millerpuckette)
Summary: Replacing deprecated functions
Initial Comment:
vexp_fun.c currently uses the old BSD-style functions drem and finite. These functions have been removed from XCode 4.4 and later, so that the expr~ family of externals fails to compile now. This patch replaces drem with remainder and finite with isfinite, which should work everywhere.
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2012-12-15 08:53
Message:
your title got my hopes on with instant goldBy Coolmatt701 electronic
2009-09-01
[url=http://diablo3goldok.smartlog.dk/]Arianne Parmentier's inexpensive
market[/url]
<a href="http://diablo3goldok.smartlog.dk/" title="Arianne Parmentier's
inexpensive market">Arianne Parmentier's inexpensive market</a>
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-03 20:32
Message:
accepted for 0.44
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-11-20 12:34
Message:
Makes sense to me. remainder() is the C99 replacement for drem(), and
isfinite() is the C99 replacement for finite(). C99 marks drem() and
finite() as deprecated.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3587384&group_…
Patches item #3585461, was opened at 2012-11-08 13:09
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3585461&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Pending
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: [readsf~] loops some files
Initial Comment:
some wav-files get looped when played back via [readsf~].
it seems that the problem is dues to the soundfile fitting exactly into the fifobuffer, thus the EOF (signalled by the read-thread) drain never really starts in the perform routine.
(fifohead==fifosize, so the test for (!x_eof && x_fifohead >= x_fifotail && x_fifohead < x_fifotail + wantbytes-1) never triggers, resulting in a continuous drain of the entire buffer.
the attached soundfile triggers this behaviour.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-15 14:38
Message:
applied for 0.44
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-11-08 13:11
Message:
attached is a simplistic attempt to fix the problem: if the
fifohead==fifosize, we wrap it to 0 even if we just read the last byte.
(originally this was only done if !EOF)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3585461&group_…
Patches item #3575521, was opened at 2012-10-08 09:40
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3575521&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Pending
>Resolution: Accepted
Priority: 7
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: remove pdtk_array.tcl, its dead unused code
Initial Comment:
pdtk_array.tcl was never used in any production code, but it slipped into the pure-data.git. Everything in pdtk_array.tcl is unused, old duplicates of dialog_array.tcl. This patch removes pdtk_array.tcl.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-15 14:19
Message:
applied for 0.44
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3575521&group_…
Patches item #3584286, was opened at 2012-11-05 10:14
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3584286&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Miller Puckette (millerpuckette)
Summary: Win32: fix mouse wheel scrolling by setting the scroll incr
Initial Comment:
Instead of scrolling step by step it goes directly to the end of the canvas (using the mousewheel).
That is true for vanilla and ext releases of pd0.43 (windows). Worked in pd0.42.5
Bye
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-15 14:16
Message:
I applpied this even though it said 'fixed' - hope this is OK. Leaving
open for now just in case.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-14 20:27
Message:
Win32: fix mouse wheel scrolling by setting the scroll increment. For some
crazy reason, win32 mousewheel scrolling is in units of 120, and this
forces Tk to interpret 120 to mean 1 scroll unit.
http://pure-data.git.sourceforge.net/git/gitweb.cgi?p=pure-data/pd-extended…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3584286&group_…
Patches item #3584286, was opened at 2012-11-05 10:14
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3584286&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Pending
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Miller Puckette (millerpuckette)
Summary: Win32: fix mouse wheel scrolling by setting the scroll incr
Initial Comment:
Instead of scrolling step by step it goes directly to the end of the canvas (using the mousewheel).
That is true for vanilla and ext releases of pd0.43 (windows). Worked in pd0.42.5
Bye
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-15 14:16
Message:
I applpied this even though it said 'fixed' - hope this is OK. Leaving
open for now just in case.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-14 20:27
Message:
Win32: fix mouse wheel scrolling by setting the scroll increment. For some
crazy reason, win32 mousewheel scrolling is in units of 120, and this
forces Tk to interpret 120 to mean 1 scroll unit.
http://pure-data.git.sourceforge.net/git/gitweb.cgi?p=pure-data/pd-extended…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3584286&group_…
Patches item #3469773, was opened at 2012-01-05 03:05
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3469773&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
>Resolution: Out of Date
Priority: 1
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: update version in configure.ac
Initial Comment:
the (new) configure.ac has a notion of the current version, which is passed via the AC_INIT() command.
in Pd-0.43.1 this version is still set to 0.43.0, which looks a bit weird when compiling (as the wrong version shows up)
given that this version is not really used anywhere, the attached patch is purely cosmetic (and outdated whenever applied :-)
nevertheless it would be nice if the versions could be kept in sync.
it would be even nicer if somebody could provide a bit of code that fills the AC_INIT() version into m_pd.h
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3469773&group_…