Patches item #3279370, was opened at 2011-04-07 06:07
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3279370&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 3
Private: No
Submitted By: Peter Brinkmann (pbrinkmann)
Assigned to: Miller Puckette (millerpuckette)
Summary: Adding missing MIDI prototypes to s_stuff.h
Initial Comment:
A previous patch added MIDI prototypes to s_stuff.h in order to address some compiler warnings. Unfortunately, that patch missed three MIDI-related functions that should have been there all along. This patch corrects that oversight.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3279370&group_…
Patches item #3272554, was opened at 2011-04-03 14:03
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3272554&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 7
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fixed Mac OS X loading to work from cmd line and in src tree
Initial Comment:
This patch fixes Mac OS X loading to work both when pd includes an embedded Wish, i.e. in the standard Pd.app, or if pd is just compiled in place. There needed to be separate conditions for both, since in the embedded case, Wish finds pd-gui-tcl by its default loading of ../Resources/Scripts/AppMain.tcl. When launched without an embedded Wish, like when you just build the source and do ./pd, then the sys_guicmd needs to include the full path to pd-gui.tcl
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2011-09-16 18:06
Message:
not going to exhaustively test this one - taking it on faith :)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3272554&group_…
Patches item #3336039, was opened at 2011-06-26 20:11
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3336039&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
Resolution: Accepted
Priority: 9
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix Windows non-starting
Initial Comment:
Removed bizarre 'k' character in 'package' command, causing Windows to not start. This was in the proc get_config_win in tcl/pd_guiprefs.tcl. My smallest patch ever, literally changing one character ;)
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2011-07-30 12:41
Message:
applied
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-07-01 11:23
Message:
Martin Peach found another ḱ in pd_guiprefs.tcl, the updated patch fixes
it.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-07-01 11:21
Message:
This artifact has been marked as a duplicate of artifact 3307680 with
reason:
separate patch tracker item
----------------------------------------------------------------------
Comment By: Yvan Volochine (elgusanorojo)
Date: 2011-06-27 03:34
Message:
oops, my mistake (k with an accent), thanks for spotting.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3336039&group_…
Patches item #3361846, was opened at 2011-07-10 05:57
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3361846&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Anthony Lauzon (pfaffian)
Assigned to: Miller Puckette (millerpuckette)
Summary: bonk~ max/msp fixes
Initial Comment:
Patch consists of 3 changes:
1. Moving some PD specific code inside of #ifdef PD blocks so bonk~ compiles for Max/MSP
2. Bonk template reading/writing correctly works from Max/MSP.
3. "learn" was not using its argument, so every hit was being interpreted as a new template. changed that behaviour.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3361846&group_…
Patches item #3353285, was opened at 2011-07-03 22:24
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3353285&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix crasher bug when closing a window with Perf Mode on
Initial Comment:
fix crasher bug when closing a window with Perf Mode on and no changes to window. It was using the wrong variable, g, which is null. I changed it to x and no crash. Also, I adjusted the dialog to make sense.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3353285&group_…
Patches item #3303222, was opened at 2011-05-17 03:34
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3303222&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 6
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: make sure patches get written to disk
Initial Comment:
there is a very long standing (reported for pd-0.36cvs!) bug-report in debian (debian-bug#203288), claiming:
<snip>
pd: no error given when saving to a filesystem that is full
When trying to save to a filesystem that is full, a 0 byte file is
written and no error is given.
</snip>
with Pd-0.43, i get an error when saving too big patches on the filsystem in most cases (great), but some (e.g. creating a new empty patch, save that on the full fileystem) still reports everything as correct, even though only a 0 byte file gets written.
a simple solution (attached) is to call fflush() at the end of binbuf_write() and check it's return value for success.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3303222&group_…
Patches item #3307503, was opened at 2011-05-25 06:32
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3307503&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
Resolution: Accepted
Priority: 8
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: segfault in DSP-loop detection
Initial Comment:
given a patch that contains a DSP-loop _and_ an [inlet~] _and_ and [outlet~] (see attached patch).
if this file is opened as a toplevel patch (via File->Open) and you then turn on DSP, Pd will segfault.
if [outlet~] is missing, Pd will give an error about "DSP-loop detected" and refuses to calculate (which is ok and expected).
however, a segfault is not ok.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2011-07-30 12:50
Message:
applied
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2011-05-25 06:36
Message:
hunting down the bug i found that it crashes in the "fill borrowed outputs"
loop around d_ugen.c:1064.
the crash happens because dc_iosigs==NULL (due to the patch being run as
toplevel ) and dc_noutlets==dc_ninlets==1 (because there is inlet~ and
outlet~).
this combination leads to an access of (*dc_iosigs)->s_borrowedFrom which
is invalid (dc_iosigs==NULL)
the attached patch tries to fix the underlying problem, by forcing
dc_noutlets=dc_ninlets=0 if the toplevel flag is set.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3307503&group_…
Patches item #3438752, was opened at 2011-11-16 04:37
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3438752&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
Resolution: Accepted
Priority: 7
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: "pd -rt" crashes if pd-watchdog cannot be found
Initial Comment:
i'm using Pd-0.43 (today's git) on linux (debian wheezy/sid which comes with gcc-4.6.1)
if i start Pd in "realtime" mode (which is the default on linux) and it cannot find the "pd-watchdog" binary, Pd quits.
i stumbled upon this bug, since i had no link from Pd/src/ to Pd/bin/, and started Pd from it's source directory.
while i agree that my setup was somewhat broken as the pd-watchdog should have been in place, i strongly believe that Pd must not crash in these circumstances. it probably should drop realtime execution if it cannot find pd-watchdog, rather than crash.
zmoelnig@ferrari:~/src/git/pure-data$ ls bin/pd-watchdog
ls: cannot access bin/pd-watchdog: No such file or directory
zmoelnig@ferrari:~/src/git/pure-data$ ./src/pd
priority 6 scheduling enabled.
priority 8 scheduling enabled.
sh: ./bin/pd-watchdog: No such file or directory
pd: watchdog process died
zmoelnig@ferrari:~/src/git/pure-data$ pdsend errorname: >>error writing "sock8": broken pipe<<
zmoelnig@ferrari:~/src/git/pure-data$
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-06-30 14:17
Message:
There should be some way to get git to check for trailing whitespace which
I seem always
to get warned of when applying your patches...
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-03-07 05:11
Message:
i attached a small patch, that checks whether Pd can find a file named
"pd-watchdog", and if not, disabled real-time mode.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3438752&group_…
Patches item #3481846, was opened at 2012-01-30 17:41
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3481846&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 8
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: [bugfix] on start, the Pd window doesn't always show msgs
Initial Comment:
Sometimes, when Pd starts, it only writes a portion of the stored ::pdwindow::logbuffer to the Pd Window. This tiny patch fixes that by waiting for the event loop before printing the logbuffer to the Pd window.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-09-08 20:16
Message:
OK, I checked again and the patch made sense this time, but it's already in
the code, so closing this.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-02-19 17:57
Message:
Hmm, the attached file doesn't look loke a patch file (some HTM trash
instead)???
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3481846&group_…
Patches item #3497084, was opened at 2012-03-05 09:41
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3497084&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: None
>Status: Closed
Resolution: Accepted
Priority: 7
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix for open_via_path() declaration headfizz
Initial Comment:
m_pd.h says that the parameters for open_via_path() are: "open_via_path(name, ext, dir, ...)"
otoh, s_path.c implements the function as "open_via_path(dir, name, ext,...)"
also the function is used as (dir, name, ext,...) throughout the code.
the attached cosmetic patch fixes the function declaration in m_pd.h, so i don't get headfizz whenever i try to find out why i'm using the function correctly.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-08-31 17:12
Message:
done (by hand, not sure when)
----------------------------------------------------------------------
Comment By: Mathieu BOUCHARD (mathieubouchard)
Date: 2012-03-06 07:34
Message:
Just imagine that the ministry of transportation puts the wrong signs on
the autobahn. When it's time to fix them, they call the change
«cosmetic». So, of course, they ask a beautician to take care of it.
Do any changes to the docs also count as «cosmetic» ?
Because help-intro.pd always listed classes that never existed, such as
[powtorms~] and [rmstopow~]. I suppose that it's cosmetic too ?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3497084&group_…