Patches item #3528891, was opened at 2012-05-22 10:42
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3528891&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 3
Private: No
Submitted By: Glen F (totalgee)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fixing a few compiler warnings on OS X (LLVM)
Initial Comment:
A few very minor changes.
A couple of these fix pointer dereferencing which was subsequently not used (has no effect other than causing a warning with the LLVM compiler on OS X). The only important part is the advancing (++) of the pointers, which remains as it was. In the other case, an error() function with variable arguments was being printed using an uncontrolled format string (http://en.wikipedia.org/wiki/Uncontrolled_format_string). In the context of the actual code, I don't think it actually is a safety issue -- but it does get rid of another compiler warning/error with the latest LLVM compiler.
This is my first (admittedly very minor) patch submission, I hope it's okay. I had submitted a pull request on the libpd GitHub project, but they informed me it was better to apply it to the original Pd "vanilla" source, which they just bring over verbatim from time to time.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3528891&group_…
Patches item #3383991, was opened at 2011-08-01 16:27
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3383991&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Jonathan Wilkes (jancsika1)
Assigned to: Nobody/Anonymous (nobody)
Summary: fix buggy editmode menu option appearance
Initial Comment:
Removes the "-selectcolor grey85" option from the "Edit Mode" checkbutton in the "Edit" menu. This was causing buggy behavior where there appears to be no checkmark until the user mouses over the "Edit Mode" option and gets a grey checkmark that is very close to the selectcolor, making it appear disabled or something.
I also removed the green background color when editmode = 1. It's unnecessary and distracting. (Though if its still wanted, I'd suggest "#c4dcdc" which is the header color for PDDP help patches, as well as the tipwindow from my tooltips patch.)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-08-24 14:37
Message:
Miller accepted this change with commit
1dd08cf3c8b2ab6a75e9c21a17996ae49c2896fe
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3383991&group_…
Patches item #3528911, was opened at 2012-05-22 12:26
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3528911&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Jan Berkel (jberkel)
Assigned to: Nobody/Anonymous (nobody)
Summary: Better support for loading externals on Android
Initial Comment:
Native libs on Android have a few restrictions - they need to start with "lib", end in ".so" and may not contain tilde ('~'). At the moment apps using pd on Android work around this problem by renaming files, putting them into a zip archive and unzipping this archive when the app starts.
It would be nice to be able to load them directly from the app's lib directory. The attached patch changes the loader so that when resolving "z~" it will also look for "libz_tilde.so" in the current search path.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3528911&group_…
Patches item #3521816, was opened at 2012-04-26 19:25
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3521816&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Setting externals file extension, check for ANDROID platform
Initial Comment:
The Android GCC toolchain #defines linux, so the Android specific branch was never being hit. Moving the check above Linux fixes it.
Before this patch external extensions ".l_i386" and ".pd_linux" are checked for on Android. This patch will accept either ".l_arm" or ".pd_linux", so the externals built by PdCore will still work.
It doesn't address the issue of Android x86.
Should probably add a check for arm vs x86 architecture too, but I haven't been able to find documentation of the architecture macros.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-08-31 17:31
Message:
accepted (0.44)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-04-30 11:42
Message:
I attached a patch for my solution to the problem at hand: Android file
extensions. It will also fix file extensions for GNU/Linux on ARM. The
original code would make GNU/Linux/ARM use .l_i386.
This also adds '.so' as the default extension when the particular case is
undefined. I think this is better than having the default be nothing at
all, and it should be quite safe since .so is the standard extension for
shared libraries on GNU systems, BSD systems, Android, and others.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-04-30 07:36
Message:
How about we instead solve the problem listed above in this bug report? I
think we should have the add an #else that sets the file extension to
".so". The generic .dll extension has been used for Windows since forever
and I don't hear about problems there. And then ditch the __ANDROID__
section and move the ARM arch under the __linux__ section.
The file extensions are a mess in terms of accurate naming. __GNU__ and
__FreeBSD_kernel__ are not Linux at all, and they are set to use .pd_linux.
I don't think the kernel even matters for generic externals, it is
probably the libc that matters, so it should be something like .gnu_i386 or
.bsd_i386. Or maybe its the binary format that's more important, i.e.
.elf_i386 and .mach_i386. Makes me think this approach to naming is just
fundamentally flawed.
Lastly, IOhannes, the key part that you are missing about .d_fat/.d_ppc is
that they do not solve any problems. So something that causes a minor
problem, but solves nothing seems pretty worthless to me. Even discussing
it as much as we have seems like a waste of time.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-04-30 00:28
Message:
for the record, here are the relevant threads i found in the archives:
- http://lists.puredata.info/pipermail/pd-list/2009-01/067498.html
- http://lists.puredata.info/pipermail/pd-list/2009-07/071476.html
as you will see, the only real issue that was ever raised was the increased
load-time when adding more and more extensions. all the "other" issues
where always referred to as "there are other issues which i don't remember
right now, check the archive", without ever giving evidence that there are
indeed other issues.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-04-29 20:14
Message:
File extensions are very OS-specific. The Linux extensions are fine
(except perhaps the l_ia64 being the wrong arch). Mac OS X does not need
different ones since you can build universal "fat" binaries.
One example of a problem caused by adding more extensions is that it
increases the load time since Pd will have to check for more variations on
filenames. There are other issues, I don't remember them, but they're in
the archives.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-04-29 11:03
Message:
My intention in having the wierd extensions was to permit people to
distribute patches (such as realizations
of pieces) containing in-house externals that can run under any Pd version
and any OS. In this context
"externs" can be directories containing the various binaries which Pd
distinguishes by filename. OTOH, Pd
distributions themselves run on a single OS and architecture so don't need
the disambiguation, although in
my experience it hasn't been harmful (Hans has experienced otherwise in the
context of Pd extended though :)
So Pd is sort of stuck allowing both types of extensions.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-04-29 10:36
Message:
Personally, I think its a waste your time and mine. Its been discussed,
check out the archives for the problems it causes. I've long since moved
on. We should be putting this energy solving the issue in this tracker,
rather than beating the .d_ppc/.d_fat dead horse.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-04-28 10:16
Message:
thanks for the respone.
ad #1: very few people using .d_ppc/.d_fat is not really creating any
"problems", is it?
ad #2: will do (though afaict, PdX has a patch that actively removes the
functionality; should i create a patch that re-adds the extensions or
should i modify (eventually remove) the patch that erroneously removes the
extensions?
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-04-27 19:32
Message:
In response to #1: very few people are using .d_ppc and .d_fat files with
Pd vanilla.
and #2: patches welcome
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-04-27 08:54
Message:
<flames>
"Those file extension have a lot of issues as they are, for example, no
other program for Darwin/MacOSX uses per-arch file extension"...what
exactly is the "lot of issues" here? no other program for Darwin/MacOSX is
called "Pd", and still this is no issue.
</flames>
<moreflames>
if Pd-extended ignores binary files that it could happily load and by doing
so breaks compatibility with Pd-vanilla, i would say this is a bug in
Pd-extended.
</moreflames>
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-04-27 07:36
Message:
What about just defining '.so' has a possibility if __linux__, __FreeBSD__,
__FreeBSD_kernel__, __OpenBSD__ are defined, then people can choose to
manage the architecture in their own way.
Those file extension have a lot of issues as they are, for example, no
other program for Darwin/MacOSX uses per-arch file extensions: they use
universal binaries. For this reason , Pd-extended on Mac OS X only uses
.pd_darwin and universal binaries and ignores .d_fat and .d_ppc. Also,
Pd's .l_ia64 does not actually mean ia64 arch but instead amd64/x86_64, so
that file extension is just wrong.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3521816&group_…
Patches item #3284900, was opened at 2011-04-11 17:38
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3284900&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 7
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: make default font size the same on all platforms
Initial Comment:
There is some old code in s_main.c that sets the default font size differently for Windows. This patch removes that so that the default font size is 10 on all platforms. This now makes sense since the patches should look the same on all platforms.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3284900&group_…
Patches item #3279370, was opened at 2011-04-07 06:07
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3279370&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 3
Private: No
Submitted By: Peter Brinkmann (pbrinkmann)
Assigned to: Miller Puckette (millerpuckette)
Summary: Adding missing MIDI prototypes to s_stuff.h
Initial Comment:
A previous patch added MIDI prototypes to s_stuff.h in order to address some compiler warnings. Unfortunately, that patch missed three MIDI-related functions that should have been there all along. This patch corrects that oversight.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3279370&group_…
Patches item #3272554, was opened at 2011-04-03 14:03
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3272554&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 7
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fixed Mac OS X loading to work from cmd line and in src tree
Initial Comment:
This patch fixes Mac OS X loading to work both when pd includes an embedded Wish, i.e. in the standard Pd.app, or if pd is just compiled in place. There needed to be separate conditions for both, since in the embedded case, Wish finds pd-gui-tcl by its default loading of ../Resources/Scripts/AppMain.tcl. When launched without an embedded Wish, like when you just build the source and do ./pd, then the sys_guicmd needs to include the full path to pd-gui.tcl
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2011-09-16 18:06
Message:
not going to exhaustively test this one - taking it on faith :)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3272554&group_…
Patches item #3336039, was opened at 2011-06-26 20:11
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3336039&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
Resolution: Accepted
Priority: 9
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix Windows non-starting
Initial Comment:
Removed bizarre 'k' character in 'package' command, causing Windows to not start. This was in the proc get_config_win in tcl/pd_guiprefs.tcl. My smallest patch ever, literally changing one character ;)
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2011-07-30 12:41
Message:
applied
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-07-01 11:23
Message:
Martin Peach found another ḱ in pd_guiprefs.tcl, the updated patch fixes
it.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-07-01 11:21
Message:
This artifact has been marked as a duplicate of artifact 3307680 with
reason:
separate patch tracker item
----------------------------------------------------------------------
Comment By: Yvan Volochine (elgusanorojo)
Date: 2011-06-27 03:34
Message:
oops, my mistake (k with an accent), thanks for spotting.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3336039&group_…
Patches item #3361846, was opened at 2011-07-10 05:57
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3361846&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Anthony Lauzon (pfaffian)
Assigned to: Miller Puckette (millerpuckette)
Summary: bonk~ max/msp fixes
Initial Comment:
Patch consists of 3 changes:
1. Moving some PD specific code inside of #ifdef PD blocks so bonk~ compiles for Max/MSP
2. Bonk template reading/writing correctly works from Max/MSP.
3. "learn" was not using its argument, so every hit was being interpreted as a new template. changed that behaviour.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3361846&group_…
Patches item #3353285, was opened at 2011-07-03 22:24
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3353285&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix crasher bug when closing a window with Perf Mode on
Initial Comment:
fix crasher bug when closing a window with Perf Mode on and no changes to window. It was using the wrong variable, g, which is null. I changed it to x and no crash. Also, I adjusted the dialog to make sense.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3353285&group_…