Pd-dev June 2010

pd-dev@lists.iem.at

16 participants
113 discussions

[ pure-data-Patches-2978457 ] -nogui audio initialization problems under Debian
by SourceForge.net 09 Jun '10

09 Jun '10

Patches item #2978457, was opened at 2010-03-29 06:01 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2978457&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix Status: Open Resolution: Works For Me Priority: 7 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Miller Puckette (millerpuckette) Summary: -nogui audio initialization problems under Debian Initial Comment: The [delread~] in the attached patch fails to initialize to the correct samplerate when started with -nogui under Debian and Pd 0.41.4 or 0.42-5. It seems to initialize to a samplerate of 0 instead. This problem persists independently from the audio driver used (ALS vs OSS). The patch works fine under Windows XP, however. The patch contains a workaround which has been suggested on the Pd-list, i.e. to loadbang a [switch~] object to 0 and then set it to 1 when neded. However, this did not help in the current situation. The patch also delays the loadbanged [;pd dsp 1( message by a [del 1000. This is a workaround addressing another manifestation of the audio initialisation problems with -nogui under Debian. If the [del 1000] is removed, the patch fails to load under -nogui with a "dev/dsp (read/write): Device or resource busy" message. IOhannes has suggested on the list to set the samplerate explicitely at startup, i.e. by pd -nogui -r 44100 However, I cannot confirm this workaround to work with the attached patch. Please note that the attached patch works fine under Windows XP and with -nogui enabled; also if the [del 1000] and [switch~] objects are omitted. best, flo.H ---------------------------------------------------------------------- >Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-06-09 12:49 Message: committed to Pd-extended 0.42.5 here: http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=136… ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-06-09 12:46 Message: Nice example Pd patch illustrating the bug, thanks for that. Its almost a little composition! I also tested this issue on Mac OS X 10.5.8/Intel and it exists there. The attached patch from Matju seems to fix the problem. IOhannes checked it out and ok'ed it too. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-06-05 11:15 Message: this diff ought to be included in pd-extended 0.42 test builds ASAP. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-06-05 11:13 Message: the diff is in the patchtracker. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-17 19:00 Message: move sigdelwrite_updatesr(delwriter, sp[0]->s_sr); inside if (delwriter) or else you will get crashes due to null-pointer error. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 17:56 Message: --- d_delay.c (révision 13558) +++ d_delay.c (copie de travail) @@ -24,6 +24,7 @@ { t_object x_obj; t_symbol *x_sym; + t_float x_deltime; /* delay in msec */ t_delwritectl x_cspace; int x_sortno; /* DSP sort number at which this was last put on chain */ int x_rsortno; /* DSP sort # for first delread or write in chain */ @@ -34,6 +35,21 @@ #define XTRASAMPS 4 #define SAMPBLK 4 +static void sigdelwrite_updatesr (t_sigdelwrite *x, t_float sr) +{ + int nsamps = x->x_deltime * sr * (t_float)(0.001f); + if (nsamps < 1) nsamps = 1; + nsamps += ((- nsamps) & (SAMPBLK - 1)); + nsamps += DEFDELVS; + if (x->x_cspace.c_n != nsamps) { + x->x_cspace.c_vec = (t_sample *)resizebytes(x->x_cspace.c_vec, + (x->x_cspace.c_n + XTRASAMPS) * sizeof(t_sample), + ( nsamps + XTRASAMPS) * sizeof(t_sample)); + x->x_cspace.c_n = nsamps; + x->x_cspace.c_phase = XTRASAMPS; + } +} + /* routine to check that all delwrites/delreads/vds have same vecsize */ static void sigdelwrite_checkvecsize(t_sigdelwrite *x, int vecsize) { @@ -54,19 +70,13 @@ static void *sigdelwrite_new(t_symbol *s, t_floatarg msec) { - int nsamps; t_sigdelwrite *x = (t_sigdelwrite *)pd_new(sigdelwrite_class); if (!*s->s_name) s = gensym("delwrite~"); pd_bind(&x->x_obj.ob_pd, s); x->x_sym = s; - nsamps = msec * sys_getsr() * (t_float)(0.001f); - if (nsamps < 1) nsamps = 1; - nsamps += ((- nsamps) & (SAMPBLK - 1)); - nsamps += DEFDELVS; - x->x_cspace.c_n = nsamps; - x->x_cspace.c_vec = - (t_sample *)getbytes((nsamps + XTRASAMPS) * sizeof(t_sample)); - x->x_cspace.c_phase = XTRASAMPS; + x->x_deltime = msec; + x->x_cspace.c_n = 0; + x->x_cspace.c_vec = getbytes(XTRASAMPS * sizeof(t_sample)); x->x_sortno = 0; x->x_vecsize = 0; x->x_f = 0; @@ -109,6 +119,7 @@ dsp_add(sigdelwrite_perform, 3, sp[0]->s_vec, &x->x_cspace, sp[0]->s_n); x->x_sortno = ugen_getsortno(); sigdelwrite_checkvecsize(x, sp[0]->s_n); + sigdelwrite_updatesr(x, sp[0]->s_sr); } static void sigdelwrite_free(t_sigdelwrite *x) @@ -180,6 +191,7 @@ int delsamps = *(int *)(w[3]); int n = (int)(w[4]); int phase = c->c_phase - delsamps, nsamps = c->c_n; + t_sample *vp = c->c_vec, *bp, *ep = vp + (c->c_n + XTRASAMPS); if (phase < 0) phase += nsamps; bp = vp + phase; @@ -197,6 +209,7 @@ t_sigdelwrite *delwriter = (t_sigdelwrite *)pd_findbyclass(x->x_sym, sigdelwrite_class); x->x_sr = sp[0]->s_sr * 0.001; + sigdelwrite_updatesr(delwriter, sp[0]->s_sr); x->x_n = sp[0]->s_n; if (delwriter) { @@ -206,8 +219,7 @@ sigdelread_float(x, x->x_deltime); dsp_add(sigdelread_perform, 4, sp[0]->s_vec, &delwriter->x_cspace, &x->x_delsamps, sp[0]->s_n); - } - else if (*x->x_sym->s_name) + } else if (*x->x_sym->s_name) error("delread~: %s: no such delwrite~",x->x_sym->s_name); } ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 14:03 Message: the bug is actually deeper than that, as delread does a bunch of "Invalid read of size 4" according to valgrind, after this fix. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:48 Message: the previous fix is leaking memory. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:45 Message: --- d_delay.c (révision 13539) +++ d_delay.c (copie de travail) @@ -24,6 +24,7 @@ { t_object x_obj; t_symbol *x_sym; + t_float x_deltime; /* delay in msec */ t_delwritectl x_cspace; int x_sortno; /* DSP sort number at which this was last put on chain */ int x_rsortno; /* DSP sort # for first delread or write in chain */ @@ -54,19 +55,13 @@ static void *sigdelwrite_new(t_symbol *s, t_floatarg msec) { - int nsamps; t_sigdelwrite *x = (t_sigdelwrite *)pd_new(sigdelwrite_class); if (!*s->s_name) s = gensym("delwrite~"); pd_bind(&x->x_obj.ob_pd, s); x->x_sym = s; - nsamps = msec * sys_getsr() * (t_float)(0.001f); - if (nsamps < 1) nsamps = 1; - nsamps += ((- nsamps) & (SAMPBLK - 1)); - nsamps += DEFDELVS; - x->x_cspace.c_n = nsamps; - x->x_cspace.c_vec = - (t_sample *)getbytes((nsamps + XTRASAMPS) * sizeof(t_sample)); - x->x_cspace.c_phase = XTRASAMPS; + x->x_deltime = msec; + x->x_cspace.c_n = 0; + x->x_cspace.c_vec = 0; x->x_sortno = 0; x->x_vecsize = 0; x->x_f = 0; @@ -106,6 +101,18 @@ static void sigdelwrite_dsp(t_sigdelwrite *x, t_signal **sp) { + int nsamps = x->x_deltime * sp[0]->s_sr * (t_float)(0.001f); + post("sigdelwrite_dsp: %f ms, with sr=%f",x->x_deltime,sys_getsr()); + if (nsamps < 1) nsamps = 1; + nsamps += ((- nsamps) & (SAMPBLK - 1)); + nsamps += DEFDELVS; + if (x->x_cspace.c_n != nsamps) { + x->x_cspace.c_n = nsamps; + x->x_cspace.c_vec = + (t_sample *)getbytes((nsamps + XTRASAMPS) * sizeof(t_sample)); + x->x_cspace.c_phase = XTRASAMPS; + } + dsp_add(sigdelwrite_perform, 3, sp[0]->s_vec, &x->x_cspace, sp[0]->s_n); x->x_sortno = ugen_getsortno(); sigdelwrite_checkvecsize(x, sp[0]->s_n); ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:40 Message: this also goes with another bug : [delwrite~] doesn't honour the sampling rate set by [block~] ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:20 Message: this goes with another bug : [delwrite~] doesn't honour any change of sampling rate (e.g. 44100 to 22050). those bugs are related because the reason [delwrite~] doesn't work with this, is that [delwrite~] is created while sys_getsr() still reports sampling rate to be "0", because sys_dacsr has not been assigned to. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:00 Message: if you load your patch using a «; pd open $1 .» message from a [delay]ed [loadbang], the patch runs correctly. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 12:53 Message: you can replace the [delay 1000] by just [delay], that is, [delay 0]. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2978457&group_…

1 0

[ pure-data-Patches-2978457 ] -nogui audio initialization problems under Debian
by SourceForge.net 09 Jun '10

09 Jun '10

Patches item #2978457, was opened at 2010-03-29 06:01 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2978457&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata >Group: bugfix Status: Open >Resolution: Works For Me >Priority: 7 Private: No Submitted By: Nobody/Anonymous (nobody) >Assigned to: Miller Puckette (millerpuckette) Summary: -nogui audio initialization problems under Debian Initial Comment: The [delread~] in the attached patch fails to initialize to the correct samplerate when started with -nogui under Debian and Pd 0.41.4 or 0.42-5. It seems to initialize to a samplerate of 0 instead. This problem persists independently from the audio driver used (ALS vs OSS). The patch works fine under Windows XP, however. The patch contains a workaround which has been suggested on the Pd-list, i.e. to loadbang a [switch~] object to 0 and then set it to 1 when neded. However, this did not help in the current situation. The patch also delays the loadbanged [;pd dsp 1( message by a [del 1000. This is a workaround addressing another manifestation of the audio initialisation problems with -nogui under Debian. If the [del 1000] is removed, the patch fails to load under -nogui with a "dev/dsp (read/write): Device or resource busy" message. IOhannes has suggested on the list to set the samplerate explicitely at startup, i.e. by pd -nogui -r 44100 However, I cannot confirm this workaround to work with the attached patch. Please note that the attached patch works fine under Windows XP and with -nogui enabled; also if the [del 1000] and [switch~] objects are omitted. best, flo.H ---------------------------------------------------------------------- >Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-06-09 12:46 Message: Nice example Pd patch illustrating the bug, thanks for that. Its almost a little composition! I also tested this issue on Mac OS X 10.5.8/Intel and it exists there. The attached patch from Matju seems to fix the problem. IOhannes checked it out and ok'ed it too. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-06-05 11:15 Message: this diff ought to be included in pd-extended 0.42 test builds ASAP. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-06-05 11:13 Message: the diff is in the patchtracker. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-17 19:00 Message: move sigdelwrite_updatesr(delwriter, sp[0]->s_sr); inside if (delwriter) or else you will get crashes due to null-pointer error. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 17:56 Message: --- d_delay.c (révision 13558) +++ d_delay.c (copie de travail) @@ -24,6 +24,7 @@ { t_object x_obj; t_symbol *x_sym; + t_float x_deltime; /* delay in msec */ t_delwritectl x_cspace; int x_sortno; /* DSP sort number at which this was last put on chain */ int x_rsortno; /* DSP sort # for first delread or write in chain */ @@ -34,6 +35,21 @@ #define XTRASAMPS 4 #define SAMPBLK 4 +static void sigdelwrite_updatesr (t_sigdelwrite *x, t_float sr) +{ + int nsamps = x->x_deltime * sr * (t_float)(0.001f); + if (nsamps < 1) nsamps = 1; + nsamps += ((- nsamps) & (SAMPBLK - 1)); + nsamps += DEFDELVS; + if (x->x_cspace.c_n != nsamps) { + x->x_cspace.c_vec = (t_sample *)resizebytes(x->x_cspace.c_vec, + (x->x_cspace.c_n + XTRASAMPS) * sizeof(t_sample), + ( nsamps + XTRASAMPS) * sizeof(t_sample)); + x->x_cspace.c_n = nsamps; + x->x_cspace.c_phase = XTRASAMPS; + } +} + /* routine to check that all delwrites/delreads/vds have same vecsize */ static void sigdelwrite_checkvecsize(t_sigdelwrite *x, int vecsize) { @@ -54,19 +70,13 @@ static void *sigdelwrite_new(t_symbol *s, t_floatarg msec) { - int nsamps; t_sigdelwrite *x = (t_sigdelwrite *)pd_new(sigdelwrite_class); if (!*s->s_name) s = gensym("delwrite~"); pd_bind(&x->x_obj.ob_pd, s); x->x_sym = s; - nsamps = msec * sys_getsr() * (t_float)(0.001f); - if (nsamps < 1) nsamps = 1; - nsamps += ((- nsamps) & (SAMPBLK - 1)); - nsamps += DEFDELVS; - x->x_cspace.c_n = nsamps; - x->x_cspace.c_vec = - (t_sample *)getbytes((nsamps + XTRASAMPS) * sizeof(t_sample)); - x->x_cspace.c_phase = XTRASAMPS; + x->x_deltime = msec; + x->x_cspace.c_n = 0; + x->x_cspace.c_vec = getbytes(XTRASAMPS * sizeof(t_sample)); x->x_sortno = 0; x->x_vecsize = 0; x->x_f = 0; @@ -109,6 +119,7 @@ dsp_add(sigdelwrite_perform, 3, sp[0]->s_vec, &x->x_cspace, sp[0]->s_n); x->x_sortno = ugen_getsortno(); sigdelwrite_checkvecsize(x, sp[0]->s_n); + sigdelwrite_updatesr(x, sp[0]->s_sr); } static void sigdelwrite_free(t_sigdelwrite *x) @@ -180,6 +191,7 @@ int delsamps = *(int *)(w[3]); int n = (int)(w[4]); int phase = c->c_phase - delsamps, nsamps = c->c_n; + t_sample *vp = c->c_vec, *bp, *ep = vp + (c->c_n + XTRASAMPS); if (phase < 0) phase += nsamps; bp = vp + phase; @@ -197,6 +209,7 @@ t_sigdelwrite *delwriter = (t_sigdelwrite *)pd_findbyclass(x->x_sym, sigdelwrite_class); x->x_sr = sp[0]->s_sr * 0.001; + sigdelwrite_updatesr(delwriter, sp[0]->s_sr); x->x_n = sp[0]->s_n; if (delwriter) { @@ -206,8 +219,7 @@ sigdelread_float(x, x->x_deltime); dsp_add(sigdelread_perform, 4, sp[0]->s_vec, &delwriter->x_cspace, &x->x_delsamps, sp[0]->s_n); - } - else if (*x->x_sym->s_name) + } else if (*x->x_sym->s_name) error("delread~: %s: no such delwrite~",x->x_sym->s_name); } ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 14:03 Message: the bug is actually deeper than that, as delread does a bunch of "Invalid read of size 4" according to valgrind, after this fix. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:48 Message: the previous fix is leaking memory. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:45 Message: --- d_delay.c (révision 13539) +++ d_delay.c (copie de travail) @@ -24,6 +24,7 @@ { t_object x_obj; t_symbol *x_sym; + t_float x_deltime; /* delay in msec */ t_delwritectl x_cspace; int x_sortno; /* DSP sort number at which this was last put on chain */ int x_rsortno; /* DSP sort # for first delread or write in chain */ @@ -54,19 +55,13 @@ static void *sigdelwrite_new(t_symbol *s, t_floatarg msec) { - int nsamps; t_sigdelwrite *x = (t_sigdelwrite *)pd_new(sigdelwrite_class); if (!*s->s_name) s = gensym("delwrite~"); pd_bind(&x->x_obj.ob_pd, s); x->x_sym = s; - nsamps = msec * sys_getsr() * (t_float)(0.001f); - if (nsamps < 1) nsamps = 1; - nsamps += ((- nsamps) & (SAMPBLK - 1)); - nsamps += DEFDELVS; - x->x_cspace.c_n = nsamps; - x->x_cspace.c_vec = - (t_sample *)getbytes((nsamps + XTRASAMPS) * sizeof(t_sample)); - x->x_cspace.c_phase = XTRASAMPS; + x->x_deltime = msec; + x->x_cspace.c_n = 0; + x->x_cspace.c_vec = 0; x->x_sortno = 0; x->x_vecsize = 0; x->x_f = 0; @@ -106,6 +101,18 @@ static void sigdelwrite_dsp(t_sigdelwrite *x, t_signal **sp) { + int nsamps = x->x_deltime * sp[0]->s_sr * (t_float)(0.001f); + post("sigdelwrite_dsp: %f ms, with sr=%f",x->x_deltime,sys_getsr()); + if (nsamps < 1) nsamps = 1; + nsamps += ((- nsamps) & (SAMPBLK - 1)); + nsamps += DEFDELVS; + if (x->x_cspace.c_n != nsamps) { + x->x_cspace.c_n = nsamps; + x->x_cspace.c_vec = + (t_sample *)getbytes((nsamps + XTRASAMPS) * sizeof(t_sample)); + x->x_cspace.c_phase = XTRASAMPS; + } + dsp_add(sigdelwrite_perform, 3, sp[0]->s_vec, &x->x_cspace, sp[0]->s_n); x->x_sortno = ugen_getsortno(); sigdelwrite_checkvecsize(x, sp[0]->s_n); ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:40 Message: this also goes with another bug : [delwrite~] doesn't honour the sampling rate set by [block~] ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:20 Message: this goes with another bug : [delwrite~] doesn't honour any change of sampling rate (e.g. 44100 to 22050). those bugs are related because the reason [delwrite~] doesn't work with this, is that [delwrite~] is created while sys_getsr() still reports sampling rate to be "0", because sys_dacsr has not been assigned to. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:00 Message: if you load your patch using a «; pd open $1 .» message from a [delay]ed [loadbang], the patch runs correctly. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 12:53 Message: you can replace the [delay 1000] by just [delay], that is, [delay 0]. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2978457&group_…

1 0

[ pure-data-Patches-3011594 ] get delwrite~ to work with block~, -nogui, rate changes
by SourceForge.net 09 Jun '10

09 Jun '10

Patches item #3011594, was opened at 2010-06-04 12:57 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3011594&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix Status: Closed >Resolution: Duplicate Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: get delwrite~ to work with block~, -nogui, rate changes Initial Comment: Maître Corbeau, sur un arbre perché, Tenait en son bec un fromage. Maître Renard, par l'odeur alléché, Lui tint à peu près ce langage : " Hé ! bonjour, Monsieur du Corbeau, Que vous êtes joli ! que vous me semblez beau ! Sans mentir, si votre ramage Se rapporte à votre plumage, Vous êtes le phénix des hôtes de ces bois. " A ces mots le Corbeau ne se sent pas de joie ; Et pour montrer sa belle voix, Il ouvre un large bec, laisse tomber sa proie. Le Renard s'en saisit, et dit : " Mon bon Monsieur, Apprenez que tout flatteur Vit aux dépens de celui qui l'écoute : Cette leçon vaut bien un fromage, sans doute. " Le Corbeau, honteux et confus, Jura, mais un peu tard, qu'on ne l'y prendrait plus. ---------------------------------------------------------------------- >Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-06-09 12:35 Message: Since Majtu seems to think the patch tracker is some kind of game for creating extra admin work, I'll have to do the work for This does not make me happy. http://lists.puredata.info/pipermail/pd-list/2010-06/079349.html The diff has been added to the bug report on this topic: https://sourceforge.net/tracker/index.php?func=detail&aid=2978457&group_id=… ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-06-09 12:34 Message: This artifact has been marked as a duplicate of artifact 2978457 with reason: diff here addresses this bug report ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-06-04 14:52 Message: can you tell us about the file that you attached, the why and the what maybe? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3011594&group_…

1 0

[ pure-data-Patches-3011594 ] get delwrite~ to work with block~, -nogui, rate changes
by SourceForge.net 09 Jun '10

09 Jun '10

Patches item #3011594, was opened at 2010-06-04 12:57 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3011594&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: get delwrite~ to work with block~, -nogui, rate changes Initial Comment: Maître Corbeau, sur un arbre perché, Tenait en son bec un fromage. Maître Renard, par l'odeur alléché, Lui tint à peu près ce langage : " Hé ! bonjour, Monsieur du Corbeau, Que vous êtes joli ! que vous me semblez beau ! Sans mentir, si votre ramage Se rapporte à votre plumage, Vous êtes le phénix des hôtes de ces bois. " A ces mots le Corbeau ne se sent pas de joie ; Et pour montrer sa belle voix, Il ouvre un large bec, laisse tomber sa proie. Le Renard s'en saisit, et dit : " Mon bon Monsieur, Apprenez que tout flatteur Vit aux dépens de celui qui l'écoute : Cette leçon vaut bien un fromage, sans doute. " Le Corbeau, honteux et confus, Jura, mais un peu tard, qu'on ne l'y prendrait plus. ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-06-09 12:34 Message: This artifact has been marked as a duplicate of artifact 2978457 with reason: diff here addresses this bug report ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-06-04 14:52 Message: can you tell us about the file that you attached, the why and the what maybe? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3011594&group_…

1 0

[ pure-data-Patches-2978457 ] -nogui audio initialization problems under Debian
by SourceForge.net 09 Jun '10

09 Jun '10

Patches item #2978457, was opened at 2010-03-29 06:01 Message generated for change (Settings changed) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2978457&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: puredata Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: -nogui audio initialization problems under Debian Initial Comment: The [delread~] in the attached patch fails to initialize to the correct samplerate when started with -nogui under Debian and Pd 0.41.4 or 0.42-5. It seems to initialize to a samplerate of 0 instead. This problem persists independently from the audio driver used (ALS vs OSS). The patch works fine under Windows XP, however. The patch contains a workaround which has been suggested on the Pd-list, i.e. to loadbang a [switch~] object to 0 and then set it to 1 when neded. However, this did not help in the current situation. The patch also delays the loadbanged [;pd dsp 1( message by a [del 1000. This is a workaround addressing another manifestation of the audio initialisation problems with -nogui under Debian. If the [del 1000] is removed, the patch fails to load under -nogui with a "dev/dsp (read/write): Device or resource busy" message. IOhannes has suggested on the list to set the samplerate explicitely at startup, i.e. by pd -nogui -r 44100 However, I cannot confirm this workaround to work with the attached patch. Please note that the attached patch works fine under Windows XP and with -nogui enabled; also if the [del 1000] and [switch~] objects are omitted. best, flo.H ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-06-05 11:15 Message: this diff ought to be included in pd-extended 0.42 test builds ASAP. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-06-05 11:13 Message: the diff is in the patchtracker. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-17 19:00 Message: move sigdelwrite_updatesr(delwriter, sp[0]->s_sr); inside if (delwriter) or else you will get crashes due to null-pointer error. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 17:56 Message: --- d_delay.c (révision 13558) +++ d_delay.c (copie de travail) @@ -24,6 +24,7 @@ { t_object x_obj; t_symbol *x_sym; + t_float x_deltime; /* delay in msec */ t_delwritectl x_cspace; int x_sortno; /* DSP sort number at which this was last put on chain */ int x_rsortno; /* DSP sort # for first delread or write in chain */ @@ -34,6 +35,21 @@ #define XTRASAMPS 4 #define SAMPBLK 4 +static void sigdelwrite_updatesr (t_sigdelwrite *x, t_float sr) +{ + int nsamps = x->x_deltime * sr * (t_float)(0.001f); + if (nsamps < 1) nsamps = 1; + nsamps += ((- nsamps) & (SAMPBLK - 1)); + nsamps += DEFDELVS; + if (x->x_cspace.c_n != nsamps) { + x->x_cspace.c_vec = (t_sample *)resizebytes(x->x_cspace.c_vec, + (x->x_cspace.c_n + XTRASAMPS) * sizeof(t_sample), + ( nsamps + XTRASAMPS) * sizeof(t_sample)); + x->x_cspace.c_n = nsamps; + x->x_cspace.c_phase = XTRASAMPS; + } +} + /* routine to check that all delwrites/delreads/vds have same vecsize */ static void sigdelwrite_checkvecsize(t_sigdelwrite *x, int vecsize) { @@ -54,19 +70,13 @@ static void *sigdelwrite_new(t_symbol *s, t_floatarg msec) { - int nsamps; t_sigdelwrite *x = (t_sigdelwrite *)pd_new(sigdelwrite_class); if (!*s->s_name) s = gensym("delwrite~"); pd_bind(&x->x_obj.ob_pd, s); x->x_sym = s; - nsamps = msec * sys_getsr() * (t_float)(0.001f); - if (nsamps < 1) nsamps = 1; - nsamps += ((- nsamps) & (SAMPBLK - 1)); - nsamps += DEFDELVS; - x->x_cspace.c_n = nsamps; - x->x_cspace.c_vec = - (t_sample *)getbytes((nsamps + XTRASAMPS) * sizeof(t_sample)); - x->x_cspace.c_phase = XTRASAMPS; + x->x_deltime = msec; + x->x_cspace.c_n = 0; + x->x_cspace.c_vec = getbytes(XTRASAMPS * sizeof(t_sample)); x->x_sortno = 0; x->x_vecsize = 0; x->x_f = 0; @@ -109,6 +119,7 @@ dsp_add(sigdelwrite_perform, 3, sp[0]->s_vec, &x->x_cspace, sp[0]->s_n); x->x_sortno = ugen_getsortno(); sigdelwrite_checkvecsize(x, sp[0]->s_n); + sigdelwrite_updatesr(x, sp[0]->s_sr); } static void sigdelwrite_free(t_sigdelwrite *x) @@ -180,6 +191,7 @@ int delsamps = *(int *)(w[3]); int n = (int)(w[4]); int phase = c->c_phase - delsamps, nsamps = c->c_n; + t_sample *vp = c->c_vec, *bp, *ep = vp + (c->c_n + XTRASAMPS); if (phase < 0) phase += nsamps; bp = vp + phase; @@ -197,6 +209,7 @@ t_sigdelwrite *delwriter = (t_sigdelwrite *)pd_findbyclass(x->x_sym, sigdelwrite_class); x->x_sr = sp[0]->s_sr * 0.001; + sigdelwrite_updatesr(delwriter, sp[0]->s_sr); x->x_n = sp[0]->s_n; if (delwriter) { @@ -206,8 +219,7 @@ sigdelread_float(x, x->x_deltime); dsp_add(sigdelread_perform, 4, sp[0]->s_vec, &delwriter->x_cspace, &x->x_delsamps, sp[0]->s_n); - } - else if (*x->x_sym->s_name) + } else if (*x->x_sym->s_name) error("delread~: %s: no such delwrite~",x->x_sym->s_name); } ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 14:03 Message: the bug is actually deeper than that, as delread does a bunch of "Invalid read of size 4" according to valgrind, after this fix. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:48 Message: the previous fix is leaking memory. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:45 Message: --- d_delay.c (révision 13539) +++ d_delay.c (copie de travail) @@ -24,6 +24,7 @@ { t_object x_obj; t_symbol *x_sym; + t_float x_deltime; /* delay in msec */ t_delwritectl x_cspace; int x_sortno; /* DSP sort number at which this was last put on chain */ int x_rsortno; /* DSP sort # for first delread or write in chain */ @@ -54,19 +55,13 @@ static void *sigdelwrite_new(t_symbol *s, t_floatarg msec) { - int nsamps; t_sigdelwrite *x = (t_sigdelwrite *)pd_new(sigdelwrite_class); if (!*s->s_name) s = gensym("delwrite~"); pd_bind(&x->x_obj.ob_pd, s); x->x_sym = s; - nsamps = msec * sys_getsr() * (t_float)(0.001f); - if (nsamps < 1) nsamps = 1; - nsamps += ((- nsamps) & (SAMPBLK - 1)); - nsamps += DEFDELVS; - x->x_cspace.c_n = nsamps; - x->x_cspace.c_vec = - (t_sample *)getbytes((nsamps + XTRASAMPS) * sizeof(t_sample)); - x->x_cspace.c_phase = XTRASAMPS; + x->x_deltime = msec; + x->x_cspace.c_n = 0; + x->x_cspace.c_vec = 0; x->x_sortno = 0; x->x_vecsize = 0; x->x_f = 0; @@ -106,6 +101,18 @@ static void sigdelwrite_dsp(t_sigdelwrite *x, t_signal **sp) { + int nsamps = x->x_deltime * sp[0]->s_sr * (t_float)(0.001f); + post("sigdelwrite_dsp: %f ms, with sr=%f",x->x_deltime,sys_getsr()); + if (nsamps < 1) nsamps = 1; + nsamps += ((- nsamps) & (SAMPBLK - 1)); + nsamps += DEFDELVS; + if (x->x_cspace.c_n != nsamps) { + x->x_cspace.c_n = nsamps; + x->x_cspace.c_vec = + (t_sample *)getbytes((nsamps + XTRASAMPS) * sizeof(t_sample)); + x->x_cspace.c_phase = XTRASAMPS; + } + dsp_add(sigdelwrite_perform, 3, sp[0]->s_vec, &x->x_cspace, sp[0]->s_n); x->x_sortno = ugen_getsortno(); sigdelwrite_checkvecsize(x, sp[0]->s_n); ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:40 Message: this also goes with another bug : [delwrite~] doesn't honour the sampling rate set by [block~] ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:20 Message: this goes with another bug : [delwrite~] doesn't honour any change of sampling rate (e.g. 44100 to 22050). those bugs are related because the reason [delwrite~] doesn't work with this, is that [delwrite~] is created while sys_getsr() still reports sampling rate to be "0", because sys_dacsr has not been assigned to. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 13:00 Message: if you load your patch using a «; pd open $1 .» message from a [delay]ed [loadbang], the patch runs correctly. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-05-16 12:53 Message: you can replace the [delay 1000] by just [delay], that is, [delay 0]. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2978457&group_…

1 0

Re: [PD-dev] patch for mrpeach/tcpserver.c
by Ivica Ico Bukvic 08 Jun '10

08 Jun '10

Speaking of tcpserver.c isn't the tcpserver_notify() function making an unsafe outlet_float() call when it is being triggered by an external event (disconnection) which can happen out-of-order and thus potentially causing crashes? Shouldn't this be wrapped also in a clock_delay()? Best wishes, Ico

6 22

Updating pd help patches
by Jonathan Wilkes 08 Jun '10

08 Jun '10

Hi, I sent an email to the user list, but I guess it belongs here instead. I have revised almost all of the help patches for vanilla objects to conform to the PDDP template created a few years back. Each patch lists info for xlets, args, and related objects and has a [pd META] subpatch with info that can be used if someone makes a plug-in to search for objects (I made a simple patch called search-test.pd as a demo). All patches are the same size and are located at origin 0,0 (top left of screen) so that at least part of the patch will be visible at any screen resolution. Each patch also has a pddplink at the bottom left to a general "Help" patch (pddp/help.pd) that links to: * a help page for the pd help system * the Pd Manual * various tutorials (control, audio, intro to gem, dynamic patching, etc.) * other resources like the all_about_* patches (which I've revised and added to) There is also a decent attempt at cross-referencing, so that, for example, the help patch for delread~ has a pddplink to the audio tutorials where that object is used (G01, G02, G05). Each help patch also has a link to the respective pdpedia web page (although I'm not sure that this will turn out to be all that useful). I'm also in the middle of adding [pd META] tags to all the externals included in pd-ext, as well as creating help patches for the objects that don't currently have one. The patches are all at: http://puredata.info/Members/jwilkes/doc/at_download/file As I said in my email on the user list, I've never used SVN before, but I'm happy to learn it if that's the easiest way to get them into pd-ext. As for the revisions of external help patches, I'm not sure what the best way is to implement my changes, since those help patches belong to their respective developers. I would appreciate suggestions anyone has on the best way to proceed. Thanks, Jonathan

2 2

starting the Pd-extended release process
by Hans-Christoph Steiner 08 Jun '10

08 Jun '10

Unless I hear from anyone soon, I'm going to be copying trunk/ externals to the pd-extended/0.42 branch today in preparation for making the final release. Any changes that need to happen in trunk can always be merged, and vice versa. .hc ---------------------------------------------------------------------------- Man has survived hitherto because he was too ignorant to know how to realize his wishes. Now that he can realize them, he must either change them, or perish. -William Carlos Williams

2 3

PdLab access
by William Brent 07 Jun '10

07 Jun '10

Hello all, I'm in need of a 32-bit Linux machine to build a set of externs. Hans suggested I use one of the build servers. Can I get access to this machine: ubuntu-current-i386 (128.238.56.53) (current version) ? Thanks, William -- William Brent www.williambrent.com “Great minds flock together” Conflations: conversational idiom for the 21st century www.conflations.com

2 1

pd-mobile-0.43 branch moved
by Hans-Christoph Steiner 07 Jun '10

07 Jun '10

Hey all, FYI: I moved the pd-mobile-0.43 branch to a more appropriate location: https://pure-data.svn.sourceforge.net/svnroot/pure-data/branches/pd-mobile-… If you already have the code checked out, you can point it to the new location by doing this in the Terminal: cd pd-mobile-0.43 svn switch https://pure-data.svn.sourceforge.net/svnroot/pure-data/branches/pd-mobile-… .hc ---------------------------------------------------------------------------- "It is convenient to imagine a power beyond us because that means we don't have to examine our own lives.", from "The Idols of Environmentalism", by Curtis White

3 4

← Newer
1
...
4
5
6
7
8
9
10
11
12
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pd-dev June 2010