Pd-dev January 2008

pd-dev@lists.iem.at

27 participants
93 discussions

[ pure-data-Patches-1848356 ] streamin/streamout doc updates, bugs, and a security issue
by SourceForge.net 06 Jan '08

06 Jan '08

Patches item #1848356, was opened at 2007-12-10 21:29 Message generated for change (Comment added) made by russellbryant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1848356&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: externals Group: bugfix >Status: Closed >Resolution: Accepted Priority: 5 Private: Yes Submitted By: Russell Bryant (russellbryant) Assigned to: Guenter Geiger (ggeiger) Summary: streamin/streamout doc updates, bugs, and a security issue Initial Comment: This issue has been marked private as it includes details on a remotely exploitable buffer overflow vulnerability in the code for [streamin~]. A while ago, I was looking around at different options for streaming audio in and out of Pd. I spent a short time looking at the code for [streamin~] and [streamout~]. I ended up not using them for my project. However, I made this set of changes while looking at the code. Since I moved on to something else, these changes aren't exactly complete, but point out some important things, so I think they may be worth putting in as is. Here is a summary of the changes that are included. stream.h changes: 1) doxygen style documentation updates 2) added an ifdef to protect against multiple or recursive inclusion of the header 3) Documentation of some of the fields in the data structures 4) Fixed potential alignment bugs by adding the packed attribute for the structure that defines frame headers. This attribute should always be used when it is used to directly interpret data from the network or when used to prepare data to send directly over the network. This section of the gcc manual has a tidbit about the attribute: http://gcc.gnu.org/onlinedocs/gcc-4.2.2/gcc/Variable-Attributes.html#Variab… 5) Point out the fact that the code is not endianness-safe. The code should eventually be updated to respect network byte order. 6) Point out that the version field of the frame header is ignored when parsing incoming frames. It should eventually be checked, but doesn't matter much until the format gets changed such that the version number gets bumped. 7) Change a list of #defines to an enum, for the sake of better coding practice. 8) Change the use of "int" in the frame header structure to explicitly list that the field is 32-bits by using the int32_t type. streamin~.c changes: 1) Fix a remotely exploitable buffer overflow that would allow remote execution of arbitrary code. The frame header includes 4 bytes to specify the frame length. However, the code only allocates enough space for the frame header and 256 bytes of payload data. The size portion of the frame header was not checked to ensure that its value was valid. This little hack should fix it. ---------------------------------------------------------------------- >Comment By: Russell Bryant (russellbryant) Date: 2008-01-06 08:31 Message: Logged In: YES user_id=1942915 Originator: YES I have merged these patches into the externals repository. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1848356&group_…

1 0

[ pure-data-Patches-1836228 ] [patch] simplify pd_makeversion() in src/s_main.c
by SourceForge.net 06 Jan '08

06 Jan '08

Patches item #1836228, was opened at 2007-11-21 22:37 Message generated for change (Comment added) made by russellbryant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Russell Bryant (russellbryant) Assigned to: Miller Puckette (millerpuckette) Summary: [patch] simplify pd_makeversion() in src/s_main.c Initial Comment: This minor patch simplifies the pd_makeversion() function in src/s_main.c. It replaces the sprintf / malloc / strcpy, with the equivalent single call to asprintf. It also provides the side benefit of removing the length limitation introduced by the intermediary stack buffer (with bounds that weren't being checked). ---------------------------------------------------------------------- >Comment By: Russell Bryant (russellbryant) Date: 2008-01-05 22:30 Message: Logged In: YES user_id=1942915 Originator: YES File Added: makeversion.patch2.txt ---------------------------------------------------------------------- Comment By: Russell Bryant (russellbryant) Date: 2008-01-05 22:29 Message: Logged In: YES user_id=1942915 Originator: YES Actually, I mean sprintf to snprintf. Anyway, here is an updated patch that includes the change from sprintf to snprintf, as well as a simplification to use strdup() instead of malloc/strcpy. ---------------------------------------------------------------------- Comment By: Russell Bryant (russellbryant) Date: 2008-01-05 22:26 Message: Logged In: YES user_id=1942915 Originator: YES Well, it turns out that asprintf() is a GNU extension, and is not a part of standard C or POSIX. So, this probably will not be acceptable. However, I'd like to still leave it open, as I'd like to see the strcpy changed to strncpy ... ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2007-11-23 13:24 Message: Logged In: YES user_id=27104 Originator: NO Funny, I originally submitted the patch with this function and it included asprintf(). Miller accepted the patch, but replaced the asprintf() with the sprintf/malloc/strcpy combo, with only this comment: "modified to avoid the effete asprintf() call, then took for 0.40" ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_…

1 0

[ pure-data-Patches-1836228 ] [patch] simplify pd_makeversion() in src/s_main.c
by SourceForge.net 06 Jan '08

06 Jan '08

Patches item #1836228, was opened at 2007-11-21 22:37 Message generated for change (Comment added) made by russellbryant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Russell Bryant (russellbryant) Assigned to: Miller Puckette (millerpuckette) Summary: [patch] simplify pd_makeversion() in src/s_main.c Initial Comment: This minor patch simplifies the pd_makeversion() function in src/s_main.c. It replaces the sprintf / malloc / strcpy, with the equivalent single call to asprintf. It also provides the side benefit of removing the length limitation introduced by the intermediary stack buffer (with bounds that weren't being checked). ---------------------------------------------------------------------- >Comment By: Russell Bryant (russellbryant) Date: 2008-01-05 22:29 Message: Logged In: YES user_id=1942915 Originator: YES Actually, I mean sprintf to snprintf. Anyway, here is an updated patch that includes the change from sprintf to snprintf, as well as a simplification to use strdup() instead of malloc/strcpy. ---------------------------------------------------------------------- Comment By: Russell Bryant (russellbryant) Date: 2008-01-05 22:26 Message: Logged In: YES user_id=1942915 Originator: YES Well, it turns out that asprintf() is a GNU extension, and is not a part of standard C or POSIX. So, this probably will not be acceptable. However, I'd like to still leave it open, as I'd like to see the strcpy changed to strncpy ... ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2007-11-23 13:24 Message: Logged In: YES user_id=27104 Originator: NO Funny, I originally submitted the patch with this function and it included asprintf(). Miller accepted the patch, but replaced the asprintf() with the sprintf/malloc/strcpy combo, with only this comment: "modified to avoid the effete asprintf() call, then took for 0.40" ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_…

1 0

[ pure-data-Patches-1836228 ] [patch] simplify pd_makeversion() in src/s_main.c
by SourceForge.net 06 Jan '08

06 Jan '08

Patches item #1836228, was opened at 2007-11-21 22:37 Message generated for change (Comment added) made by russellbryant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Russell Bryant (russellbryant) Assigned to: Miller Puckette (millerpuckette) Summary: [patch] simplify pd_makeversion() in src/s_main.c Initial Comment: This minor patch simplifies the pd_makeversion() function in src/s_main.c. It replaces the sprintf / malloc / strcpy, with the equivalent single call to asprintf. It also provides the side benefit of removing the length limitation introduced by the intermediary stack buffer (with bounds that weren't being checked). ---------------------------------------------------------------------- >Comment By: Russell Bryant (russellbryant) Date: 2008-01-05 22:26 Message: Logged In: YES user_id=1942915 Originator: YES Well, it turns out that asprintf() is a GNU extension, and is not a part of standard C or POSIX. So, this probably will not be acceptable. However, I'd like to still leave it open, as I'd like to see the strcpy changed to strncpy ... ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2007-11-23 13:24 Message: Logged In: YES user_id=27104 Originator: NO Funny, I originally submitted the patch with this function and it included asprintf(). Miller accepted the patch, but replaced the asprintf() with the sprintf/malloc/strcpy combo, with only this comment: "modified to avoid the effete asprintf() call, then took for 0.40" ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_…

1 0

[ pure-data-Bugs-1863764 ] windows vista always crash
by SourceForge.net 06 Jan '08

06 Jan '08

Bugs item #1863764, was opened at 2008-01-04 05:31 Message generated for change (Comment added) made by pazelty You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1863764&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: pd-extended Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Hans-Christoph Steiner (eighthave) Summary: windows vista always crash Initial Comment: It's impossible to use puredata on windows vista :-( I use pd-extended 0.39-3 I have this patch : #N canvas 0 0 458 308 10; #X floatatom 89 13 5 0 0 0 - - -; #X floatatom 171 13 5 0 0 0 - - -; #X floatatom 134 123 5 0 0 0 - - -; #X obj 133 48 t b f; #X obj 134 84 /; #X connect 0 0 4 0; #X connect 1 0 3 0; #X connect 3 0 4 0; #X connect 3 1 4 1; #X connect 4 0 2 0; you can view it (with the crash) on : http://pazelty.free.fr/fichiers/pd-crash.jpg if I divise by exeample 3 by 11 the result on the botom atom is "ÿÿ272" in the print it's correct after I can swith 3 / 12 = 0.25 3 / 13 = ÿÿ230 3 / 9 = ÿÿ333 some number swith every time : 3 / 32 can be "£" or "'" or "Ñ" or "Î" and many many other thing like japones characters and others... I'm not sure but I thing more than half calcul are not good. This is a graphical bug. It's not very very serious. But they are more serious. If I press on an atom on the top, and I change the value non stop by mooving my mouse up and down, pd need about 10 seconds for crash. It's can change : 2 second or 1 minutes but always it will crash. if you use a slider who output no interger number it's exactly the same bug. as well If you make a not integer multiplication : 26 * 21.3 = ÿÿ6.7 As well for + and - operator I think they are many other operator who is impact by this bug but I will not test all ------ thanks you very mutch for puredata it's a fantastic programe even if they have some bugs. If I can help you, I'm available... and ... Happy new years ---------------------------------------------------------------------- Comment By: Rémi Delepoulle (pazelty) Date: 2008-01-06 03:32 Message: Logged In: YES user_id=1974597 Originator: NO hello It's me that I have submit this bug, now I have create an account on sourceforge Now I have install pd 40-2 (not extended) and it's work :) ask me if you need more informations Rémi ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1863764&group_…

1 0

[ pure-data-Bugs-1863325 ] font bug
by SourceForge.net 05 Jan '08

05 Jan '08

Bugs item #1863325, was opened at 2008-01-03 13:25 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1863325&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: pd-extended Group: None >Status: Closed >Resolution: Duplicate Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Hans-Christoph Steiner (eighthave) Summary: font bug Initial Comment: when I run pd the font is good but when I install pd-extended I have a awful font for the consol and for helps It very dificult for read it I run on debian/lenny/testing You can download screenshot of the bug here : http://pazelty.free.fr/fichiers/pd-extended.png on ubuntu I don't have this problem. ---------------------------------------------------------------------- >Comment By: Hans-Christoph Steiner (eighthave) Date: 2008-01-05 03:06 Message: Logged In: YES user_id=27104 Originator: NO This seems to be a common problem but it's not actually a problem with Pd-extended. Either you are missing the ttf-bitstream-vera package which has the font you need, or your fonts aren't properly setup. try this: dpkg-reconfigure x-ttcidfont-conf ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1863325&group_…

1 0

[ pure-data-Bugs-1863764 ] windows vista always crash
by SourceForge.net 04 Jan '08

04 Jan '08

Bugs item #1863764, was opened at 2008-01-03 20:31 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1863764&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: pd-extended Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Hans-Christoph Steiner (eighthave) Summary: windows vista always crash Initial Comment: It's impossible to use puredata on windows vista :-( I use pd-extended 0.39-3 I have this patch : #N canvas 0 0 458 308 10; #X floatatom 89 13 5 0 0 0 - - -; #X floatatom 171 13 5 0 0 0 - - -; #X floatatom 134 123 5 0 0 0 - - -; #X obj 133 48 t b f; #X obj 134 84 /; #X connect 0 0 4 0; #X connect 1 0 3 0; #X connect 3 0 4 0; #X connect 3 1 4 1; #X connect 4 0 2 0; you can view it (with the crash) on : http://pazelty.free.fr/fichiers/pd-crash.jpg if I divise by exeample 3 by 11 the result on the botom atom is "ÿÿ272" in the print it's correct after I can swith 3 / 12 = 0.25 3 / 13 = ÿÿ230 3 / 9 = ÿÿ333 some number swith every time : 3 / 32 can be "£" or "'" or "Ñ" or "Î" and many many other thing like japones characters and others... I'm not sure but I thing more than half calcul are not good. This is a graphical bug. It's not very very serious. But they are more serious. If I press on an atom on the top, and I change the value non stop by mooving my mouse up and down, pd need about 10 seconds for crash. It's can change : 2 second or 1 minutes but always it will crash. if you use a slider who output no interger number it's exactly the same bug. as well If you make a not integer multiplication : 26 * 21.3 = ÿÿ6.7 As well for + and - operator I think they are many other operator who is impact by this bug but I will not test all ------ thanks you very mutch for puredata it's a fantastic programe even if they have some bugs. If I can help you, I'm available... and ... Happy new years ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1863764&group_…

1 0

Re: [PD-dev] [PD] pd-extended 64-bit
by Patrice Colet 04 Jan '08

04 Jan '08

patrick a Ã©crit : > hi, > > i am trying to build pd-extended for 64-bit. > > OSCx > sendOSC.c: In function Â‘sendOSC_settypetagsÂ’: > sendOSC.c:186: warning: cast from pointer to integer of different size > cc -g -O2 -DUNIX -Wall -Wimplicit -Wunused -Wmissing-prototypes -O1 > -I../libOSC -I../../pd/src -I../../../pd/src -I../src -I../libOSC > -I../../pd/src -I../../../pd/src -I../src -c -o htmsocket.o htmsocket.c > htmsocket.c:107: warning: no previous prototype for Â‘IsAddressMulticastÂ’ > cc -g -O2 -DUNIX -Wall -Wimplicit -Wunused -Wmissing-prototypes -O1 > -I../libOSC -I../../pd/src -I../../../pd/src -I../src -I../libOSC > -I../../pd/src -I../../../pd/src -I../src -c -o OSC-system-dependent.o > OSC-system-dependent.c > OSC-system-dependent.c: In function Â‘fatal_errorÂ’: > OSC-system-dependent.c:65: warning: implicit declaration of function Â‘exitÂ’ > OSC-system-dependent.c:65: warning: incompatible implicit declaration of > built-in function Â‘exitÂ’ > cc -Wl,-export_dynamic -shared -o sendOSC.pd_linux sendOSC.o htmsocket.o > OSC-system-dependent.o -L../../../pd/bin -lpd -lc -lm ../libOSC/libOSC.a > /usr/bin/ld: sendOSC.o: relocation R_X86_64_32 against `a local symbol' > can not be used when making a shared object; recompile with -fPIC > sendOSC.o: could not read symbols: Bad value > collect2: ld returned 1 exit status > make[4]: *** [sendOSC.pd_linux] Error 1 > make[4]: Leaving directory `/home/pat/src/pure-data/externals/OSCx/src' > make[3]: *** [all] Error 2 > make[3]: Leaving directory `/home/pat/src/pure-data/externals/OSCx' > make[2]: *** > [/home/pat/src/pure-data/externals/OSCx/src/OSCroute.pd_linux] Error 2 > > > gem2pdp > gcc -export_dynamic -shared -o gem2pdp.pd_linux gem2pdp.o yuv.o -lm > /usr/bin/ld: gem2pdp.o: relocation R_X86_64_32 against `a local symbol' > can not be used when making a shared object; recompile with -fPIC > gem2pdp.o: could not read symbols: Bad value > > > cyclone > /usr/bin/ld: hammer/accum.o: relocation R_X86_64_32 against `a local > symbol' can not be used when making a shared object; recompile with -fPIC > hammer/accum.o: could not read symbols: Bad value > > > pddp > /usr/bin/ld: pddplink.o: relocation R_X86_64_32 against `a local symbol' > can not be used when making a shared object; recompile with -fPIC > pddplink.o: could not read symbols: Bad value > > > toxy > /usr/bin/ld: tot.o: relocation R_X86_64_32 against `a local symbol' can > not be used when making a shared object; recompile with -fPIC > tot.o: could not read symbols: Bad value > > > pidip > /usr/bin/ld: modules/pdp_aging.o: relocation R_X86_64_32 against `a > local symbol' can not be used when making a shared object; recompile > with -fPIC > modules/pdp_aging.o: could not read symbols: Bad value > > > i compiled extended with pd 0.41 test 10 not patched. > the question is: recompile with -fPIC i would like to try it. where > should i modify the Makefile? > pat add -fPIC to the CFLAGS into the makefile of the respective external, and please send the diff to the bug tracker of pd-extended with "diff -uw oldfile newfile > file.diff or wait for the developer to fix this thanks for report, I'll give a try on my ubuntu64 computer

1 0

[ pure-data-Bugs-1863325 ] font bug
by SourceForge.net 03 Jan '08

03 Jan '08

Bugs item #1863325, was opened at 2008-01-03 10:25 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1863325&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: pd-extended Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Hans-Christoph Steiner (eighthave) Summary: font bug Initial Comment: when I run pd the font is good but when I install pd-extended I have a awful font for the consol and for helps It very dificult for read it I run on debian/lenny/testing You can download screenshot of the bug here : http://pazelty.free.fr/fichiers/pd-extended.png on ubuntu I don't have this problem. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1863325&group_…

1 0

[ pure-data-Patches-1670440 ] 8.5 tcl help browser bug
by SourceForge.net 03 Jan '08

03 Jan '08

Patches item #1670440, was opened at 2007-02-27 16:49 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1670440&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix >Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Ivica Ico Bukvic (ico_bukvic) Assigned to: Miller Puckette (millerpuckette) Summary: 8.5 tcl help browser bug Initial Comment: This help browser bug using CVS and tcl/tk 8.5 has been present since at least last fall. After digging through the code, I found the following: proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better # destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else { The comment before "destroy" in effect disables destroying of children widgets and causes errors whenever I have more than one column open and try to click on a column preceding one that is already created. The error reported is that the "listbox1-list already exists" and the only way around is to close the help browser and reopen it. This obviously prevents going up the file tree once a particular subfolder has been opened which obviously means it is a non-lethal bug, but nonetheless annoying. Thus, the "else" clause only affects non 8.5 versions and as such causes pd with tcl/tk 8.5 to be broken. I just checked this out and the 8.4 syntax does work on 8.5 but in the current code it is never accessed due to the existing "if" statement. The new fix simply comments the "if" and "else" statements making the 8.4 style of closing children widgets mandatory for all versions, and since it appears that 8.4 code works fine with tcl/tk 8.5, this appears to be a universal fix for this issue. Please see attached (diff -uw against the fresh CVS checkout). ---------------------------------------------------------------------- >Comment By: SourceForge Robot (sf-robot) Date: 2008-01-02 19:20 Message: Logged In: YES user_id=1312539 Originator: NO This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2007-12-18 14:34 Message: Logged In: YES user_id=313747 Originator: NO I think this one got silently adopted earlier. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1670440&group_…

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pd-dev January 2008