Pd-dev January 2008

pd-dev@lists.iem.at

27 participants
93 discussions

[ pure-data-Patches-1862168 ] [bugfix] makefilename ignores \"%c\"
by SourceForge.net 16 Jan '08

16 Jan '08

Patches item #1862168, was opened at 2008-01-02 14:22 Message generated for change (Settings changed) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862168&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix >Status: Pending Resolution: None Priority: 6 Private: No Submitted By: IOhannes m zmölnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) >Summary: [bugfix] makefilename ignores \"%c\" Initial Comment: the bugfix-#1688540 introduced argument-checking in [makefilename]. unfortunately, the author forgot about the "%c", which is currently the only way to get "weird" characters (like space,...). this breaks quite some patches which depend on that workaround. since there is still no "clean" way to produce symbols with special characters, i'd suggest to include "%c" into the formatting in [makefilename]. attached is a fix, that adds "%c" to the types that request an integer. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2008-01-14 19:40 Message: Logged In: YES user_id=313747 Originator: NO taken. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862168&group_…

1 0

[ pure-data-Patches-1867738 ] [FIX] gensym() should use \"const char*\"
by SourceForge.net 16 Jan '08

16 Jan '08

Patches item #1867738, was opened at 2008-01-09 16:25 Message generated for change (Settings changed) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1867738&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix >Status: Pending Resolution: None Priority: 5 Private: No Submitted By: IOhannes m zmölnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) >Summary: [FIX] gensym() should use \"const char*\" Initial Comment: gensym is currently defined as "t_symbol *gensym(char *s);" this leads to numerous warnings when compiling C++-externals, since C++ treats literals (strings) as "const char*". e.g. gensym("hello"); yields and a warning "warning: deprecated conversion from string constant to 'char*'" the fix for this is simple and makes total sense, since gensym() does not need to modify the passed string. just use: t_symbol *gensym(const char *s); the attached patch does this (it additionally applies the same to the dogensym() function in m_class.c ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2008-01-14 19:38 Message: Logged In: YES user_id=313747 Originator: NO taken. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1867738&group_…

1 0

[ pure-data-Patches-1848295 ] Fix small potential stack overflow
by SourceForge.net 16 Jan '08

16 Jan '08

Patches item #1848295, was opened at 2007-12-11 01:53 Message generated for change (Settings changed) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1848295&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix >Status: Pending Resolution: None Priority: 5 Private: No Submitted By: Russell Bryant (russellbryant) Assigned to: Miller Puckette (millerpuckette) Summary: Fix small potential stack overflow Initial Comment: Attached is a patch to fix another potential stack buffer overflow in s_main.c. I didn't send this over in private because I don't think it can be exploited in any useful way, so it's just a small bug. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2008-01-14 19:45 Message: Logged In: YES user_id=313747 Originator: NO taken. ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2007-12-26 22:45 Message: Logged In: YES user_id=27104 Originator: NO checked into branch-v0-40-extended ---------------------------------------------------------------------- Comment By: Russell Bryant (russellbryant) Date: 2007-12-11 03:41 Message: Logged In: YES user_id=1942915 Originator: YES Also, let me just clarify my original summary just a little bit. You can cause the overrun of the buffer by providing a really long input string to the -schedlib command line option. It's just not exploitable in such a way that it would be considered a security issue. ---------------------------------------------------------------------- Comment By: Russell Bryant (russellbryant) Date: 2007-12-11 03:38 Message: Logged In: YES user_id=1942915 Originator: YES I'm sorry for the stupid typo. That code is actually only compiled in for a Windows build (whenever MSW is defined), so I didn't notice. ---------------------------------------------------------------------- Comment By: Russell Bryant (russellbryant) Date: 2007-12-11 03:36 Message: Logged In: YES user_id=1942915 Originator: YES File Added: filename_overflow.patch2.txt ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2007-12-11 02:18 Message: Logged In: YES user_id=27104 Originator: NO I am guessing there is a typo in that patch, since the new line also uses sprintf() instead of snprintf(): - sprintf(filename, "%s.dll", sys_externalschedlibname); + sprintf(filename, sizeof(filename), "%s.dll", sys_externalschedlibname); ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1848295&group_…

1 0

[ pure-data-Patches-1852385 ] Improve strtokcpy() efficiency, prevent stack overflow
by SourceForge.net 16 Jan '08

16 Jan '08

Patches item #1852385, was opened at 2007-12-17 16:07 Message generated for change (Settings changed) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852385&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix >Status: Pending Resolution: None Priority: 5 Private: No Submitted By: Russell Bryant (russellbryant) Assigned to: Miller Puckette (millerpuckette) Summary: Improve strtokcpy() efficiency, prevent stack overflow Initial Comment: This patch provides a revised implementation of the strtokcpy() function in s_path.c. It provides the following benefits: 1) Prevent potential overflow of a stack buffer. This function did nothing to ensure that it didn't write past the end of the destination buffer. It is possible to cause this to happen by providing certain command line arguments that are longer than MAXPDSTRING. Also, there may be other ways to trigger this bug if namelist_append_files() is used anywhere beyond the uses I reviewed, which are the ones in pd/*.c. 2) Copy bytes from the string in the same loop that looks for the delimiter. This is simply for efficiency in that the string only has to be traversed once, instead of twice (one to find the delimiter, and the second to copy up to it). 3) Document the function using doxygen style tags. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2008-01-14 19:37 Message: Logged In: YES user_id=313747 Originator: NO taken. ---------------------------------------------------------------------- Comment By: Russell Bryant (russellbryant) Date: 2008-01-06 15:39 Message: Logged In: YES user_id=1942915 Originator: YES Checked in to branch-v0-40-extended ---------------------------------------------------------------------- Comment By: Russell Bryant (russellbryant) Date: 2007-12-17 16:07 Message: Logged In: YES user_id=1942915 Originator: YES File Added: strokcpy.txt ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852385&group_…

1 0

[ pure-data-Patches-1842162 ] Fix typo in trigger-help.pd
by SourceForge.net 16 Jan '08

16 Jan '08

Patches item #1842162, was opened at 2007-12-01 06:16 Message generated for change (Settings changed) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1842162&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix >Status: Pending Resolution: None Priority: 5 Private: No Submitted By: Russell Bryant (russellbryant) Assigned to: Miller Puckette (millerpuckette) Summary: Fix typo in trigger-help.pd Initial Comment: Here is a silly tiny patch. In the trigger-help.pd file, there is the object: [trigger float bang symbol list anything] Later, it says that it can be simplified to: [t f b l s a] This patch fixes the typo in the simplified version by changing it to: [t f b s l a] ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2008-01-14 19:42 Message: Logged In: YES user_id=313747 Originator: NO taken. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1842162&group_…

1 0

[ pure-data-Patches-1862148 ] [bugfix] setitimer invalid timeval
by SourceForge.net 16 Jan '08

16 Jan '08

Patches item #1862148, was opened at 2008-01-02 13:41 Message generated for change (Settings changed) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862148&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix >Status: Pending >Resolution: Accepted Priority: 5 Private: No Submitted By: IOhannes m zmölnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) Summary: [bugfix] setitimer invalid timeval Initial Comment: as described by claude in bug#1841758 (https://sourceforge.net/tracker/index.php?func=detail&aid=1841758&group_id=…) there is a small bug in the use of setitimer() in sys_setalarm(). the problem is, that the setitimer() API has changed in order to be POSIX-conformant and Pd has not yet adapated to this change. the attached patch fixes the problem, by splitting the given "microsec" value into seconds and microseconds. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2008-01-14 19:37 Message: Logged In: YES user_id=313747 Originator: NO taken. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862148&group_…

1 0

pd-extended loadlib request
by patrick 15 Jan '08

15 Jan '08

hi hans, would it be possible to add "tof" to default.pdsettings in the auto-build (for mac os x too). pat

1 0

[ pure-data-Bugs-1853216 ] class_set_extern_dir not exported (breaks loaders)
by SourceForge.net 14 Jan '08

14 Jan '08

Bugs item #1853216, was opened at 2007-12-18 08:06 Message generated for change (Comment added) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1853216&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: v0.40.2 Status: Open Resolution: None Priority: 5 Private: No Submitted By: ClaudiusMaximus (claudiusmaximus) Assigned to: Nobody/Anonymous (nobody) Summary: class_set_extern_dir not exported (breaks loaders) Initial Comment: The problem: Help patches for externals loaded by the loader functionality of Pd are not found. They can be found if class_set_extern_dir() is used, but this doesn't work on all platforms (unresolved symbol errors when trying to load the loader). The solution: Declare class_set_extern_dir() in m_pd.h and export it from pd/src/m_class.c or pd/src/s_loader.c . ---------------------------------------------------------------------- >Comment By: Miller Puckette (millerpuckette) Date: 2008-01-14 10:58 Message: Logged In: YES user_id=313747 Originator: NO Did it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1853216&group_…

1 0

[ pure-data-Patches-1848295 ] Fix small potential stack overflow
by SourceForge.net 14 Jan '08

14 Jan '08

Patches item #1848295, was opened at 2007-12-10 16:53 Message generated for change (Comment added) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1848295&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix Status: Open Resolution: None Priority: 5 Private: No Submitted By: Russell Bryant (russellbryant) Assigned to: Miller Puckette (millerpuckette) Summary: Fix small potential stack overflow Initial Comment: Attached is a patch to fix another potential stack buffer overflow in s_main.c. I didn't send this over in private because I don't think it can be exploited in any useful way, so it's just a small bug. ---------------------------------------------------------------------- >Comment By: Miller Puckette (millerpuckette) Date: 2008-01-14 10:45 Message: Logged In: YES user_id=313747 Originator: NO taken. ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2007-12-26 13:45 Message: Logged In: YES user_id=27104 Originator: NO checked into branch-v0-40-extended ---------------------------------------------------------------------- Comment By: Russell Bryant (russellbryant) Date: 2007-12-10 18:41 Message: Logged In: YES user_id=1942915 Originator: YES Also, let me just clarify my original summary just a little bit. You can cause the overrun of the buffer by providing a really long input string to the -schedlib command line option. It's just not exploitable in such a way that it would be considered a security issue. ---------------------------------------------------------------------- Comment By: Russell Bryant (russellbryant) Date: 2007-12-10 18:38 Message: Logged In: YES user_id=1942915 Originator: YES I'm sorry for the stupid typo. That code is actually only compiled in for a Windows build (whenever MSW is defined), so I didn't notice. ---------------------------------------------------------------------- Comment By: Russell Bryant (russellbryant) Date: 2007-12-10 18:36 Message: Logged In: YES user_id=1942915 Originator: YES File Added: filename_overflow.patch2.txt ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2007-12-10 17:18 Message: Logged In: YES user_id=27104 Originator: NO I am guessing there is a typo in that patch, since the new line also uses sprintf() instead of snprintf(): - sprintf(filename, "%s.dll", sys_externalschedlibname); + sprintf(filename, sizeof(filename), "%s.dll", sys_externalschedlibname); ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1848295&group_…

1 0

[ pure-data-Patches-1835093 ] Corrected help patch for [swap]
by SourceForge.net 14 Jan '08

14 Jan '08

Patches item #1835093, was opened at 2007-11-20 03:42 Message generated for change (Comment added) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1835093&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: documentation Status: Open Resolution: None Priority: 5 Private: No Submitted By: Frank Barknecht (fbar) Assigned to: Miller Puckette (millerpuckette) Summary: Corrected help patch for [swap] Initial Comment: As Chuckk Hubbard noted, the help file for[swap] has left and right swapped in some places. Attached is a corrected help patch ready to be dropped in as a replacement with an added example use for swap. ---------------------------------------------------------------------- >Comment By: Miller Puckette (millerpuckette) Date: 2008-01-14 10:44 Message: Logged In: YES user_id=313747 Originator: NO taken. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1835093&group_…

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pd-dev January 2008