Patches item #1820929, was opened at 2007-10-26 13:42
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1820929&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: documentation
Status: Open
Resolution: None
Priority: 3
Private: No
Submitted By: Frank Barknecht (fbar)
Assigned to: Miller Puckette (millerpuckette)
Summary: Pd-patch to explain loops
Initial Comment:
It occured to me that no file in doc/2.control.examples/ explains looping, although this is an important basic technique every aspiring Pd user should learn. Attached is a Pd patch in the style of the other control examples which introduces looping with [until] in a basic fashion.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 09:31
Message:
Logged In: YES
user_id=313747
Originator: NO
I edited it up a bit and added it.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1820929&group_…
Patches item #1819265, was opened at 2007-10-24 05:17
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1819265&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: print~ can only print dsp-blocks which are 2^n
Initial Comment:
[print~] is not able to print dsp-blocks which are non 2^n-sized correctly.
this is not a problem as long as Pd can only handle 2^n blocks.
however, miller has mentioned, that this restriction should fall in the near future (though in the CVS version of the upcoming 0.41 this restriction still applies)
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 09:11
Message:
Logged In: YES
user_id=313747
Originator: NO
taken. My bad, the original code was stupid.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2007-10-24 05:19
Message:
Logged In: YES
user_id=564396
Originator: YES
the attached patch makes [print~] handle blocksizes of any lengths.
it might be slower than the original version, but:
- who cares about speed in a function like [print~] that is slow per se.
- it reduces the number of lines of code by 5
File Added: print_tilde.patch
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1819265&group_…
Patches item #1810576, was opened at 2007-10-09 22:19
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1810576&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: better support for opening HTML/URLs on GNU/Linux
Initial Comment:
This patch adds a number of better commands for opening HTML files and URLs on GNU/Linux. These commands use the defaults systems, plus each command is tested before executed, so it should be more fault tolerant.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 09:08
Message:
Logged In: YES
user_id=313747
Originator: NO
Taken
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-10-17 10:46
Message:
Logged In: YES
user_id=27104
Originator: YES
Fixed bug when directly launching the browser, rather than via an "open"
command.
File Added: better_html_url_handling_on_linux-0.40.3.patch
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1810576&group_…
Patches item #1796223, was opened at 2007-09-17 06:49
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1796223&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 2
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: BUG: html-syntax error (link)
Initial Comment:
in x2.html the reference to the "Theory and Techniques of Electronic Music" lacks a closing </a> tag, resulting in weird rendering of the html on some browsers (e.g. konqueror)
the attached patch fixes this....
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 09:05
Message:
Logged In: YES
user_id=313747
Originator: NO
Took it.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1796223&group_…
Patches item #1776891, was opened at 2007-08-18 07:03
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1776891&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 2
Private: No
Submitted By: Matteo Sisti Sette (sistisette)
Assigned to: Miller Puckette (millerpuckette)
Summary: BUG; [until] hangs if started with a negative number
Initial Comment:
If you send a negative number to an [until] object, it behaves as if you sent it a bang: i.e., it iterates an infinite number of times (unless a bang is received in the right inlet stopping the iterations).
Instead, it should either treat a negative number as zero, or generate an error message when it receive a negative number.
The documentation (i.e. help patch) says:
"If you start "until" with a number, it iterates at most that number of times".
Though "iterating at most -21 times" means nothing strictly speaking, it would make much more sense if it didn't iterate at all.
Also, it would be a warranty that sending it a number would never ever cause an infinite loop.
You may argue that sending [until] a [-21( is like writing:
for (int i=0; i<-21; i++)
which produces an infinite loop.
However, that's not the way [until] is described in the documentation. No initialization, testing condition and increment are mentioned.
So it should rather be compared to languages where a for loop looks like:
for i = M to N
In such languages, using M>N *usually* produces either a decrementing i or no iteration at all.
Finally, if one actually does want an infinite loop (obviously taking care of using the right inlet to stop it) s/he can do it with a [bang( message.
Obviously this is a minor issue, as one can always put a [max 0] before [until]
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 09:04
Message:
Logged In: YES
user_id=313747
Originator: NO
I think I prefer to silently replace teh negative number by zero...
that's more in keeping with the way Pd usually reacts for out-
of-range numerical args. Should be fixed in upcoming commit.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2007-09-17 06:05
Message:
Logged In: YES
user_id=564396
Originator: NO
obviously the fix is trivial, i have attached a unified diff that reports
an error for negative values and refuses to perform.
File Added: until_negative.diff
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1776891&group_…
Patches item #1775023, was opened at 2007-08-15 15:35
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1775023&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: use Tcl's normalize to clean up pd_guidir on OSX and Win32
Initial Comment:
A minor cleanup to simplify pd_guidir using Tcl's [file normalize] on Mac OS X and Win32.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 09:01
Message:
Logged In: YES
user_id=313747
Originator: NO
"file normalize" seems to be newer than at least one Tk I'm running.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1775023&group_…
Patches item #1767751, was opened at 2007-08-04 14:19
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1767751&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Klaus Heinz (kheinz)
Assigned to: Miller Puckette (millerpuckette)
Summary: BUG: switch == to = in configure.in for strict sh compat
Initial Comment:
Hi,
configure.in (and configure) contains unportable shell
syntax.
The declared shell for configure, /bin/sh,
is not always a link to bash or ksh, which both support
== in comparisons. The original syntax for /bin/sh
only accepts = as comparison operator.
The appended fix changes == to =.
ciao
Klaus Heinz
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 08:57
Message:
Logged In: YES
user_id=313747
Originator: NO
Yay. Adopted.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-10-22 18:26
Message:
Logged In: YES
user_id=27104
Originator: NO
File Added: switch_to_=_for_strict_sh_compatibility-0.41-test06.patch
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2007-09-18 02:29
Message:
Logged In: YES
user_id=564396
Originator: NO
moved to "patches" section, to indicate that there is a fix for the
problem
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1767751&group_…
Patches item #1844492, was opened at 2007-12-04 16:00
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1844492&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: improved makefile.dependencies generation
Initial Comment:
This patch started with a bug in the MinGW build and then a suggestion from Russell Bryant. In addition to adding this patch, "pd/src/makefile.dependencies" should be removed from CVS.
Basically, this patch monitors $(SRC) and the newly created $(HEADERS) for changes, and if any of those files change, then makefile.dependencies is regenerated (this is still leaving out the portaudio headers).
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 08:54
Message:
Logged In: YES
user_id=313747
Originator: NO
How does this not break the line, "include makefile.dependencies" in
makefile?
That's the reason the empty makefile.dependencies file is in CVS. Of
course,
I'd prefer something better than what's there now.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1844492&group_…
Patches item #1852385, was opened at 2007-12-17 09:07
Message generated for change (Comment added) made by russellbryant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852385&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Russell Bryant (russellbryant)
Assigned to: Nobody/Anonymous (nobody)
Summary: Improve strtokcpy() efficiency, prevent stack overflow
Initial Comment:
This patch provides a revised implementation of the strtokcpy() function in s_path.c. It provides the following benefits:
1) Prevent potential overflow of a stack buffer. This function did nothing to ensure that it didn't write past the end of the destination buffer.
It is possible to cause this to happen by providing certain command line arguments that are longer than MAXPDSTRING. Also, there may be other ways to trigger this bug if namelist_append_files() is used anywhere beyond the uses I reviewed, which are the ones in pd/*.c.
2) Copy bytes from the string in the same loop that looks for the delimiter. This is simply for efficiency in that the string only has to be traversed once, instead of twice (one to find the delimiter, and the second to copy up to it).
3) Document the function using doxygen style tags.
----------------------------------------------------------------------
>Comment By: Russell Bryant (russellbryant)
Date: 2007-12-17 09:07
Message:
Logged In: YES
user_id=1942915
Originator: YES
File Added: strokcpy.txt
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852385&group_…
Patches item #1852385, was opened at 2007-12-17 09:07
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852385&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Russell Bryant (russellbryant)
Assigned to: Nobody/Anonymous (nobody)
Summary: Improve strtokcpy() efficiency, prevent stack overflow
Initial Comment:
This patch provides a revised implementation of the strtokcpy() function in s_path.c. It provides the following benefits:
1) Prevent potential overflow of a stack buffer. This function did nothing to ensure that it didn't write past the end of the destination buffer.
It is possible to cause this to happen by providing certain command line arguments that are longer than MAXPDSTRING. Also, there may be other ways to trigger this bug if namelist_append_files() is used anywhere beyond the uses I reviewed, which are the ones in pd/*.c.
2) Copy bytes from the string in the same loop that looks for the delimiter. This is simply for efficiency in that the string only has to be traversed once, instead of twice (one to find the delimiter, and the second to copy up to it).
3) Document the function using doxygen style tags.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852385&group_…