Patches item #1670440, was opened at 2007-02-28 01:49
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1670440&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Pending
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Ivica Ico Bukvic (ico_bukvic)
Assigned to: Miller Puckette (millerpuckette)
Summary: 8.5 tcl help browser bug
Initial Comment:
This help browser bug using CVS and tcl/tk 8.5 has been present since at least last fall. After digging through the code, I found the following:
proc doc_make_listbox {base dir count} {
# check for [file readable]?
if { [info tclversion] >= 8.5 } {
# requires Tcl 8.5 but probably deals with special chars better
# destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end]
} else {
The comment before "destroy" in effect disables destroying of children widgets and causes errors whenever I have more than one column open and try to click on a column preceding one that is already created. The error reported is that the "listbox1-list already exists" and the only way around is to close the help browser and reopen it. This obviously prevents going up the file tree once a particular subfolder has been opened which obviously means it is a non-lethal bug, but nonetheless annoying.
Thus, the "else" clause only affects non 8.5 versions and as such causes pd with tcl/tk 8.5 to be broken.
I just checked this out and the 8.4 syntax does work on 8.5 but in the current code it is never accessed due to the existing "if" statement. The new fix simply comments the "if" and "else" statements making the 8.4 style of closing children widgets mandatory for all versions, and since it appears that 8.4 code works fine with tcl/tk 8.5, this appears to be a universal fix for this issue.
Please see attached (diff -uw against the fresh CVS checkout).
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-18 23:34
Message:
Logged In: YES
user_id=313747
Originator: NO
I think this one got silently adopted earlier.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1670440&group_…
Patches item #1822010, was opened at 2007-10-29 03:24
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1822010&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: hardcoded sample-type in soundfile-IO
Initial Comment:
the current implementation in d_soundfile.c assumes that both t_sample and t_float are "float".
this is not necessarily true.
additionally it assumes that typeof(t_sample) and typeof(t_float) are identically.
this is not necessarily true.
based on the assumption that (number)arrays are of type t_float and signals are of type t_sample, the attached patch provides 2 extra functions for xferin/xferout that use different types for reading/writing soundfiles.
basically it provides:
soundfile_xferin_sample() (reading soundfile to signal)
soundfile_xferin_float() (reading soundfile to table)
soundfile_xferout_sample() (writing soundfile from signal)
soundfile_xferout_float() (writing soundfile from table)
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-18 14:56
Message:
Logged In: YES
user_id=313747
Originator: NO
taken.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1822010&group_…
Patches item #1822007, was opened at 2007-10-29 03:19
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1822007&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: hardcoded sample-type in jack-transport
Initial Comment:
in s_audio_jack.c the sample-type of the jack transportlayer is assumed to be "float", which is a naive assumption.
the correct type is "jack_default_audio_sample_t" (which might be either "float" or "double", depending on how jack was compiled)
the attached patch respects the type-definition of both jack and pd's own t_sample.
when the 2 types are the same, it just does a memcpy (this is similar as before, where it is assumed that both jack and pd use "float" internally)
when they are different, it copies the data manually.
LATER: improve the heuristic for finding out whether the two types are equal (currently only the sizeof() is checked)
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-18 14:56
Message:
Logged In: YES
user_id=313747
Originator: NO
taken.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1822007&group_…
Patches item #1752248, was opened at 2007-07-11 14:53
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1752248&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: cmd-click manipulates GUIs on Mac OS X
Initial Comment:
This patch just makes Cmd-Click do exactly what Ctrl-Click does on the other platforms. It's a one liner...
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-18 14:41
Message:
Logged In: YES
user_id=313747
Originator: NO
taken.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1752248&group_…
Patches item #1738289, was opened at 2007-06-16 03:06
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1738289&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: Fixed
Priority: 3
Private: No
Submitted By: Frank Barknecht (fbar)
Assigned to: Miller Puckette (millerpuckette)
Summary: BUG: "View list" listview broken for arrays with $0 in name
Initial Comment:
The "View list" function in the Properties context menu of arrays is broken, if the name of the array contains a $0. This only affects visible arrays in graphs, arrays in [table] objects work correctly with $0-names.
See attached test patch for a demonstration.
The error message given by Tk is:
can't read "0": no such variable
can't read "0": no such variable
while executing
"array_viewlist .gfxstub82e3a78 $0-array 0"
invoked from within
".gfxstub82e3a78.listview invoke"
("uplevel" body line 1)
invoked from within
"uplevel #0 [list $w invoke]"
(procedure "tk::ButtonUp" line 22)
invoked from within
"tk::ButtonUp .gfxstub82e3a78.listview"
(command bound to event)
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-18 14:39
Message:
Logged In: YES
user_id=313747
Originator: NO
taken.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2007-09-18 02:30
Message:
Logged In: YES
user_id=564396
Originator: NO
moved to "patches" section, to indicate that there is a fix for the
problem
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2007-09-17 05:23
Message:
Logged In: YES
user_id=564396
Originator: NO
btw, the bug appeared with all uses of $args (e.g. $1-table is as bad as
$0-array)
however, the tiny attached diff (against todays cvs of 0.41) fixes this
bug by removing unneeded variables.
File Added: array_viewlist.diff
----------------------------------------------------------------------
Comment By: Frank Barknecht (fbar)
Date: 2007-06-18 02:09
Message:
Logged In: YES
user_id=569446
Originator: YES
Please don't use spaces in filenames here, their names get mangled by
Sourceforge. I deleted the new example patch to not confuse readers. I
think the first example I posted already was illustrating the bug
sufficiently.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-06-17 09:49
Message:
Logged In: YES
user_id=27104
Originator: NO
Yup, same for me on Mac OS X 10.4.9 using Pd-0.39.2-extended-rc4 and Pd
0.40-2.
File Added: array with dollar zero.pd
----------------------------------------------------------------------
Comment By: Frank Barknecht (fbar)
Date: 2007-06-17 02:14
Message:
Logged In: YES
user_id=569446
Originator: YES
It seems any version is affected.
I tested with CVS HEAD (0.4x) and pd-ext 0.39 rc-2.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-06-16 18:31
Message:
Logged In: YES
user_id=27104
Originator: NO
Which version of Pd? I hope it's not my bug ;) The version can be set in
the "Group" pulldown menu in the bug report form.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1738289&group_…
Patches item #1688540, was opened at 2007-03-26 09:33
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1688540&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Stephen Sinclair (radarsat1)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix makefilename segfault when wrong argument type received
Initial Comment:
Currently, Pd segfaults if the "makefilename" object is configured to receive a symbol ("%s") and it receives a float argument.
This patch uses strstr() to check if the sprintf string is going to accept a float, like so:
strstr(s->s_name, "%s")==0
The result is saved in the t_makefilename structure. It is recalculated on the "set" message.
When the wrong message type is received, a 0 or "" string is substituted, respectfully.
While it is unfortunate to do a string search like this, it is not very good to have Pd segfaulting, so I see no alternative.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-18 14:36
Message:
Logged In: YES
user_id=313747
Originator: NO
taken.
----------------------------------------------------------------------
Comment By: Stephen Sinclair (radarsat1)
Date: 2007-07-30 18:21
Message:
Logged In: YES
user_id=616837
Originator: YES
Deleting original patch as requested.
pd-cvs-makefilename-20070326.patch is replaced by
makefilename_scanformat.patch
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-07-30 18:04
Message:
Logged In: YES
user_id=27104
Originator: NO
Does this new patch replace pd-cvs-makefilename-20070326.patch? If so,
pd-cvs-makefilename-20070326.patch should be deleted from this tracker.
I committed it to packages/patches so it'll be automatically included in
the Pd-0.40.3-extended nightly builds.
----------------------------------------------------------------------
Comment By: Stephen Sinclair (radarsat1)
Date: 2007-07-30 11:23
Message:
Logged In: YES
user_id=616837
Originator: YES
Attached is a more complete patch scanning the symbol argument more
thoroughly for sprintf-compatible formatting. Also now differentiates
between float and int arguments, and supports format flags. Could probably
be extended to support multiple arguments.
This patch also stops makefilename from spitting out (null) symbols.
Patch generated with "diff -uw x_connective.c"
File Added: makefilename_scanformat.patch
----------------------------------------------------------------------
Comment By: Stephen Sinclair (radarsat1)
Date: 2007-07-30 11:19
Message:
Logged In: YES
user_id=616837
Originator: YES
File Added: makefilename_crash.pd
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-07-29 16:50
Message:
Logged In: YES
user_id=313747
Originator: NO
It would take more work to do it right: check that
there's only one "%f" and no "%s" or vice versa,
and further check for "%%f", etc... I figure on
doing this someday if nobody else does.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-06-14 08:11
Message:
Logged In: YES
user_id=27104
Originator: NO
I applied this patch to the Pd-0.39.2-extended branch and it failed to
compile:
x_connective.c: In function 'makefilename_new':
x_connective.c:1213: error: 'struct _makefilename' has no member named
'x_accept_float'
x_connective.c: In function 'makefilename_float':
x_connective.c:1219: error: 'struct _makefilename' has no member named
'x_accept_float'
x_connective.c: In function 'makefilename_symbol':
x_connective.c:1229: error: 'struct _makefilename' has no member named
'x_accept_float'
x_connective.c: In function 'makefilename_set':
x_connective.c:1239: error: 'struct _makefilename' has no member named
'x_accept_float'
My guess is that the patch needs to be a "diff -uw" format, which is much
better at dealing with different line numbers, etc.
Also, an example patch to demonstrate the bug is always useful.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1688540&group_…
Patches item #1670440, was opened at 2007-02-27 16:49
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1670440&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ivica Ico Bukvic (ico_bukvic)
Assigned to: Miller Puckette (millerpuckette)
Summary: 8.5 tcl help browser bug
Initial Comment:
This help browser bug using CVS and tcl/tk 8.5 has been present since at least last fall. After digging through the code, I found the following:
proc doc_make_listbox {base dir count} {
# check for [file readable]?
if { [info tclversion] >= 8.5 } {
# requires Tcl 8.5 but probably deals with special chars better
# destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end]
} else {
The comment before "destroy" in effect disables destroying of children widgets and causes errors whenever I have more than one column open and try to click on a column preceding one that is already created. The error reported is that the "listbox1-list already exists" and the only way around is to close the help browser and reopen it. This obviously prevents going up the file tree once a particular subfolder has been opened which obviously means it is a non-lethal bug, but nonetheless annoying.
Thus, the "else" clause only affects non 8.5 versions and as such causes pd with tcl/tk 8.5 to be broken.
I just checked this out and the 8.4 syntax does work on 8.5 but in the current code it is never accessed due to the existing "if" statement. The new fix simply comments the "if" and "else" statements making the 8.4 style of closing children widgets mandatory for all versions, and since it appears that 8.4 code works fine with tcl/tk 8.5, this appears to be a universal fix for this issue.
Please see attached (diff -uw against the fresh CVS checkout).
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-18 14:34
Message:
Logged In: YES
user_id=313747
Originator: NO
I think this one got silently adopted earlier.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1670440&group_…
Bugs item #1359216, was opened at 2005-11-17 19:14
Message generated for change (Comment added) made by claudiusmaximus
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1359216&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: printing open bracket { (ASCII123) freezes gui
Initial Comment:
On WinXP and Miller's pd039_test7 typing '{' (ascii
123) after print in an object box hangs the gui,
apparently because the tcl is waiting for a closing '}'
before proceeding.
In the source code, dopost() in s_print.c, it looks
like four characters are escaped: '\', '{', '}', and ';'.
But if they are escaped they should not freeze the gui...
static void dopost(const char *s)
{
...
if (c == '\\' || c == '{' || c == '}' || c
== ';') <- if it's a dangerous character for tcl
upbuf[ptout++] = '\\'; <- add a
backslash before the dangerous character
upbuf[ptout] = s[ptin]; <- then put the
character
...
sys_vgui("pdtk_post {%s}\n", upbuf); <- then
send it to tcl interpreter
If I try entering them in a print box I get different
results. '\' and '}' are rejected:
\}: dropped
\\: dropped
';' is accepted
'{' freezes the gui.
In g_editor.c:
void canvas_key(t_canvas *x, t_symbol *s, int ac,
t_atom *av)
{
...
if (keynum == '\\' || keynum == '{' || keynum ==
'}') <-a dangerous character
{
post("%c: dropped", (int)keynum); <-should be
dropped, but for '{' this doesn't get printed
return;
}
...dopost() is called from post() so '{' is causing
trouble even when it is escaped with a backslash.
Submitted by Martin Peach
martinrp(a)vax2.condordia.ca
----------------------------------------------------------------------
Comment By: ClaudiusMaximus (claudiusmaximus)
Date: 2007-12-18 16:10
Message:
Logged In: YES
user_id=769033
Originator: NO
This bug is still present in pd-0.40-3.
I noticed it when pdlua tried to print a "syntax error" message containing
Lua source code on a line containing '{'.
----------------------------------------------------------------------
Comment By: ClaudiusMaximus (claudiusmaximus)
Date: 2006-05-02 11:17
Message:
Logged In: YES
user_id=769033
In pd-0.39-2, typing { in a new object box hangs pd-gui
until you type a corresponding }, at which point the
following is printed in the console:
\{: dropped
\{: dropped
\}: dropped
\}: dropped
The text typed (exclusively) between { and } is entered into
the object box when the } is typed, too.
----------------------------------------------------------------------
Comment By: Thomas Grill (xovo)
Date: 2005-12-07 01:49
Message:
Logged In: YES
user_id=350252
second:
it's pretty clear that the bug must be in the socket
receiver code for pd.tk inside t_tkcmd.c. In pd_readsocket
starting with line 168 it says:
/* search for locations that terminate a complete TK
command. These are carriage returns which are not inside
any braces. Braces can be escaped with backslashes (but
backslashes themselves can't.) */
When a "{: dropped" post comes in, the code in pd_readsocket
must get confused because a brace is opened but none closed.
There's no command-delimiting newline character found in
that case.
----------------------------------------------------------------------
Comment By: Thomas Grill (xovo)
Date: 2005-12-07 01:08
Message:
Logged In: YES
user_id=350252
first, Matju 's fixes for the dopost function in s_print.c
static void dopost(const char *s)
{
if (sys_printhook)
(*sys_printhook)(s);
else if (sys_printtostderr)
fprintf(stderr, "%s", s);
else
{
char upbuf[MAXPDSTRING];
int i,j=0;
for(i=0; s[i] && j<MAXPDSTRING-16; i++)
{
if (strchr("\\\"[]$\n",s[i])) upbuf[j++]='\\';
if (s[i]=='\n') upbuf[j++]='n';
else upbuf[j++] = s[i];
}
upbuf[j] = 0;
sys_vgui("pdtk_post \"%s\"\n",upbuf);
}
}
----------------------------------------------------------------------
Comment By: Mathieu Bouchard (matju)
Date: 2005-12-03 06:57
Message:
Logged In: YES
user_id=801174
fixed in DesireData today.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1359216&group_…
Bugs item #1853216, was opened at 2007-12-18 16:06
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1853216&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: v0.40.2
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: ClaudiusMaximus (claudiusmaximus)
Assigned to: Nobody/Anonymous (nobody)
Summary: class_set_extern_dir not exported (breaks loaders)
Initial Comment:
The problem:
Help patches for externals loaded by the loader functionality of Pd are not found.
They can be found if class_set_extern_dir() is used, but this doesn't work on all platforms (unresolved symbol errors when trying to load the loader).
The solution:
Declare class_set_extern_dir() in m_pd.h and export it from pd/src/m_class.c or pd/src/s_loader.c .
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1853216&group_…
Patches item #1551815, was opened at 2006-09-04 10:05
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1551815&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: oskude (oskude)
Assigned to: Miller Puckette (millerpuckette)
Summary: align control checkboxes to left
Initial Comment:
"-anchor w" in checkbutton doesnt have any effect.
moved to pack, so they aligh to the left...
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-18 05:18
Message:
Logged In: YES
user_id=313747
Originator: NO
took it.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2006-09-16 19:04
Message:
Logged In: YES
user_id=27104
Nice little detail. I added to the Pd-extended build system
as
pure-data/packages/patches/pd_controls-anchor-fix-0.40-pre.patch
It will be in the nightly builds starting tomorrow.
----------------------------------------------------------------------
Comment By: oskude (oskude)
Date: 2006-09-15 10:06
Message:
Logged In: YES
user_id=1383707
[snip]
checkbutton .controls.switches.audiobutton -text {compute
audio} \
-variable ctrls_audio_on \
-anchor w \
-command {pd [concat pd dsp $ctrls_audio_on \;]}
checkbutton .controls.switches.meterbutton -text {peak meters} \
-variable ctrls_meter_on \
-anchor w \
-command {pd [concat pd meters $ctrls_meter_on \;]}
pack .controls.switches.audiobutton
.controls.switches.meterbutton -side top
[snip]
looks like this:
[ ] compute audio
[ ] peak meters
as you see, -anchor -w doesnt have any effect when used in
checkbutton, they are not aligned to left(w:west)
so changing to this:
[snip]
checkbutton .controls.switches.audiobutton -text {compute
audio} \
-variable ctrls_audio_on \
-command {pd [concat pd dsp $ctrls_audio_on \;]}
checkbutton .controls.switches.meterbutton -text {peak meters} \
-variable ctrls_meter_on \
-command {pd [concat pd meters $ctrls_meter_on \;]}
pack .controls.switches.audiobutton
.controls.switches.meterbutton -side top \
-anchor w
[snip]
looks like this:
[ ] compute audio
[ ] peak meters
using -anchor w in pack aligns the checkbuttons to left...
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2006-09-13 21:25
Message:
Logged In: YES
user_id=27104
can you elaborate on what this patch does?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1551815&group_…