Patches item #1852139, was opened at 2007-12-17 07:52
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852139&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pd-extended
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix in extra/markex/tripleRand-help.pd
Initial Comment:
As of '07 12/17, the help file for extra/markex/tripleRand-help.pd
was demonstrating arguments of an incorrect format being passed to the right inlet, resulting in showing an error message.
The posted file maybe rather suitable.
--
David Shimamoto
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2007-12-17 21:33
Message:
Logged In: YES
user_id=564396
Originator: NO
i rather fixed the bug that triggered the "incorrect format" error.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852139&group_…
Patches item #1820929, was opened at 2007-10-26 22:42
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1820929&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: documentation
>Status: Closed
>Resolution: Accepted
Priority: 3
Private: No
Submitted By: Frank Barknecht (fbar)
Assigned to: Miller Puckette (millerpuckette)
Summary: Pd-patch to explain loops
Initial Comment:
It occured to me that no file in doc/2.control.examples/ explains looping, although this is an important basic technique every aspiring Pd user should learn. Attached is a Pd patch in the style of the other control examples which introduces looping with [until] in a basic fashion.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 18:31
Message:
Logged In: YES
user_id=313747
Originator: NO
I edited it up a bit and added it.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1820929&group_…
Patches item #1836228, was opened at 2007-11-22 05:37
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
>Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Russell Bryant (russellbryant)
Assigned to: Miller Puckette (millerpuckette)
Summary: [patch] simplify pd_makeversion() in src/s_main.c
Initial Comment:
This minor patch simplifies the pd_makeversion() function in src/s_main.c.
It replaces the sprintf / malloc / strcpy, with the equivalent single call to asprintf. It also provides the side benefit of removing the length limitation introduced by the intermediary stack buffer (with bounds that weren't being checked).
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-23 20:24
Message:
Logged In: YES
user_id=27104
Originator: NO
Funny, I originally submitted the patch with this function and it included
asprintf(). Miller accepted the patch, but replaced the asprintf() with
the sprintf/malloc/strcpy combo, with only this comment:
"modified to avoid the effete asprintf() call, then took for 0.40"
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_…
Patches item #1819265, was opened at 2007-10-24 14:17
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1819265&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
>Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: print~ can only print dsp-blocks which are 2^n
Initial Comment:
[print~] is not able to print dsp-blocks which are non 2^n-sized correctly.
this is not a problem as long as Pd can only handle 2^n blocks.
however, miller has mentioned, that this restriction should fall in the near future (though in the CVS version of the upcoming 0.41 this restriction still applies)
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 18:11
Message:
Logged In: YES
user_id=313747
Originator: NO
taken. My bad, the original code was stupid.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2007-10-24 14:19
Message:
Logged In: YES
user_id=564396
Originator: YES
the attached patch makes [print~] handle blocksizes of any lengths.
it might be slower than the original version, but:
- who cares about speed in a function like [print~] that is slow per se.
- it reduces the number of lines of code by 5
File Added: print_tilde.patch
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1819265&group_…
Patches item #1776891, was opened at 2007-08-18 16:03
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1776891&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 2
Private: No
Submitted By: Matteo Sisti Sette (sistisette)
Assigned to: Miller Puckette (millerpuckette)
Summary: BUG; [until] hangs if started with a negative number
Initial Comment:
If you send a negative number to an [until] object, it behaves as if you sent it a bang: i.e., it iterates an infinite number of times (unless a bang is received in the right inlet stopping the iterations).
Instead, it should either treat a negative number as zero, or generate an error message when it receive a negative number.
The documentation (i.e. help patch) says:
"If you start "until" with a number, it iterates at most that number of times".
Though "iterating at most -21 times" means nothing strictly speaking, it would make much more sense if it didn't iterate at all.
Also, it would be a warranty that sending it a number would never ever cause an infinite loop.
You may argue that sending [until] a [-21( is like writing:
for (int i=0; i<-21; i++)
which produces an infinite loop.
However, that's not the way [until] is described in the documentation. No initialization, testing condition and increment are mentioned.
So it should rather be compared to languages where a for loop looks like:
for i = M to N
In such languages, using M>N *usually* produces either a decrementing i or no iteration at all.
Finally, if one actually does want an infinite loop (obviously taking care of using the right inlet to stop it) s/he can do it with a [bang( message.
Obviously this is a minor issue, as one can always put a [max 0] before [until]
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 18:04
Message:
Logged In: YES
user_id=313747
Originator: NO
I think I prefer to silently replace teh negative number by zero...
that's more in keeping with the way Pd usually reacts for out-
of-range numerical args. Should be fixed in upcoming commit.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2007-09-17 15:05
Message:
Logged In: YES
user_id=564396
Originator: NO
obviously the fix is trivial, i have attached a unified diff that reports
an error for negative values and refuses to perform.
File Added: until_negative.diff
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1776891&group_…
Patches item #1810576, was opened at 2007-10-10 07:19
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1810576&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: better support for opening HTML/URLs on GNU/Linux
Initial Comment:
This patch adds a number of better commands for opening HTML files and URLs on GNU/Linux. These commands use the defaults systems, plus each command is tested before executed, so it should be more fault tolerant.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 18:08
Message:
Logged In: YES
user_id=313747
Originator: NO
Taken
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-10-17 19:46
Message:
Logged In: YES
user_id=27104
Originator: YES
Fixed bug when directly launching the browser, rather than via an "open"
command.
File Added: better_html_url_handling_on_linux-0.40.3.patch
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1810576&group_…
Patches item #1767751, was opened at 2007-08-04 23:19
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1767751&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Klaus Heinz (kheinz)
Assigned to: Miller Puckette (millerpuckette)
Summary: BUG: switch == to = in configure.in for strict sh compat
Initial Comment:
Hi,
configure.in (and configure) contains unportable shell
syntax.
The declared shell for configure, /bin/sh,
is not always a link to bash or ksh, which both support
== in comparisons. The original syntax for /bin/sh
only accepts = as comparison operator.
The appended fix changes == to =.
ciao
Klaus Heinz
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 17:57
Message:
Logged In: YES
user_id=313747
Originator: NO
Yay. Adopted.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-10-23 03:26
Message:
Logged In: YES
user_id=27104
Originator: NO
File Added: switch_to_=_for_strict_sh_compatibility-0.41-test06.patch
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2007-09-18 11:29
Message:
Logged In: YES
user_id=564396
Originator: NO
moved to "patches" section, to indicate that there is a fix for the
problem
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1767751&group_…
Patches item #1822943, was opened at 2007-10-30 19:27
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1822943&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 9
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: hexloader code security issue
Initial Comment:
the hexmunge code in s_loader.c exposes a security hole:
s_loader:127 reads:
memmove(symname+6, symname, strlen(symname+1));
but really it should read:
memmove(symname+6, symname, strlen(symname)+1);
the code tries to copy the \0 character, but fails to do so (because the strlen(+1) returns to few bytes to be copied), which results in garbage in the symname after the memmove.
since this bug is a real security hole, i give it a high priority
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2007-12-17 21:17
Message:
Logged In: YES
user_id=564396
Originator: YES
seems to be accepted in the latest and greatest 0.41 testrelease
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2007-10-30 20:05
Message:
Logged In: YES
user_id=564396
Originator: YES
like any other buffer overflow (i think)
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2007-10-30 19:52
Message:
Logged In: NO
if this is a real security hole, then how would anyone exploit it?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1822943&group_…
Patches item #1844492, was opened at 2007-12-05 01:00
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1844492&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Open
>Resolution: None
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: improved makefile.dependencies generation
Initial Comment:
This patch started with a bug in the MinGW build and then a suggestion from Russell Bryant. In addition to adding this patch, "pd/src/makefile.dependencies" should be removed from CVS.
Basically, this patch monitors $(SRC) and the newly created $(HEADERS) for changes, and if any of those files change, then makefile.dependencies is regenerated (this is still leaving out the portaudio headers).
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2007-12-17 21:16
Message:
Logged In: YES
user_id=564396
Originator: NO
(oops, incidentally closed...)
make can handle dependencies pretty well, even if there is no
makefile.dependencies yet for inclusion.
the secret is, that make will iterate several times over a makefile in
order to get dependencies right.
that is: when running make it will try to "-include makefile.dependencies"
(the "-" is there to prevent a fatal error because of the missing
makefile), and fail (because of the missing makefile), than it will find a
rule to build the makefile and run it (generating the
makefile.dependencies); then it will re-run itself, include the
makefile.dependencies and thus get the dependencies right.
this is almost the canonical way to use dependencies with make.
the gnu make manual suggest to split the dependencies into several files
(one per c-file)
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 17:54
Message:
Logged In: YES
user_id=313747
Originator: NO
How does this not break the line, "include makefile.dependencies" in
makefile?
That's the reason the empty makefile.dependencies file is in CVS. Of
course,
I'd prefer something better than what's there now.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1844492&group_…
Patches item #1844492, was opened at 2007-12-05 01:00
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1844492&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: improved makefile.dependencies generation
Initial Comment:
This patch started with a bug in the MinGW build and then a suggestion from Russell Bryant. In addition to adding this patch, "pd/src/makefile.dependencies" should be removed from CVS.
Basically, this patch monitors $(SRC) and the newly created $(HEADERS) for changes, and if any of those files change, then makefile.dependencies is regenerated (this is still leaving out the portaudio headers).
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 17:54
Message:
Logged In: YES
user_id=313747
Originator: NO
How does this not break the line, "include makefile.dependencies" in
makefile?
That's the reason the empty makefile.dependencies file is in CVS. Of
course,
I'd prefer something better than what's there now.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1844492&group_…