Patches item #1670440, was opened at 2007-02-27 16:49
Message generated for change (Comment added) made by sf-robot
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1670440&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Ivica Ico Bukvic (ico_bukvic)
Assigned to: Miller Puckette (millerpuckette)
Summary: 8.5 tcl help browser bug
Initial Comment:
This help browser bug using CVS and tcl/tk 8.5 has been present since at least last fall. After digging through the code, I found the following:
proc doc_make_listbox {base dir count} {
# check for [file readable]?
if { [info tclversion] >= 8.5 } {
# requires Tcl 8.5 but probably deals with special chars better
# destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end]
} else {
The comment before "destroy" in effect disables destroying of children widgets and causes errors whenever I have more than one column open and try to click on a column preceding one that is already created. The error reported is that the "listbox1-list already exists" and the only way around is to close the help browser and reopen it. This obviously prevents going up the file tree once a particular subfolder has been opened which obviously means it is a non-lethal bug, but nonetheless annoying.
Thus, the "else" clause only affects non 8.5 versions and as such causes pd with tcl/tk 8.5 to be broken.
I just checked this out and the 8.4 syntax does work on 8.5 but in the current code it is never accessed due to the existing "if" statement. The new fix simply comments the "if" and "else" statements making the 8.4 style of closing children widgets mandatory for all versions, and since it appears that 8.4 code works fine with tcl/tk 8.5, this appears to be a universal fix for this issue.
Please see attached (diff -uw against the fresh CVS checkout).
----------------------------------------------------------------------
>Comment By: SourceForge Robot (sf-robot)
Date: 2008-01-02 19:20
Message:
Logged In: YES
user_id=1312539
Originator: NO
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-18 14:34
Message:
Logged In: YES
user_id=313747
Originator: NO
I think this one got silently adopted earlier.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1670440&group_…
Patches item #1862168, was opened at 2008-01-02 14:22
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862168&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 6
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: makefilename ignores "%c"
Initial Comment:
the bugfix-#1688540 introduced argument-checking in [makefilename].
unfortunately, the author forgot about the "%c", which is currently the only way to get "weird" characters (like space,...).
this breaks quite some patches which depend on that workaround.
since there is still no "clean" way to produce symbols with special characters, i'd suggest to include "%c" into the formatting in [makefilename].
attached is a fix, that adds "%c" to the types that request an integer.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862168&group_…
Patches item #1862178, was opened at 2008-01-02 14:40
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862178&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
Resolution: None
Priority: 1
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: make makefilename accept floats in %s
Initial Comment:
while fiddling with the bug-fix for the missing "%c" in [makefilename] (see #1862168), i found that
[makefilename %s] will safely ignore any number that it receives.
in theory this is nice and consistent behaviour.
in practice i find it weird that
[32(
|
[makefilename %s]
outputs nothing(!).
and
[32(
|
[makefilename _%s+]
outputs "_+"
the attached patch uses "%g" to convert a number into a string which is then inserted as %s.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862178&group_…
Bugs item #1841758, was opened at 2007-11-30 15:49
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1841758&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: ClaudiusMaximus (claudiusmaximus)
Assigned to: Nobody/Anonymous (nobody)
Summary: setitimer invalid timeval
Initial Comment:
Pd's scheduler seems to have a bug regarding setitimer, which leads to messages in the system log:
setitimer: pd (pid = 3401) provided invalid timeval it_value: tv_sec = 0 tv_usec = 1000000
(with a clock delaytime of 1000ms)
man setitimer says:
----8<----
POSIX.1-2001 says that setitimer() should fail if a tv_usec value is specified that is outside of the range 0 to 999999. However, Linux does not give an error, but instead silently adjusts the corresponding seconds value for the timer. In the future (scheduled for March 2007), this non-conformance will be repaired: existing applications should be fixed now to ensure that they supply a properly formed tv_usec value.
----8<----
This is with pd-0.40-3 from Miller's site, on GNU/Linux Debian Etch, but I've noticed this issue on various other Linux distros.
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-01-02 13:43
Message:
Logged In: YES
user_id=564396
Originator: NO
i have submitted a fix for this as patch#1862148
https://sourceforge.net/tracker/index.php?func=detail&aid=1862148&group_id=…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1841758&group_…
Patches item #1862148, was opened at 2008-01-02 13:41
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862148&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: [bugfix] setitimer invalid timeval
Initial Comment:
as described by claude in bug#1841758
(https://sourceforge.net/tracker/index.php?func=detail&aid=1841758&group_id=…)
there is a small bug in the use of setitimer() in sys_setalarm().
the problem is, that the setitimer() API has changed in order to be POSIX-conformant and Pd has not yet adapated to this change.
the attached patch fixes the problem, by splitting the given "microsec" value into seconds and microseconds.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862148&group_…
Patches item #1509427, was opened at 2006-06-20 18:30
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1509427&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
>Group: wishlist
>Status: Closed
>Resolution: Wont Fix
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: resampling method for halfblocks
Initial Comment:
this patch adds a new pair of up/downsampling methods,
called "block".
what it does:
downsampling: the 1st part of the original signal is
copied "as is" to the downsampled signal; the rest of
the incoming signal is discarded
upsampling: the original signal is copied to the 1st
part of the upsampled signal; the rest of the upsampled
signal is set to 0.f
what for:
an the output-signals of an fft are redundant since
they are (anti)symmetric; therefore it is a waste of
cpu-power to apply dsp-processing on both halfs of such
signals;
with this patch it is possible to do a "downsampled"
processing only on the relevant (1st) part of the
signal (~50% performance gain): after upsampling you
would have to recreate the entire signal manually (e.g.
mirror the block and add it to the non-mirrored part)
i also put some defines for the various resampling
methods into m_pd.h, so the code gets less "magic"
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-01-02 12:59
Message:
Logged In: YES
user_id=564396
Originator: YES
i think this could as well be implemented as external objects (though not
as comfortable as via [inlet~])
i therefore retract this feature-request
----------------------------------------------------------------------
Comment By: Mathieu Bouchard (matju)
Date: 2006-06-20 20:35
Message:
Logged In: YES
user_id=801174
to save on CPU and memory, a "doubly real" FFT is possible:
not only real inputs, but also real outputs. For a
N-dimensional vector (block size N), there are 2N outputs.
The way that it is normally reduced back to N, is to combine
them to produce cosine and sine coefficients. I wonder
whether that'd be a more appropriate way of dealing with the
problem than using varying block sizes? (Maybe it's not)
Also, what seems to be a clearly interesting use of the
"block" method is that if you do [fft~] before a
"block"-upsampling and a [ifft~] just after, then you've
just done trigonometric interpolation, that is,
interpolation that uses sinusoids (instead of cubics and
stuff). IMHO this is the best way to upsample a signal *if*
block boundaries are properly dealt with (using windowing).
However, I've never tried this.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1509427&group_…
Patches item #1544076, was opened at 2006-08-21 18:53
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1544076&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: wishlist
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: build pd without tcl/tk
Initial Comment:
sometimes pd is run in non-gui environments (e.g. with
"-nogui");
it is desireable that one can build such a gui-less pd,
without having to install the tcl/tk-headers.
the patch adds a "--disable-tk" flag to configure and
only sets the GSRC in makefile.in if tk is enabled.
this has been in the feature request tracker.
the patch only modifies configure.in and makefile.in;
in order to work, one must run "autoconf" to generate a
proper configure file.
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-01-02 12:57
Message:
Logged In: YES
user_id=564396
Originator: YES
seems to be accepted into 0.41
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2006-08-21 19:07
Message:
Logged In: YES
user_id=564396
2nd attempt; this time it should work (this new patch also
has the AC_SUBST(tk,yes) line, so you can ignore _that_ post)
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2006-08-21 19:00
Message:
Logged In: YES
user_id=564396
after applying the patch, you should set line 10 to
AC_SUBST(tk, yes)
(instead of "no") to make it work properly
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1544076&group_…
Patches item #1810951, was opened at 2007-10-10 17:42
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1810951&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
>Group: feature
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: allow more paths/startuplibs in the preferences
Initial Comment:
yet another implementation that removes the hardcoded number of startup-paths/libs in the gui-preferences.
this implementation just adds n+2 slots to add paths/libs in the gui (where n is the min(current_number, 10))
of course it should be done with dynamically addable slots (via a button)
this patch also does not provide scrollbars
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-01-02 12:56
Message:
Logged In: YES
user_id=564396
Originator: YES
seems to be accepted into pd-0.41
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2007-10-10 17:45
Message:
Logged In: YES
user_id=564396
Originator: YES
of course n is max(current_number, 10)
it is at least 10 slots, but might be more...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1810951&group_…
Patches item #1822001, was opened at 2007-10-29 11:08
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1822001&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: use of t_float/t_sample instead of "float"
Initial Comment:
i am currently trying to build a Pd which is based on "double" instead of "float".
in m_pd.h there are special types defined "t_sample" (for signals) and "t_float" (for messages).
in theory this makes it simple to switch between different precisions (e.g. "float" vs. "double") in both the signal and the message domain (independently).
unfortunately, in practice this does not work, because the special types are not always used (in fact, the code seems to refer more often to the types "float" instead of "t_float"/"t_sample").
the attached patch changes the occurences of "float" to "t_float" or "t_sample", depending on the context:
- t_sample is only used for signals
- t_float is used for messages
note#1: for CLASS_MAINSIGNALIN i use t_float instead of t_sample (the original code suggested t_sample instead); this makes more sense to me, as we are really dealing with messages(!), which eventually become samples
note#2: this patch only deals with trivial changes from "float" to "t_float"/"t_sample". i have not touched all the float-magic that is used in d_osc yet
note#3: the tgz contains patches for each file separately. this is to make reading easier...
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-01-02 12:42
Message:
Logged In: YES
user_id=564396
Originator: YES
seems to be accepted into 0.41
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1822001&group_…
Greetings,
I really like how this list encourages introductions of people that are new to
the development community. It's nice to see where other people are coming from.
A few years ago, I started working on the open source project, Asterisk
(http://www.asterisk.org). Asterisk is an open source telephony applications
platform. It is most often used as a typical phone system, but it is really a
toolkit where we try to make it possible to do whatever you want to with a phone
call.
While in school, I started working part-time for Digium, the company that
sponsors Asterisk. I have been working full time for Digium since January of
2007. I now hold the position of Senior Software Engineer, and Open Source Team
Lead.
About a month ago, I visited New York University's ITP program. I was there to
meet people that had done some extremely creative projects that involved
Asterisk. I was looking for new ideas, or things that I could work on to make
Asterisk easier to use as a part of a larger creative project. Whlie I was
there, I briefly met Hans-Christoph Steiner. He gave me a quick rundown of
pure-data as we walked down the street. We chatted about how there could be
some interesting applications between Asterisk and Pd. So, I have been looking
at it since then.
I have since written a Jack interface for Asterisk so that I can hook up any
number of phone calls to other applications that support Jack. I am currently
trying to figure out how to make a Pd patch to do it. :)
While learning about Pd, I have started making some contributions to the source.
I have been reading code to learn how things work in Pd. Along the way, I have
been making little fixes to problems as I notice them. I am "russellbryant" on
the sourceforge patch tracker. Most of my changes so far have been little bugs
in string buffer handling. However, I do have one sourceforge patch pending
that fixes a remotely exploitable stack buffer overflow (marked as private so it
can only be viewed by project members).
I'm interested in commit access, if and whenever other project members would
feel comfortable with it. Mainly, I'm just interested in using it for smaller
bug fixes that are obvious enough for direct commit. I am now starting to look
into the implementation of the various parts of existing jack support in Pd. It
may be nice to be able to work on any larger changes in a developer branch or
something. (However, before I started committing anything, I would like to help
draft a patch workflow document, that describes what gets committed where, when,
and by whom, so that I can ensure that I don't step out of bounds. Please let
me know if something like this exists, and I missed it.)
Anyway, thanks to everyone who has contributed to Pd. This is a really cool
application. I hope that I can contribute something useful to the project.
--
Russell Bryant