Patches item #1933800, was opened at 2008-04-03 21:29
Message generated for change (Comment added) made by xovo
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1933800&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix --disable_fat on OSX/Intel (0.41-4)
Initial Comment:
It's currently very misleading to use the configure flag --disable-fat on OSX/Intel, because configure.in defines PA_BIG_ENDIAN and the default extension for externals in d_ppc.
It is sometimes necessary to build non-fat binaries because not all compilers (especially the experimental gcc-4.3.0) support multiple architectures.
The patches introduce a .d_i386 extension and add necessary stuff to the makefiles.
The patch must be applied from the pd root (not src), since it includes src/configure.in, src/s_loader.c, extra/makefile and extra/expr~/makefile
The patch also fixes minor issues apart from i386 ... the bundled externals are now really called *.d_ppc or *.d_i386, and not *.pd_darwin.
----------------------------------------------------------------------
>Comment By: Thomas Grill (xovo)
Date: 2008-04-03 22:49
Message:
Logged In: YES
user_id=350252
Originator: YES
a small additional note:
this is still a workaround somehow: non-fat building depends on -DMACOSX3
which is really ugly
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1933800&group_…
Patches item #1933800, was opened at 2008-04-03 21:29
Message generated for change (Settings changed) made by xovo
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1933800&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
>Assigned to: Miller Puckette (millerpuckette)
Summary: fix --disable_fat on OSX/Intel (0.41-4)
Initial Comment:
It's currently very misleading to use the configure flag --disable-fat on OSX/Intel, because configure.in defines PA_BIG_ENDIAN and the default extension for externals in d_ppc.
It is sometimes necessary to build non-fat binaries because not all compilers (especially the experimental gcc-4.3.0) support multiple architectures.
The patches introduce a .d_i386 extension and add necessary stuff to the makefiles.
The patch must be applied from the pd root (not src), since it includes src/configure.in, src/s_loader.c, extra/makefile and extra/expr~/makefile
The patch also fixes minor issues apart from i386 ... the bundled externals are now really called *.d_ppc or *.d_i386, and not *.pd_darwin.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1933800&group_…
Patches item #1933800, was opened at 2008-04-03 21:29
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1933800&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
Assigned to: Nobody/Anonymous (nobody)
Summary: fix --disable_fat on OSX/Intel (0.41-4)
Initial Comment:
It's currently very misleading to use the configure flag --disable-fat on OSX/Intel, because configure.in defines PA_BIG_ENDIAN and the default extension for externals in d_ppc.
It is sometimes necessary to build non-fat binaries because not all compilers (especially the experimental gcc-4.3.0) support multiple architectures.
The patches introduce a .d_i386 extension and add necessary stuff to the makefiles.
The patch must be applied from the pd root (not src), since it includes src/configure.in, src/s_loader.c, extra/makefile and extra/expr~/makefile
The patch also fixes minor issues apart from i386 ... the bundled externals are now really called *.d_ppc or *.d_i386, and not *.pd_darwin.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1933800&group_…
Patches item #1930701, was opened at 2008-04-01 00:28
Message generated for change (Settings changed) made by xovo
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930701&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata-dev
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
>Assigned to: Miller Puckette (millerpuckette)
Summary: configure for a compiler other than cc
Initial Comment:
the patch below against makefile.in (0.41-4) allows for a configuration run like
CC=gcc-4.3 ./configure --disable-fat
where gcc-4.3 will be used as the compiler
--- makefile.ori.in 2008-04-01 02:23:18.000000000 +0200
+++ makefile.in 2008-04-01 02:23:28.000000000 +0200
@@ -32,6 +32,7 @@
-Wno-unused -Wno-parentheses -Wno-switch
ARCH_CFLAGS = -DPD
+CC = @CC@
CFLAGS = @CFLAGS@ $(ARCH_CFLAGS) $(WARN_CFLAGS) $(CPPFLAGS) $(MORECFLAGS)
# the sources
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930701&group_…
Patches item #1933679, was opened at 2008-04-03 19:19
Message generated for change (Settings changed) made by xovo
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1933679&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
>Assigned to: Miller Puckette (millerpuckette)
Summary: FFTW3 interface for pd-0.41-4
Initial Comment:
The attached patch implements the necessary functionality to emulate the mayer_fft with FFTW3. It's a strange approach and not ultimately efficient, but it's better than the plain mayer_fft in any case.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1933679&group_…
Patches item #1930748, was opened at 2008-04-01 01:35
Message generated for change (Settings changed) made by xovo
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930748&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata-dev
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
>Assigned to: Miller Puckette (millerpuckette)
Summary: fix type-punned pointers (part 3)
Initial Comment:
oh, forgot to say, those patches are against pd-0.41-4
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930748&group_…
Patches item #1930747, was opened at 2008-04-01 01:33
Message generated for change (Settings changed) made by xovo
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930747&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata-dev
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
>Assigned to: Miller Puckette (millerpuckette)
Summary: fix type-punned pointers (part 2)
Initial Comment:
part 1 continued
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930747&group_…
Patches item #1930745, was opened at 2008-04-01 01:30
Message generated for change (Settings changed) made by xovo
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930745&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata-dev
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
>Assigned to: Miller Puckette (millerpuckette)
Summary: fix type-punned pointers (part 1)
Initial Comment:
optimization with strict-aliasing chokes on type-punned pointers. Type-casting is replaced with unions.
Using static functions in m_pd.h is not nice, but those will be inlined by any decent compilers anyway.
Even better would be checking for the inline keyword with autoconf and use that throughout pd when available.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930745&group_…
Patches item #1930769, was opened at 2008-04-01 02:09
Message generated for change (Settings changed) made by xovo
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930769&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata-dev
Group: bugfix
Status: Open
Resolution: None
>Priority: 7
Private: No
Submitted By: Thomas Grill (xovo)
>Assigned to: Miller Puckette (millerpuckette)
Summary: 0.41-4 fix memory leak with array sinesum/cosinesum
Initial Comment:
svecs are allocated twice....
--- ../src.ori/g_array.c 2008-03-15 01:03:00.000000000 +0100
+++ g_array.c 2008-04-01 04:05:50.000000000 +0200
@@ -1221,7 +1221,7 @@
static void garray_sinesum(t_garray *x, t_symbol *s, int argc, t_atom *argv)
{
- t_float *svec = (t_float *)t_getbytes(sizeof(t_float) * argc);
+ t_float *svec;
int npoints, i;
if (argc < 2)
{
@@ -1244,7 +1244,7 @@
static void garray_cosinesum(t_garray *x, t_symbol *s, int argc, t_atom *argv)
{
- t_float *svec = (t_float *)t_getbytes(sizeof(t_float) * argc);
+ t_float *svec;
int npoints, i;
if (argc < 2)
{
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930769&group_…
Patches item #1930733, was opened at 2008-04-01 01:02
Message generated for change (Settings changed) made by xovo
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930733&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata-dev
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
>Assigned to: Miller Puckette (millerpuckette)
Summary: 0.41-4: prevent buffer overrun in m_class.c
Initial Comment:
the array only has MAXPDARG elements.......
--- m_class.ori.c 2008-04-01 03:00:09.000000000 +0200
+++ m_class.c 2008-04-01 03:00:12.000000000 +0200
@@ -763,7 +763,7 @@
va_start(ap, fmt);
while (1)
{
- if (nargs > MAXPDARG)
+ if (nargs >= MAXPDARG)
{
pd_error(x, "pd_vmess: only %d allowed", MAXPDARG);
break;
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930733&group_…