Patches item #1836228, was opened at 2007-11-21 23:37
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Russell Bryant (russellbryant)
Assigned to: Miller Puckette (millerpuckette)
Summary: [patch] simplify pd_makeversion() in src/s_main.c
Initial Comment:
This minor patch simplifies the pd_makeversion() function in src/s_main.c.
It replaces the sprintf / malloc / strcpy, with the equivalent single call to asprintf. It also provides the side benefit of removing the length limitation introduced by the intermediary stack buffer (with bounds that weren't being checked).
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 19:36
Message:
this is implemented completely differently in 0.43, so this is out-of-date.
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2008-01-05 23:30
Message:
Logged In: YES
user_id=1942915
Originator: YES
File Added: makeversion.patch2.txt
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2008-01-05 23:29
Message:
Logged In: YES
user_id=1942915
Originator: YES
Actually, I mean sprintf to snprintf. Anyway, here is an updated patch
that includes the change from sprintf to snprintf, as well as a
simplification to use strdup() instead of malloc/strcpy.
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2008-01-05 23:26
Message:
Logged In: YES
user_id=1942915
Originator: YES
Well, it turns out that asprintf() is a GNU extension, and is not a part
of standard C or POSIX. So, this probably will not be acceptable.
However, I'd like to still leave it open, as I'd like to see the strcpy
changed to strncpy ...
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-23 14:24
Message:
Logged In: YES
user_id=27104
Originator: NO
Funny, I originally submitted the patch with this function and it included
asprintf(). Miller accepted the patch, but replaced the asprintf() with
the sprintf/malloc/strcpy combo, with only this comment:
"modified to avoid the effete asprintf() call, then took for 0.40"
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_…
Patches item #2638371, was opened at 2009-02-25 15:41
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2638371&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: exp~ broken/fixed
Initial Comment:
exp~ just copies it's input to it's output. this is because exp_tilde_perform in d_math.c does this:
t_int *exp_tilde_perform(t_int *w)
{
t_sample *in1 = (t_sample *)(w[1]);
t_sample *out = (t_sample *)(w[2]);
int n = (int)(w[3]);
while (n--)
*out = exp(*in1);
// out and in1 are never incremented
return (w+4);
}
instead it should do this:
t_int *exp_tilde_perform(t_int *w)
{
t_sample *in1 = (t_sample *)(w[1]);
t_sample *out = (t_sample *)(w[2]);
int n = (int)(w[3]);
while (n--)
{
*out = exp(*in1);
out++;
in1++;
}
return (w+4);
}
please apply the attached patch to d_math.c
-- karl yerkes
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 19:30
Message:
fixed like this:
t_int *exp_tilde_perform(t_int *w)
{
t_sample *in1 = (t_sample *)(w[1]);
t_sample *out = (t_sample *)(w[2]);
int n = (int)(w[3]);
while (n--)
*out++ = exp(*in1++);
return (w+4);
}
----------------------------------------------------------------------
Comment By: Frank Barknecht (fbar)
Date: 2009-03-29 10:48
Message:
It seem, abs~ has a very similar issue. Attached patch fixes it, too (and
exp~)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2638371&group_…
Patches item #1852130, was opened at 2007-12-17 01:25
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852130&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Hans-Christoph Steiner (eighthave)
Summary: OSCx/configure.ac for cygwin
Initial Comment:
add -mno-cygwin in CFLAGS, includes and links MinGW
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 19:08
Message:
accepted with this commit:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852130&group_…
Patches item #1561814, was opened at 2006-09-19 20:06
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1561814&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 7
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: MinGW fixes for the "pd/extra" folder
Initial Comment:
This patch is two key parts:
- minor fixes in the source code for properly
supporting MinGW
- a new unified makefile for the "pd/extra" section
which handles Mac OS X, GNU/Linux, and Windows/MinGW.
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 18:35
Message:
these have been accepted as of 0.43.0-test1
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2009-09-01 23:57
Message:
how about moving the MSVC nmake Makefile to makefile.nt, like the main MSVC
makefile?
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2009-08-30 17:42
Message:
I took the patches -- the makefile looks like it will break my MSVC build
(nmake, anyone?)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-10-27 22:37
Message:
Logged In: YES
user_id=27104
Originator: YES
The makefile included here needs to be updated for Mac OS X Universal
builds, basically, this needs to be added to the CFLAGS:
-isysroot /Developer/SDKs/MacOSX10.4u.sdk -arch i386 -arch ppc
And this needs to be added to the LDFLAGS:
-arch i386 -arch ppc
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2006-09-19 20:14
Message:
Logged In: YES
user_id=27104
I forgot to mention, this is called differently from
pd/src/makefile. The "extern" target should look like this
to use this makefile:
externs:
make -C ../extra
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1561814&group_…
Patches item #1851193, was opened at 2007-12-15 00:23
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1851193&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
>Group: bugfix
Status: Open
Resolution: None
>Priority: 9
Private: No
Submitted By: Roman Haefeli (reduzent)
Assigned to: Miller Puckette (millerpuckette)
Summary: [symbolatom\ : doesn't allow to type spaces (ascii 32)
Initial Comment:
i would like to read a textfile into an object [textfile] by using the symbolatom as a gui to specify the filename. however, it fails when the filename of the file contains a space.
example patch:
[symbolatom\
|
[read $1(
|
[textfile]
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 18:32
Message:
I'm elevating the priority since this is a trivial fix and has been in
Pd-extended since 2007.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-03-20 23:16
Message:
Wow, such a simple fix, I wish I thought of trying years ago. This does
make me think that we should have a discussion at PdCon just about spaces
and symbols. I included this change in Pd-extended 0.41. Here's the
commit:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=108…
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-04-06 13:42
Message:
Logged In: YES
user_id=564396
Originator: NO
the fix for this is rather trivial (see attached patch)
i'm wondering why spaces have been disabled in the first place...
File Added: spacesymbol.diff
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1851193&group_…
Patches item #1722081, was opened at 2007-05-20 05:27
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1722081&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Luke Iannini (lukeiannini)
Assigned to: Miller Puckette (millerpuckette)
Summary: [Editmode 0( toggles rather than turns off editmode
Initial Comment:
Hallo,
Simple enough... sending [editmode 0( to a subpatch toggles the edit-mode state of the subpatch, rather than turning it off.
[editmode 1( works fine, reliably enabling (and never disabling) editmode.
Ah! That makes me realize the workaround is to send [editmode 1(, then [editmode 0(. Regardless, this should be fixed!
Demonstration is attached (move mouse around to see the cursor change).
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 18:27
Message:
This has been included in 0.43.0-test1 with commit
dc79a38f5664055a5a8b9eb508917931fdefccd4
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-11 11:23
Message:
Included in pd-gui-rewrite/0.43 branch, should make it into vanilla:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=129…
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2007-10-01 07:36
Message:
Logged In: YES
user_id=564396
Originator: NO
the attached patch (editmode_toggle.patch) introduces 3 states:
0: turn OFF editmode
1: turn ON editmode
everything else: toggle editmode
the pd-gui (u_main.tk) has also been udated to use "-1" when toggling
editmode.
File Added: editmode_toggle.patch
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2007-10-01 07:33
Message:
Logged In: YES
user_id=564396
Originator: NO
actually this is not really a bug: Pd internally uses "editmode 0" to
toggle between the 2 states (e.g. when you press "Control-E");
so the behaviour you described is intended!
the inffocial "pd-msg" documentation should be updated to reflect this.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1722081&group_…
Patches item #1936157, was opened at 2008-04-06 14:17
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1936157&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmlnig (zmoelnig)
>Assigned to: Miller Puckette (millerpuckette)
Summary: make "list" messages be real float/symbol/bang messages
Initial Comment:
in the past there has been some attempts to make "list" messages behave like "float" (or "symbol" or "bang") messages and vice-versa.
the attached patch adds some additional fallbacks to the method dispatcher in inlet_list():
if an object has no real list-method for an inlet but a float-method and it receives a one-element list holding a float, it will call the float-method.
the same for symbols.
if there is no list-method and the object receives an empty "list" message, it will call the objects "bang_method"
this should fix bugs #1890931 and #1749885.
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 18:23
Message:
I'm going to assign this to Miller, and let him make the call on whether to
include it or not rather than include it in Pd-extended.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-04-25 16:26
Message:
I am going to assign this to me for now so that I remember to included it
in the Pd-extended 0.42 branch, unless anyone has any objections. Then
I'll assign it to Miller...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1936157&group_…
Patches item #1944380, was opened at 2008-04-16 17:19
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1944380&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Hans-Christoph Steiner (eighthave)
Summary: fixed help patch for plugin~
Initial Comment:
The plugin~ object was incorrectly using a [print< message. By reading the source, I saw that it should have been using an [info< message. I changed this and added [print] objects so that the output in response to the info messages can be seen. I added attribution of this fix to the file, which you can feel free to remove if it is inappropriate.
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 18:18
Message:
this should be fixed in SVN and Pd-extended 0.42.5
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1944380&group_…
Patches item #1852128, was opened at 2007-12-17 01:21
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852128&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Hans-Christoph Steiner (eighthave)
Summary: compile with -mno-cygwin
Initial Comment:
This allow to compile with cygwin shell, and might not be as clean as it was done by a makefile specialist
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 18:17
Message:
This patch should have a separate section for Cygwin, not just tacked onto
the WIN32 section. This patch is largely make obsolete by the new Makefile
and library template:
http://pure-data.svn.sourceforge.net/viewvc/pure-data/trunk/externals/templ…
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2007-12-19 08:10
Message:
Logged In: YES
user_id=564396
Originator: NO
while the original post is rather cryptic, i guess this is for the
pd-extended build-system (at least, according to the file-description it is
about "externals/Makefile" which is pd-extended only)
i therefore assign it to hans :-)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852128&group_…
Patches item #2803092, was opened at 2009-06-08 13:49
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2803092&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 8
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fixes to get 'extra' building under MinGW again
Initial Comment:
There are a couple of tweaks needed to get the new 0.42 'extra' code to build on MinGW.
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=117…
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 18:12
Message:
most of this patch was already included, the rest I will be submitted as
part of a git patch set, so I am closing this.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 21:20
Message:
You also might consider replacing the #define flog log stuff with the
actual functions. On GNU/Linux and BSD, the float versions are called
logf(), etc.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2803092&group_…