Patches item #3032844, was opened at 2010-07-21 23:06
Message generated for change (Tracker Item Submitted) made by claudiusmaximus
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3032844&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: ClaudiusMaximus (claudiusmaximus)
Assigned to: Nobody/Anonymous (nobody)
Summary: Sort method tables by symbol and use binary search
Initial Comment:
Sort method tables by symbol and use O(log(N)) binary search instead of an O(N) linear search. This should speed up calling existing methods but it might slow down adding new methods.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3032844&group_…
Hey Miller,
I just saw that you accepted and changed the sys_expandpath() stuff,
thanks for that. There are two little related issues that I thought I'd
bring up:
- in commit c78d6b22941725368af014fd0863b00e96f0dde7 "bug fix to
sys_expandpath", you added some curly braces around the code at the end
in "#ifdef _WIN32 section. They don't seem to do anything and could
make the code confusing, i.e. the ExpandEnvironmentStrings stuff at the
end is not part of the "if ((strlen(from) == 1 &&..." code block.
- second, MAXPDSTRING (1000) is bigger than FILENAME_MAX on Win32 (255).
That is a source of crashes if anyone makes a string/symbol longer than
255 on Windows. I think we should be using the POSIX macro FILENAME_MAX
rather than MAXPDSTRING anytime we are dealing with paths and filenames
for that reason. Plus I think FILENAME_MAX is part of the C89 spec, so
it should be very widely implemented.
http://www.mofeel.net/957-microsoft-public-vc-language/11149.aspx
.hc
Patches item #1862178, was opened at 2008-01-02 05:40
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862178&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
>Status: Closed
>Resolution: Accepted
Priority: 1
Private: No
Submitted By: IOhannes m zmlnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: [feature] make makefilename accept floats in %s
Initial Comment:
while fiddling with the bug-fix for the missing "%c" in [makefilename] (see #1862168), i found that
[makefilename %s] will safely ignore any number that it receives.
in theory this is nice and consistent behaviour.
in practice i find it weird that
[32(
|
[makefilename %s]
outputs nothing(!).
and
[32(
|
[makefilename _%s+]
outputs "_+"
the attached patch uses "%g" to convert a number into a string which is then inserted as %s.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862178&group_…
Patches item #1851193, was opened at 2007-12-14 21:23
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1851193&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 9
Private: No
Submitted By: Roman Haefeli (reduzent)
Assigned to: Miller Puckette (millerpuckette)
Summary: [symbolatom\ : doesn't allow to type spaces (ascii 32)
Initial Comment:
i would like to read a textfile into an object [textfile] by using the symbolatom as a gui to specify the filename. however, it fails when the filename of the file contains a space.
example patch:
[symbolatom\
|
[read $1(
|
[textfile]
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 15:32
Message:
I'm elevating the priority since this is a trivial fix and has been in
Pd-extended since 2007.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-03-20 20:16
Message:
Wow, such a simple fix, I wish I thought of trying years ago. This does
make me think that we should have a discussion at PdCon just about spaces
and symbols. I included this change in Pd-extended 0.41. Here's the
commit:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=108…
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-04-06 10:42
Message:
Logged In: YES
user_id=564396
Originator: NO
the fix for this is rather trivial (see attached patch)
i'm wondering why spaces have been disabled in the first place...
File Added: spacesymbol.diff
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1851193&group_…
Patches item #1841002, was opened at 2007-11-29 06:11
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1841002&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Russell Bryant (russellbryant)
Assigned to: Miller Puckette (millerpuckette)
Summary: Add format string error checking, and fix related errors
Initial Comment:
This patch adds format string error checking for bug(), error(), verbose(), and pd_error(). It also fixes the errors in the pd core that were pointed out by this change.
There are some other functions that take printf style format strings that would benefit from this same change, but I wanted to address pieces of it at a time.
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2007-11-30 05:33
Message:
Logged In: YES
user_id=1942915
Originator: YES
File Added: format_string.patch2.txt
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2007-11-30 05:32
Message:
Logged In: YES
user_id=1942915
Originator: YES
I assume you meant seems "not" very likely to do any harm. :)
Good point about MSVC. I am used to only caring about gcc. I have
provided an updated patch that only uses the attribute if GNUC is in use.
It is also implemented as a macro in one spot so that addressing it for
other compilers in the future can be done in one spot.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-29 10:15
Message:
Logged In: YES
user_id=27104
Originator: NO
Looks like the right thing to do, and seems very likely to do any harm.
I'm going to try it in Pd-extended. The only concern I can think of is
whether the __attribute__ stuff causes any problems when building with
MSVC, since some people still build Pd with MSVC. This site seems to claim
it does not:
http://ocliteracy.com/techtips/gnu-c-attributes.html
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1841002&group_…
Patches item #1838621, was opened at 2007-11-26 03:11
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1838621&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Cyrille Henry (nusmuk)
Assigned to: Miller Puckette (millerpuckette)
Summary: setable [route], just like [select]
Initial Comment:
this patch allow [route] to react just like [select] :
when route is create with 1 argument, a 2nd inlet is created in order to change this argument.
this ca be very usefull, and the patch is very small.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1838621&group_…
Patches item #1838468, was opened at 2007-11-25 21:57
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1838468&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Miller Puckette (millerpuckette)
Summary: made [print] display all arguments in its posts to pd window
Initial Comment:
Just like the subject says, I made [print] accept an A_GIMME, the arguments are then converted into a symbol, then that symbol is display as before.
I suppose x->x_sym could be a char* instead.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-06-14 12:45
Message:
I had to change the code a bit for new Windows Vista/7 weirdness:
Following this discussion:
http://lists.puredata.info/pipermail/pd-list/2010-05/078312.html
I committed this to try to fix it:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=135…
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-12-04 14:00
Message:
Logged In: YES
user_id=27104
Originator: NO
updated to fix minor bugs:
http://pure-data.cvs.sourceforge.net/pure-data/pd/src/x_interface.c?r1=1.3.…
File Added: made_print_post_all_arguments-0.40.3.patch
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-25 22:16
Message:
Logged In: YES
user_id=27104
Originator: NO
http://pure-data.cvs.sourceforge.net/pure-data/pd/src/x_interface.c?r1=1.3&…
File Added: made_print_post_all_arguments-0.40.3.patch
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-25 22:16
Message:
Logged In: YES
user_id=27104
Originator: NO
http://pure-data.cvs.sourceforge.net/pure-data/pd/src/x_interface.c?r1=1.3&…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1838468&group_…
Its already being actively used in the GUI rewrite, which is currently
somewhat broken without it. I think the only client for that message
really would be pd-gui, and I'd happily do the work to change it if need
be. That's a much better option than omitting it.
.hc
Miller Puckette wrote:
> My usual strategy on stuff like this is wait until someone is actively
> using it - because one's guess as to how the feature should work is never
> how it's really needed when the time comes and then you're stuck maintaining
> two different versions of the same thing :)
>
> M
>
> On Sat, Jul 17, 2010 at 12:15:30AM -0400, Hans-Christoph Steiner wrote:
>> Yeah, I added the "pd set-startup", etc. stuff to m_glob.c and
>> s_path.c. Regardless of the startup procedure, I think pd-gui should
>> be able to request state from pd so it can stay in sync. A dialog
>> shouldn't be required to get this info. This is akin to IOhannes'
>> idea that pd-gui's state should be settable by pd at any point while
>> running.
>>
>> Then it makes sense to reuse the same procedure for getting the state
>> in the startup procedure, rather than having a custom method for only
>> the startup procedure.
>>
>> .hc
>>
>> On Jul 16, 2010, at 10:59 PM, Miller Puckette wrote:
>>
>>> Hi Hans --
>>>
>>> the "vwait" line didn't seem correct to me (could return right after
>>> Pd says to clear pd_path, before the other messages bubble up to
>>> append
>>> the various directories to it).
>>>
>>> I ended up fixing Pd to volunteer the path and startup stuff before
>>> sending
>>> pdtk_pd_startup so that none of the tcl side of things should be
>>> needed
>>> any longer. OTOH if you were planning to send "pd set-startup" etc at
>>> some later point in the tcl code, this would need to be supported in
>>> Pd...(?)
>>>
>>> cheers
>>> Miller
>>>
>>> On Fri, Jul 16, 2010 at 03:58:24PM -0400, Hans-Christoph Steiner
>>> wrote:
>>>> Hey Miller,
>>>>
>>>> I just noticed that you left out a key part of pd-gui-rewrite in
>>>> 0.43. There is the 'set-startup' and 'set-path' messages which
>>>> allows
>>>> pd-gui to get the state of those things without having to open the
>>>> respective preference dialog panels. The changes are in m_glob.c and
>>>> s_path.c, as well as these lines in pd-gui.tcl:
>>>>
>>>> pdsend "pd set-startup" ;# get ::startup_libraries
>>>> and ::startup_flags lists
>>>> pdsend "pd set-path" ;# get the ::pd_path list
>>>> vwait ::pd_path ;# wait for 'pd' to respond
>>>>
>>>> .hc
>>>>
>>>> ----------------------------------------------------------------------------
>>>>
>>>> "We have nothing to fear from love and commitment." - New York
>>>> Senator
>>>> Diane Savino, trying to convince the NY Senate to pass a gay marriage
>>>> bill
>>>>
>>>>
>>>> _______________________________________________
>>>> Pd-dev mailing list
>>>> Pd-dev(a)iem.at
>>>> http://lists.puredata.info/listinfo/pd-dev
>>
>>
>>
>>
>> ----------------------------------------------------------------------------
>>
>> Programs should be written for people to read, and only incidentally
>> for machines to execute.
>> - from Structure and Interpretation of Computer Programs
Patches item #1826507, was opened at 2007-11-05 18:16
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1826507&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix data structures cursor on OSX and allow cursor configura
Initial Comment:
This patch moves the setting of the cursor names to u_main.tk so that they can be changed at runtime, allowing users to use all of the available Tk cursors from within patches.
It also fixes the problem with the CURSOR_RUNMODE_CLICKME not working on Mac OS X.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1826507&group_…
Patches item #1826144, was opened at 2007-11-05 07:41
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1826144&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: IOhannes m zmlnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: accept atoms as lists on righthand inlets
Initial Comment:
when an object has a list-method on its left inlet, it will happily accept floats and symbols as well (and handle them as 1-atom lists), if no specific method for these types is defined.
however, this is not true for right-hand inlets.
if such an inlet (with a "list" method, as declared with
receives a single float number (as output by the numberbox), it bails out with
"error: inlet: expected 'list' but got 'float'"
this is especially sad, as there is no way to add methods for several types of messages to a right-hand inlet (well, there are methods like using proxys; but we don't want to go into that)
a workaround for this is to run the message through [list] (or [list $1(), however i would rather not use this.
instead, the attached patch fixes this by modifying the inlet_* methods in m_obj.c to fallback to inlet_list() if all else fails.
btw, this is the code i use to add a list-method to the 2nd outlet:
new{
...
inlet_new(&x->x_obj, &x->x_obj.ob_pd, &s_list, gensym("list2"));
}
setup{
...
class_addmethod(myobj_class, (t_method)myobj_list2, gensym("list2"), A_GIMME, 0);
})
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-05 08:58
Message:
Logged In: YES
user_id=27104
Originator: NO
Sounds very useful, but I am sure there have got to be some unwanted
ramifications. Do you have any idea what they might be?
Is this ready to be included in 0.40.3-extended ?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1826144&group_…