Patches item #1981332, was opened at 2008-06-01 07:38
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1981332&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
Resolution: Duplicate
Priority: 5
Private: No
Submitted By: Martin Peach (mrpeach)
Assigned to: Nobody/Anonymous (nobody)
Summary: add path arg to openpanel and savepanel
Initial Comment:
This patch adds a path argument to openpanel and savepanel which is saved whenever the enclosing patch is saved.
I used A_GIMME for the argument, but only a single symbol will be used, any other args will be quietly ignored.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2010-07-28 20:45
Message:
This would make openpanel and savepanel the only two non-graphical objects
to save their state in Pd -- probably we should do this either with
everything in Pd (ugh) or invent something different. In fact there's no
way to store a symbol non-volatilely in Pd (except using data structures,
way too complicated to set up) so something else is needed.
----------------------------------------------------------------------
Comment By: Martin Peach (mrpeach)
Date: 2008-06-03 06:23
Message:
Logged In: YES
user_id=919007
Originator: YES
Not quite. My original intent was to add the ability to save and restore
the current path to/from the .pd file, so I added save functions. A side
effect of that is that it is now also possible to specify a path in the
creation argument. A snag with that is that the displayed argument doesn't
change when the current directory changes.
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-06-03 00:02
Message:
Logged In: YES
user_id=564396
Originator: NO
isn't that a dupe of:
http://sourceforge.net/tracker/index.php?func=detail&aid=1244757&group_id=5…
----------------------------------------------------------------------
Comment By: Martin Peach (mrpeach)
Date: 2008-06-02 10:38
Message:
Logged In: YES
user_id=919007
Originator: YES
...and periods of course. Part of the problem is that odd characters in
filenames can get mangled by intervening software, as in the case of Pd,
where you can't use { } or \ in a filename because you can't enter it, you
get a message like "keycode 92: dropped" instead.
----------------------------------------------------------------------
Comment By: Martin Peach (mrpeach)
Date: 2008-06-02 10:22
Message:
Logged In: YES
user_id=919007
Originator: YES
Of course you're right. In my experience of cross-platformity though it's
best to use underscores instead of spaces, never start a filename with a
number, and otherwise use only alphanumeric characters in file names. It
just _always_ works that way.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-06-02 10:04
Message:
Logged In: YES
user_id=27104
Originator: NO
FYI: commas are valid in all the major filesystems, EXT2/3, HFS+, NTFS,
XFS, etc. I think even FAT supports commas. Same with semi-colons.
Basically, the NTFS restrictions are the common denominator
(http://en.wikipedia.org/wiki/NTFS), you can't use these characters:
U+0000 (NUL) / (slash) \ (backslash) : (colon) * (asterisk) ? (Question
mark) " (quote) < (less than) > (greater than) and | (pipe)
EXT2/3 only limits (NULL /) and HFS+ APIs limit (NULL / :)
----------------------------------------------------------------------
Comment By: Martin Peach (mrpeach)
Date: 2008-06-02 09:08
Message:
Logged In: YES
user_id=919007
Originator: YES
OK, here is a patch that just makes a path from all the arguments. If the
path doesn't work it seems to be quietly ignored by tcl. Not sure which OSs
allow commas in file names...
File Added: panelpatch2.diff
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-06-01 15:54
Message:
Logged In: YES
user_id=27104
Originator: NO
how about using all of the arguments as the path name? That way you can
easily include paths that have spaces in them, which are quite common. you
can see an example of how to convert the argv t_atom list to a binbuf then
to a string here, in function print_new():
http://pure-data.svn.sourceforge.net/viewvc/pure-data/branches/pd-extended/…
Ideally, it would also handle commas, etc.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1981332&group_…
Patches item #1975056, was opened at 2008-05-27 08:18
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1975056&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 4
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Hans-Christoph Steiner (eighthave)
Summary: show whole subpatch name in window title
Initial Comment:
Since you can type a whole long list of atoms in the subpatch object box, it is also useful to show this whole name in the window title. This patch does that.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2010-07-28 17:49
Message:
Yet another reason the bind-the-patch-to-its-name is a sucky hack that
should someday be replaced with something sensible.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-06-01 02:59
Message:
Logged In: YES
user_id=27104
Originator: YES
Oops, this patch needs some more work to better handle the receive symbol
for the subpatch. I think it should just replace the spaces with dashes.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1975056&group_…
Patches item #1963983, was opened at 2008-05-14 10:36
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1963983&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 6
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: use FILENAME_MAX for all filenames, since its < MAXPDSTRING
Initial Comment:
On Windows, FILENAME_MAX is much smaller than MAXPDSTRING, so I replaced MAXPDSTRING with FILENAME_MAX everywhere I could find that is related to filenames. FILENAME_MAX is a POSIX standard macro for defining the max length of a complete filename.
The current situation could result in crashes on Windows.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2010-07-28 17:47
Message:
I'm not sure but I don't think Windows should have trouble trying to open
files with too-long names -- if it's anything near correct it should simply
refuse. And it's better to have as few POSIX dependencies as possible (Pd
bios, anyone? :)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-05-14 10:47
Message:
Logged In: YES
user_id=27104
Originator: YES
ok, this time really removed all bits of
add_tilde_support_toopen-0.41.4.patch
File Added: use_FILENAME_MAX_for_file_operations-0.41.4.patch
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-05-14 10:39
Message:
Logged In: YES
user_id=27104
Originator: YES
oops, removed add_tilde_support_toopen-0.41.4.patch from this one
File Added: use_FILENAME_MAX_for_file_operations-0.41.4.patch
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1963983&group_…
Patches item #1948146, was opened at 2008-04-21 11:15
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1948146&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jakob Leben (jleben)
Assigned to: Nobody/Anonymous (nobody)
Summary: array: move instead of redraw graphics
Initial Comment:
This is a patch that fixes slow ("sticky") displacing of arrays by moving instead of recreating their graphics.
It also fixes the problem of array name not appearing immediately after its creation as it was necessary now that arrays don't recreate but only move all that belongs to their appearance when displaced.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2010-07-28 17:41
Message:
Interesting idea - I wonder though if it would be simpler and more
maintainable to use some sort of throttling instead. Array moves are
definitely ugly now.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-24 12:56
Message:
Logged In: YES
user_id=27104
Originator: NO
see patches 1943614 and 1943301 for a history of this patch
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1948146&group_…
Patches item #1962700, was opened at 2008-05-12 16:18
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1962700&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: two embedded prefs for Mac: default and override all
Initial Comment:
This patch creates two different kinds of embedded org.puredata.pd.plist prefs files on Mac OS X. The first is the default settings that come with Pd-extended.app, the second is a prefs file that overrides all others, so that people can make their own custom apps based on the Pd.app, and be sure that the user's prefs aren't going to override things.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2010-07-28 17:38
Message:
I think we should fix the preferences system so that pd extended doesn't
rely on any preferences at all -- anything short of that will make for
maintenance headaches later on.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-05-13 10:06
Message:
Logged In: YES
user_id=27104
Originator: YES
That could work. I don't think this will cover every possibility. I
think a more straightforward approach would be to handle very special
hardware setups in the patch rather than the preferences. I think the
preferences should be general things, since you can't really query or test
for failures with the preferences system.
For the built-in audio, it almost always just works, so specific
configuration isn't needed.
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-05-13 00:37
Message:
Logged In: YES
user_id=564396
Originator: NO
hmm, but how should the author of a custom app know about the
hardware-settings of the end-user?
wouldn't it be better to split the configuration files into
machine-dependencies (soundcard,...) and user-dependencies (libs,...) which
could then be overridden seperately?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1962700&group_…
Patches item #1961878, was opened at 2008-05-11 06:28
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1961878&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
>Status: Closed
>Resolution: Accepted
Priority: 9
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: add ~ and env var support to paths when opening files
Initial Comment:
Created sys_expandpath() to replace ~ with $HOME and expand env vars on Windows. This function is then used in sys_trytoopenone() so that ~ works with all opening operations.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-19 12:15
Message:
updated using git-format-patch for 0.43.0-test1
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-05-14 10:24
Message:
Logged In: YES
user_id=27104
Originator: YES
updated to fix crasher bug on GNU/Linux
File Added: add_tilde_support_toopen-0.41.4.patch
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1961878&group_…
Patches item #1948287, was opened at 2008-04-21 14:50
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1948287&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Stephen Sinclair (radarsat1)
Assigned to: Nobody/Anonymous (nobody)
Summary: Throttle speed of mouse motion events whhen moving objects.
Initial Comment:
Use a clock to throttle mouse motion events when objects are being moved in the editor.
This improves GUI responsiveness when moving many objects at once. Perhaps there is a better way than adding a clock instance to each and every canvas.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2010-07-28 17:19
Message:
cool - I should have done this 10 years ago.
----------------------------------------------------------------------
Comment By: Stephen Sinclair (radarsat1)
Date: 2008-04-21 18:20
Message:
Logged In: YES
user_id=616837
Originator: YES
It would probably help to use 'move', but this doesn't really conflict
with that idea. Either way I think it's somewhat wasteful to redraw the
screen on every mouse move event. It's only necessary to redraw as fast
as:
- a human can move the mouse
- the screen can refresh
Some tests I did with moving lots of objects (and large arrays) were much
smoother using this clock. Probably one global clock could be used, since
only one canvas can receive mouse motion events at a time. But that might
require more complicated changes. I wasn't sure about adding the e_xnew
and e_ynew variables, but I couldn't think of a better way. I'm open to
ideas.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-21 16:51
Message:
Logged In: YES
user_id=27104
Originator: NO
This in interesting idea, I think some of the IEMGUIs have built-in clocks
for drawing, like [vu]. IIRC. I wonder if it would be necessary if the
displace_fn stuff was cleaned up to use 'move' instead of 'delete' then
'create', like in patch #1948146.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1948287&group_…
Patches item #1914851, was opened at 2008-03-15 11:45
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1914851&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: marius schebella (mariusschebella)
Assigned to: Miller Puckette (millerpuckette)
Summary: menubar - window filename update
Initial Comment:
hi,
I found a minor bug. when you open a patch (or create new patch) and then "save as" (or "save" with a new patch) then that name is not updated in the menubar-window menu.
the patch is still listed under the old name or "untitled".
maybe that's only on mac 10.5. I tried pd-extended 0.40.3(080222) and the current pd 0.41-2 from millers site.
marius.
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-28 14:53
Message:
git commit 842230bb50000c90dbaab46c9e529e6020ef10fc
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-28 16:45
Message:
Logged In: YES
user_id=27104
Originator: NO
Ok, found the source of the problem. I changed it so whenever saving,
update the window list for the Window menu in case the save was a "Save As"
that changed the name of the window.
File Added: update_window_list_on_saveas-0.41.4.patch
----------------------------------------------------------------------
Comment By: marius schebella (mariusschebella)
Date: 2008-04-28 08:09
Message:
Logged In: YES
user_id=1856112
Originator: YES
sorry, if I was not clear. to reproduce create a new patch and look in the
menubar under "Windows". It will be listed as Untitled-1 or something. then
save it as somename.pd and look again under "Windows". it is still listed
as untitled. this does not get updated until you open a new patch.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-28 00:57
Message:
Logged In: YES
user_id=27104
Originator: NO
I cannot reproduce his bug on Pd-0.40.3-extended-20080427 or Pd-0.41-4 on
Mac OS X 10.4.11. If you saveas an abstraction that is in use, it will not
change the title , and it will indeed remain as that abstraction, and just
save a copy, IIRC.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1914851&group_…
Patches item #1881907, was opened at 2008-01-29 11:24
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1881907&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: IOhannes m zmlnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: more t_float/t_sample fixes
Initial Comment:
pd-0.41 has a lot of cleanup regarding the types of numbers (see patch-#1822001 'use of t_float/t_sample instead of "float"')
however, some things have been left out by the original patches, here are some more:
m_pd.h:
seems like the t_float-enabling of postfloat() was forgotten in the declaration
d_math.c:
here it is the other way round: while the declarations in m_pd.h use t_float, the definitions do not
g_array.c g_template.c:
here my patch was a bit rash: scanf() doesn't like to get pointers to double (if "t_float" is set to "double") if the format string is really "%f" (or "%g"); the new patches use an internal _double_ variable and the format string "%lf" ("%lg"); the _double_ variable is then cast to (t_float).
this should be on the save side; the alternatives would have been using an internal _float_ variable, and/or to change the format-string depending on the used type.
d_fftroutine.c: this needed a bit more changes, but luckily enough, the original code already was aware of possible type-changes; i have currently used "t_float" (in line with the m_pd.h declaration of "pd_fft()"), but i am not sure whether this really should be "t_sample".
changes should be rather simple: just change the defines of FLOAT and SAMPLE in the beginning... (and don't forget the declaration in m_pd.h)
with these changes, Pd compiles without (additional) warnings with t_float/t_floatarg and t_sample set to "double".
(there is still work to do in d_ugen.c though, to make it really usable...)
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-28 14:52
Message:
git commit 842230bb50000c90dbaab46c9e529e6020ef10fc
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2010-07-24 22:17
Message:
I adopted changes where they looked right.. I then tried actually running
Pd in 64 bit and found
lots of problems. So I'll mark this 'accepted' but there's more to do
here.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:43
Message:
it seems that some of this stuff has been accepted and some not, perhaps
they should be reformated?
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-01-29 12:54
Message:
Logged In: YES
user_id=564396
Originator: YES
File Added: sigmund~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-01-29 12:12
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for extra/sigmung~
File Added: sigmund~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-01-29 12:11
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for pique
File Added: pique.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-01-29 12:09
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for extra/lrshift~
File Added: lrshift~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-01-29 12:08
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for extra/loop~
(the core code originally was not dependent on Pd; i therefore introduced
an additional "#define t_sample float" in case it is not compiled for Pd)
File Added: loop~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-01-29 12:06
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for extra/choice
File Added: choice.c.diff
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1881907&group_…