Patches item #2947822, was opened at 2010-02-08 05:12
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2947822&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Matteo Sisti Sette (sistisette)
Assigned to: Miller Puckette (millerpuckette)
Summary: space character in gui labels causes disaster
Initial Comment:
Steps to reproduce:
1 - Open the attached patch
Note the size of the radio and toggle. Note also they have "send" symbols set to "xxx" and "yyy" respectively
2 - Click on the big bang at the top
This composes a symbol containing space characters and sends it as a label to both the radio and the toggle.
This seems to work: the label is actually set with spaces, and the radio and toggle still work.
However, if you right-click on any of them and try to select "properties", the properties dialog won't open
3 - Now save the patch and close it
4 - Open the patch again. The radio and toggle properties have been completely "reset": their size have been reset to default, and also the "number" property of the radio. They have lost their "send" symbol too: you can see the outlet and if you use them, the "r" objects won't receive anything.
However, if you open the properties dialog of the radio or toggle, you'll see that the "send" property is still there (not the same can be said for the size and number); if you now do Apply or Ok, the send symbol will be restored.
So, spaces in the label of a gui object cause weirdnesses and potential disaster. Note that data is lost (the properties of the gui objects) if the patch is saved after assigning such a label, and i is lost silently with no error message at any moment.
There are ather "forbidden" characters ithat don't behave properly n labels, such as the open square bracket "[" (as reported in another bug report). However the space character is more disatrous as it causes data loss.
Object should either accept ALL characters for a label, or properly detect and refuse forbidden characters, which should be documented, avoiding unexpected consequences.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-03 19:27
Message:
Note the much simpler way the "number box" finesses this problem. I'm
scared of adding
code to m_binbuf.c to escape spaces (what will happen when we later allow
backslashes
into the mix?). But without the binbuf patch the fix to the IEM guis
doesn't work - so I'm
tempted for now just to do as in the number box - it's not incompatible to
"do it right" at
some ater date when we can thonk the whole thing through (it's all over the
Pd code and all
needs to be figured out together).
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-11-13 16:45
Message:
added another patch (0002_*) that implements escaping spaces and tabs when
saving the files to disk.
i guess both patches should be applied for full fun.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-11-13 15:36
Message:
the bug.pd file does not correctly show the labels with blanks after
reloading but it doesn't throw any warnings)
however, the bugfix-patch doesn't work for me.
nevertheless the problem is known and is not in the pd->gui communication,
but rather in the way the label is stored on disk (and then interpreted on
reload):
afaict, blanks (and other special chars) really must be escaped with
backslash (e.g. "A\ A\ A") when saved to disk
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-11-13 12:52
Message:
the values were not quoted, so just quoting them with {} fixes it. The
patch is attached.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2947822&group_…
Patches item #3585457, was opened at 2012-11-08 12:17
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3585457&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Pending
>Resolution: Accepted
Priority: 7
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: support for OSSv4
Initial Comment:
one of Pd's older audio-backends is OSS.
while OSS is rather old and not a fast-moving target, some development does happen...
e.g. a while ago (probably years) all SOUND_PCM_-defines have been renamed to SNDCTL_DSP_.
luckily, the linux headers provided fallback defines, so old code (like Pd) would still compile.
now OSS is not dead and is currently developed as OSSv4.
unfortunately, the new OSSv4 headers have dropped the old fallback defines, and instead pro-actively create errors when the old defines are still used.
the attached patch changes these defines (and provides fallbacks in case the *new* defines are not defined), in order to be able to still use the OSS backend.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-03 18:01
Message:
applied to 0.44
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-11-08 12:19
Message:
raising priority since the old s_audio_oss.c breaks compilation.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3585457&group_…
Bugs item #3592292, was opened at 2012-12-03 15:20
Message generated for change (Tracker Item Submitted) made by ceplatel
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=3592292&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pd-extended
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Charles Platel (ceplatel)
Assigned to: Hans-Christoph Steiner (eighthave)
Summary: Feedback on beta version: issue when editing
Initial Comment:
Pd version 0.43.4-extended 20121101. Mac OSX Lion with 2 screens.
Sometimes when several window patches are open for editing, they can loose the pd menu. It can be retrieved by clicking in the TCL console windows.
It never happen withe the former Pd version 0.42.5-extended.
Not easy to reproduce to study this issue.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=3592292&group_…
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2012-12-03 19:05, SourceForge.net wrote:
>
>> Comment By: Miller Puckette (millerpuckette)
> Date: 2012-12-03 10:05
>
> Message: I tried this and got:
>
[...]
>
> ... is there any way you can supply a patch that doens't add
> trailing white space to 1/2 ot the Pd source?
>
> thanks M
>
hi miller.
for what it is worth, my usual workflow now includes a whitespace
checker, so i don't incidentally submit patches with whitespaces any
more (i simply enabled the pre-commit hook in my .git/hooks/).
this has been active for some time now (on all machines i currently
develop on)
otoh, the trailing whitespace in _this_ patch was intended, in order
to keep the portaudio sources as untouched as possible.
the portaudio source base doesn't seem to care at all, whether they
have lines ending with whitespace or not.
afaict, your original portaudio import also contains trailing
whitespace (at least that's how i discovered that in order to keep the
patch-set minimal, i should preserve the trailing whitespaces).
if you would prefer, i could prepare another import of portaudio
without trailing whitespaces.
fg,asdr
IOhannes
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAlC87K4ACgkQkX2Xpv6ydvT5lQCeIVbZtcj0X2r49wxIiSDW4LR3
dFAAn1T2CUMbw1SLCRIA0nVT7/Qid98V
=3CjY
-----END PGP SIGNATURE-----
Patches item #3582746, was opened at 2012-11-02 14:39
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3582746&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Pending
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix setting of [bng]'s hold time in properties panel
Initial Comment:
one of the variables didn't get renamed in the GUI rewrite:
--- a/tcl/dialog_iemgui.tcl
+++ b/tcl/dialog_iemgui.tcl
@@ -73,7 +73,7 @@ proc ::dialog_iemgui::sched_rng {mytoplevel} {
$mytoplevel.rng.max_ent configure -textvariable $var_iemgui_max_rng
$mytoplevel.rng.min_ent configure -textvariable $var_iemgui_min_rng }
if {[eval concat $$var_iemgui_max_rng] < $define_min_flashhold} {
- set $var_iemgui_max_rng $iemgui_define_min_flashhold
+ set $var_iemgui_max_rng $define_min_flashhold
$mytoplevel.rng.max_ent configure -textvariable $var_iemgui_max_rng
}
if {[eval concat $$var_iemgui_min_rng] < $define_min_flashbreak} {
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-03 11:19
Message:
applied for 0.44
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3582746&group_…
Patches item #3591846, was opened at 2012-12-02 08:56
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3591846&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 9
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: portaudio fixes
Initial Comment:
this patches fixes the current portaudio implementation.
since it is too big to be added to the patch-tracker (i imported portaudio-20121129), you can download it from http://iem.at/~zmoelnig/0001-updated-to-portaudio-20121129-snapshot.patch.b…
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-03 10:46
Message:
... in case this makes it easier, here's the snapshot I last used:
http://crca.ucsd.edu/~msp/tmp/pa_snapshot_20121031.tgz
if you try diff -r --brief between this and Pd's copy in src/portaudoi you
can see how I pruned the
portaudio tree to include only stuff relevant to Pd. Oddly, I had to
supply one extra file though,
pd/portaudio/src/os/mac_osx/pa_mac_hostapis.c
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-03 10:05
Message:
I tried this and got:
[msp@fuzz pd]$ git apply
~/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:287:
trailing whitespace.
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:300:
trailing whitespace.
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:336:
trailing whitespace.
* The text above constitutes the entire PortAudio license; however,
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:341:
trailing whitespace.
* they can be incorporated into the canonical version. It is also
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:342:
trailing whitespace.
* requested that these non-binding requests be included along with the
warning: squelched 32389 whitespace errors
warning: 32394 lines add whitespace errors.
... is there any way you can supply a patch that doens't add trailing white
space to 1/2 ot the Pd
source?
thanks
M
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-12-02 09:07
Message:
raising priority, since the current state of affairs breaks all builds from
current git.
what i did:
- after the import of the portaudio-20121101 snapshot, some files where
missing to smoothly integrate with Pd's autotools system.
- so I re-imported portaudio with the missing files (and used the 20121126
snapshot, since that was the one i found on the portaudio website)
- I tried to keep the import to a minimum (but imported all files an
ordinary make would want to run a compilation)
- i added the new portaudio build-system to pd/configure.ac (so pa's
configure will get called automatically by Pd's configure)
- i also adjusted the link-path of libportaudio in pd/src/Makefile.am to
it's new location
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3591846&group_…
Patches item #3591846, was opened at 2012-12-02 08:56
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3591846&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 9
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: portaudio fixes
Initial Comment:
this patches fixes the current portaudio implementation.
since it is too big to be added to the patch-tracker (i imported portaudio-20121129), you can download it from http://iem.at/~zmoelnig/0001-updated-to-portaudio-20121129-snapshot.patch.b…
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-03 10:05
Message:
I tried this and got:
[msp@fuzz pd]$ git apply
~/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:287:
trailing whitespace.
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:300:
trailing whitespace.
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:336:
trailing whitespace.
* The text above constitutes the entire PortAudio license; however,
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:341:
trailing whitespace.
* they can be incorporated into the canonical version. It is also
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:342:
trailing whitespace.
* requested that these non-binding requests be included along with the
warning: squelched 32389 whitespace errors
warning: 32394 lines add whitespace errors.
... is there any way you can supply a patch that doens't add trailing white
space to 1/2 ot the Pd
source?
thanks
M
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-12-02 09:07
Message:
raising priority, since the current state of affairs breaks all builds from
current git.
what i did:
- after the import of the portaudio-20121101 snapshot, some files where
missing to smoothly integrate with Pd's autotools system.
- so I re-imported portaudio with the missing files (and used the 20121126
snapshot, since that was the one i found on the portaudio website)
- I tried to keep the import to a minimum (but imported all files an
ordinary make would want to run a compilation)
- i added the new portaudio build-system to pd/configure.ac (so pa's
configure will get called automatically by Pd's configure)
- i also adjusted the link-path of libportaudio in pd/src/Makefile.am to
it's new location
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3591846&group_…
Patches item #3591986, was opened at 2012-12-02 20:15
Message generated for change (Tracker Item Submitted) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3591986&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: for set/label, only draw updates when the value changes
Initial Comment:
Lots of patches just hook up fast streams of events directly to GUI
objects. If these streams of events include multiples of the same value,
the GUI object draws each one. The first patch makes it so it only draws if the
value has changed. The second patch does the same for the labels.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3591986&group_…
Patches item #3585469, was opened at 2012-11-08 13:59
Message generated for change (Settings changed) made by jancsika1
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3585469&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Jonathan Wilkes (jancsika1)
Assigned to: Nobody/Anonymous (nobody)
Summary: Drop-in replacement for helpbrowser.tcl
Initial Comment:
Improved document browser and search engine for Pure Data internal/external documentation.
This is a refactored version of this GUI plugin:
http://puredata.info/Members/jancsika/searchplugindesc/
with the following mods:
* same key bindings as other dialogs
* withdrawing the window with <ctrl-w> or ESC will stop the current search in case it isn't finished
* clearer home page
----------------------------------------------------------------------
Comment By: Jonathan Wilkes (jancsika1)
Date: 2012-12-02 20:09
Message:
I revised this to be a gui-plugin, which is the form it will take in
Pd-extended. Consequently I'm closing this issue, but I'll leave it here
for people who want to try it on older versions of Pd.
----------------------------------------------------------------------
Comment By: Jonathan Wilkes (jancsika1)
Date: 2012-11-11 12:22
Message:
Made the navigation bar in a separate text widget that stays at the top
when scrolling
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3585469&group_…
Patches item #3585469, was opened at 2012-11-08 13:59
Message generated for change (Comment added) made by jancsika1
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3585469&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jonathan Wilkes (jancsika1)
Assigned to: Nobody/Anonymous (nobody)
Summary: Drop-in replacement for helpbrowser.tcl
Initial Comment:
Improved document browser and search engine for Pure Data internal/external documentation.
This is a refactored version of this GUI plugin:
http://puredata.info/Members/jancsika/searchplugindesc/
with the following mods:
* same key bindings as other dialogs
* withdrawing the window with <ctrl-w> or ESC will stop the current search in case it isn't finished
* clearer home page
----------------------------------------------------------------------
Comment By: Jonathan Wilkes (jancsika1)
Date: 2012-12-02 20:09
Message:
I revised this to be a gui-plugin, which is the form it will take in
Pd-extended. Consequently I'm closing this issue, but I'll leave it here
for people who want to try it on older versions of Pd.
----------------------------------------------------------------------
Comment By: Jonathan Wilkes (jancsika1)
Date: 2012-11-11 12:22
Message:
Made the navigation bar in a separate text widget that stays at the top
when scrolling
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3585469&group_…