Patches item #3412977, was opened at 2011-09-22 13:11
Message generated for change (Tracker Item Submitted) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3412977&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 9
Private: No
…
[View More]Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: replace MSW with _WIN32 (please please please)
Initial Comment:
We are starting to port Pd to another interesting platform, (Google Chrome Native Client NaCl) and yet again we'll have to wade thru the #ifdefs to figure out what we need. Especially painful are things like #ifndef MSW. Lots of people have wasted many hours on this stuff. This MSW macro is unnecessary since every compiler for Windows defines _WIN32 automatically. If _WIN32 ever disappears, we can easily add -D_WIN32, which is just as easy as doing -DMSW. Or just replace -DMSW with -D_WIN32.
Also, having the MSW as _WIN32 makes it easier to solve MinGW and Cygwin build issues where those platforms differ from MSVC++
This can be achieved with this one liner, which I've tested on Mac OS X, Ubuntu/Maverick, and Windows XP:
cd pure-data.git/src && sed -i 's|\(^\#.*if.*\) MSW|\1 _WIN32|' *.[ch]
You can see the lines that this regexp would change by running this:
cd pure-data.git/src && sed -n 's|\(^\#.*if.*\) MSW|\1 _WIN32|p' *.[ch]|less
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3412977&group_…
[View Less]
Patches item #3395874, was opened at 2011-08-21 21:05
Message generated for change (Comment added) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3395874&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pd-extended
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: …
[View More]Patrice Colet (patrco)
Assigned to: Hans-Christoph Steiner (eighthave)
Summary: get new build system working on MinGW
Initial Comment:
those patches allow to build pd with libtools on msys, like OSX and linux
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2011-09-22 16:02
Message:
Oh, I just had a thought, I think -DMSW should go into AM_CFLAGS, that
should do it. Which reminds me, we should probably also add
-DWINVER=0x0501 to set the min supported Windows to XP.
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2011-09-22 13:52
Message:
I couldn't have -DMSW working too
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-09-21 21:26
Message:
I boiled down these patches into
0001-get-pd.exe-linking-with-g-when-building-ASIO-on-Mi.patch except for
the libpd_la stuff, which I couldn't get working. That's all in
src-makefile.am-win32.patch so I left that patch, and deleted the other
two. patko, can you get the libpd_la DLL stuff working? Did you have that
working before? I was having trouble getting -DMSW to work
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3395874&group_…
[View Less]
Patches item #3395874, was opened at 2011-08-21 21:05
Message generated for change (Comment added) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3395874&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pd-extended
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: …
[View More]Patrice Colet (patrco)
Assigned to: Hans-Christoph Steiner (eighthave)
Summary: get new build system working on MinGW
Initial Comment:
those patches allow to build pd with libtools on msys, like OSX and linux
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2011-09-22 13:52
Message:
I couldn't have -DMSW working too
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-09-21 21:26
Message:
I boiled down these patches into
0001-get-pd.exe-linking-with-g-when-building-ASIO-on-Mi.patch except for
the libpd_la stuff, which I couldn't get working. That's all in
src-makefile.am-win32.patch so I left that patch, and deleted the other
two. patko, can you get the libpd_la DLL stuff working? Did you have that
working before? I was having trouble getting -DMSW to work
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3395874&group_…
[View Less]
Patches item #3395874, was opened at 2011-08-21 17:05
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3395874&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pd-extended
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted …
[View More]By: Patrice Colet (patrco)
>Assigned to: Hans-Christoph Steiner (eighthave)
>Summary: get new build system working on MinGW
Initial Comment:
those patches allow to build pd with libtools on msys, like OSX and linux
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-09-21 17:26
Message:
I boiled down these patches into
0001-get-pd.exe-linking-with-g-when-building-ASIO-on-Mi.patch except for
the libpd_la stuff, which I couldn't get working. That's all in
src-makefile.am-win32.patch so I left that patch, and deleted the other
two. patko, can you get the libpd_la DLL stuff working? Did you have that
working before? I was having trouble getting -DMSW to work
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3395874&group_…
[View Less]
Patches item #3335390, was opened at 2011-06-26 17:32
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3335390&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
>Status: Pending
>Resolution: Accepted
Priority: 5
Private:…
[View More] No
Submitted By: Patko (patricecolet)
Assigned to: Nobody/Anonymous (nobody)
Summary: mp3amp~ win32
Initial Comment:
this patch resolve a conflicting BOOL in unauthorized mp3amp~ win32 build
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-09-21 16:22
Message:
accepted with this commit:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3335390&group_…
[View Less]
Patches item #3286130, was opened at 2011-04-13 15:15
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3286130&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
>Status: Pending
>Resolution: Fixed
Priority: 5
Private: …
[View More]No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: cooled~ w32 build
Initial Comment:
not sure this only fix win32 build, could anyone try on linux, also without the #ifdef NT line 148?
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-09-21 16:19
Message:
I think this is fixed in the current unauthorized in pure-data SVN.
----------------------------------------------------------------------
Comment By: Patrice Colet (patrco)
Date: 2011-04-18 14:59
Message:
it doesn't crash on windows
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-04-18 13:18
Message:
since cooled~ only seems to crash on Mac OS X and Windows, I'm going to
hold off committing patches to it until its fixed. Or were you able to run
it under Windows?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3286130&group_…
[View Less]
Patches item #3293344, was opened at 2011-04-26 17:32
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3293344&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
Resolution: Works For Me
Priority: 5
Private: No
…
[View More]Submitted By: Yvan Volochine (elgusanorojo)
Assigned to: Miller Puckette (millerpuckette)
Summary: add ALT shortcuts to recentfiles
Initial Comment:
this just adds ALT-shortcuts to recentfiles (on linux and win32): 1 is latest opened file, 2 is second, etc..
this also removes some redundancy in ::pd_menus::update_recentfiles_on_menu
now that we have recentfiles support, this would be a nice addition (alongside with patch 3257602) to use keyboard shortcuts.
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-09-21 16:17
Message:
I edited the patch so that it does not add the numbers on Mac OS X, where
they don't make sense, and made the coding style match Pd. I reuploaded
this version.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-09-21 16:07
Message:
makes sense, accepted in Pd-extended
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3293344&group_…
[View Less]
Patches item #3293344, was opened at 2011-04-26 17:32
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3293344&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
>Resolution: Works For Me
Priority: 5
Private: …
[View More]No
Submitted By: Yvan Volochine (elgusanorojo)
>Assigned to: Miller Puckette (millerpuckette)
Summary: add ALT shortcuts to recentfiles
Initial Comment:
this just adds ALT-shortcuts to recentfiles (on linux and win32): 1 is latest opened file, 2 is second, etc..
this also removes some redundancy in ::pd_menus::update_recentfiles_on_menu
now that we have recentfiles support, this would be a nice addition (alongside with patch 3257602) to use keyboard shortcuts.
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-09-21 16:07
Message:
makes sense, accepted in Pd-extended
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3293344&group_…
[View Less]
Patches item #3395438, was opened at 2011-08-20 20:16
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3395438&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By:…
[View More] IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: minor compat fixes for new buildsystem
Initial Comment:
some problems have been reported [1], because the old configure based buildsystems in some rare cases conflicts with the new autotools based buildsystem.
the problem only appears on systems with case-insensitive filesystems (w32, osx), where the new buildsystem might be tricked into used src/makefile.in rather than src/Makefile.in
imo, the best solution would be to get rid of one of the build-systems entirely (which hopefully means to move to the shiny new one :-))
if this is not feasible for now, the attached patch proposes a workaround, by renaming the conflicting files in the new build system, so they won't clash on case-insensitive filesystems.
here's a longer explanation of the problem and its solution:
right now, there are 2 build-systems, based con autoconf:
- the olde one, living in ./src/, which uses ./src/makefile.in to generate
./src/makefile
- the new one livong in ./, which uses ./src/Makefile.am to generate
./src/Makefile.in to generate ./src/Makefile
the two buildsystems can co-exist happily, except if the host filesystem is
case-insensitive, in which case the "new" buildsystem might be tricked into
using (erroneously) ./src/makefile.in
this patch renames the src/Makefile* (for the new buildsystem) to
src/GNUmakefile*, so there is no name conflict on case-insensitive systems.
NOTE: GNU make will look for the makefiles GNUmakefile, makefile, and Makefile,
in that order. the "old" buildsystem is unaffected, as there will never be a
"GNUmakefile" (only "GNUmakefile.am" and eventually "GNUmakefile.in").
[1] https://sourceforge.net/tracker/?func=detail&atid=478070&aid=3395280&group_…
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2011-09-21 20:06
Message:
i totally agree with hans.
however, until the old system is ditched, i would still favour if these
workarounds could be added
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-09-21 19:59
Message:
I vote for ditching the old build system, I think its quite well tested
these days.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3395438&group_…
[View Less]
Patches item #3395438, was opened at 2011-08-20 14:16
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3395438&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted …
[View More]By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: minor compat fixes for new buildsystem
Initial Comment:
some problems have been reported [1], because the old configure based buildsystems in some rare cases conflicts with the new autotools based buildsystem.
the problem only appears on systems with case-insensitive filesystems (w32, osx), where the new buildsystem might be tricked into used src/makefile.in rather than src/Makefile.in
imo, the best solution would be to get rid of one of the build-systems entirely (which hopefully means to move to the shiny new one :-))
if this is not feasible for now, the attached patch proposes a workaround, by renaming the conflicting files in the new build system, so they won't clash on case-insensitive filesystems.
here's a longer explanation of the problem and its solution:
right now, there are 2 build-systems, based con autoconf:
- the olde one, living in ./src/, which uses ./src/makefile.in to generate
./src/makefile
- the new one livong in ./, which uses ./src/Makefile.am to generate
./src/Makefile.in to generate ./src/Makefile
the two buildsystems can co-exist happily, except if the host filesystem is
case-insensitive, in which case the "new" buildsystem might be tricked into
using (erroneously) ./src/makefile.in
this patch renames the src/Makefile* (for the new buildsystem) to
src/GNUmakefile*, so there is no name conflict on case-insensitive systems.
NOTE: GNU make will look for the makefiles GNUmakefile, makefile, and Makefile,
in that order. the "old" buildsystem is unaffected, as there will never be a
"GNUmakefile" (only "GNUmakefile.am" and eventually "GNUmakefile.in").
[1] https://sourceforge.net/tracker/?func=detail&atid=478070&aid=3395280&group_…
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-09-21 13:59
Message:
I vote for ditching the old build system, I think its quite well tested
these days.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3395438&group_…
[View Less]