Hi hello,
when i try to compile GEM under Ubuntu 9.10 i get a:
recordQT4L.cpp: In function lqt_file_type_t guess_qtformat(const char*): recordQT4L.cpp:96: error: invalid conversion from const char* to char* make[3]: *** [recordQT4L.o] Error 1 make[3]: Leaving directory `/root/src/Pd-0.41.4-extended/Gem/src/Pixes' make[2]: *** [Pixes] Error 2 make[2]: Leaving directory `/root/src/Pd-0.41.4-extended/Gem/src' make[1]: *** [/root/src/Pd-0.41.4-extended/Gem/src/Gem.pd_linux] Error 2 make[1]: Leaving directory `/root/src/Pd-0.41.4-extended/packages' make: *** [install] Error 2
I "fixed" it by making
static lqt_file_type_t guess_qtformat(const char* filename) be static lqt_file_type_t guess_qtformat(char* filename)
- i never use the pix_record object ..
cheers,
gnd/
gnd@itchybit.org wrote:
Hi hello,
when i try to compile GEM under Ubuntu 9.10 i get a:
recordQT4L.cpp: In function ‘lqt_file_type_t guess_qtformat(const char*)’: recordQT4L.cpp:96: error: invalid conversion from ‘const char*’ to ‘char*’ make[3]: *** [recordQT4L.o] Error 1 make[3]: Leaving directory `/root/src/Pd-0.41.4-extended/Gem/src/Pixes' make[2]: *** [Pixes] Error 2 make[2]: Leaving directory `/root/src/Pd-0.41.4-extended/Gem/src' make[1]: *** [/root/src/Pd-0.41.4-extended/Gem/src/Gem.pd_linux] Error 2 make[1]: Leaving directory `/root/src/Pd-0.41.4-extended/packages' make: *** [install] Error 2
I "fixed" it by making
static lqt_file_type_t guess_qtformat(const char* filename) be static lqt_file_type_t guess_qtformat(char* filename)
thanks for the bug-report. did you compile with "-Werror -Wall"? which version of g++ is included in karmic?
mdfgsr IOhannes
Hi all,
This fix is better: it only adds const-ness.
svn diff against a branches/0.92/ checkout.
--8<-- svn diff --8<-- Index: Gem/src/Pixes/recordQT4L.cpp =================================================================== --- Gem/src/Pixes/recordQT4L.cpp (revision 2988) +++ Gem/src/Pixes/recordQT4L.cpp (working copy) @@ -93,7 +93,7 @@ /* guess the file-format by inspecting the extension */ static lqt_file_type_t guess_qtformat(const char* filename) { - char * extension = strrchr(filename, '.'); + const char * extension = strrchr(filename, '.'); int i=0;
if(!extension) { --8<-- svn diff --8<--
Tested (as in, no compile errors..) on: + Ubuntu Karmic : g++ (Ubuntu 4.4.1-4ubuntu8) 4.4.1 + Debian Lenny : g++ (Debian 4.3.2-1.1) 4.3.2
Claude
Quoting "Claude Heiland-Allen" claudiusmaximus@goto10.org:
Hi all,
This fix is better: it only adds const-ness.
applied to 0.92 branch and TRUNK
thanks
fgamrsd IOhannes
---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.
-
Claude Heiland-Allen -
gnd＠itchybit.org -
IOhannes m zmölnig -
zmoelnig＠iem.at