[GEM-dev] Re: [GEM-cvs] Gem/src/Base GemPixConvertAltivec.cpp, NONE, 1.1 GemPixConvert.h, NONE, 1.1 GemPixConvertSSE2.cpp, NONE, 1.1 GemPixUtil.cpp, 1.48, 1.49 GemPixUtil.h, 1.46, 1.47
On Mar 22, 2006, at 7:59 AM, IOhannes m zmölnig wrote:
Modified Files: GemPixUtil.cpp GemPixUtil.h Added Files: GemPixConvertAltivec.cpp GemPixConvert.h GemPixConvertSSE2.cpp Log Message: added SSE2-optimized RGBA2YUV conversion; since GemPixUtil.cpp has grownso huge, i have outsourced the optimized color conversion routines into separate files GemPixConvertAltivec.cpp, GemPixConvertSSE2.cpp; obviously this has only been tested on linux and mightwork (or not) on osx
...YAY!!! Thanks for taking this on, GemPixUtil was becoming incredibly unwieldy...also very exciting to see some SSE2 coming onboard (less for me to do when I get a macbook!)...
...I've got it compiling here after re-arranging some "code in progress" on my end, but I'm also going ahead moving the YUV422_to_YV12_altivec() from [pix_2pdp] into GemPixConvertAltivec.cpp...this requires a bit of a rewrite of the function interfaces, no prob, but it does bring up a question:
How should we now require header inclusion to use this? Should we require GemPixConvert.h to be added, or should it just be automatically included via GemPixUtil.h? I ask this because pix_2pdp.h includes GemPixObj.h, which includes GemPixUtil.h, but that's currently not including the new conversion files...
jamie
On Mar 22, 2006, at 2:22 PM, james tittle wrote:
How should we now require header inclusion to use this? Should we require GemPixConvert.h to be added, or should it just be automatically included via GemPixUtil.h? I ask this because pix_2pdp.h includes GemPixObj.h, which includes GemPixUtil.h, but that's currently not including the new conversion files...
...nevermind: I came up with a fix that works fine here in gem and with gem2pdp/pix_2pdp/pdp2gem...will commit it when I get home!
jamie
james tittle wrote:
On Mar 22, 2006, at 7:59 AM, IOhannes m zmölnig wrote:
How should we now require header inclusion to use this? Should we require GemPixConvert.h to be added, or should it just be automatically included via GemPixUtil.h? I ask this because pix_2pdp.h includes GemPixObj.h, which includes GemPixUtil.h, but that's currently not including the new conversion files...
personally i would prefer if GemPixConvert.h would have to be included explicitly: most pix-code written will not need to know the underlying conversion routines; things derived from GemPixObj should not know them at all (that is what we have the from*()-routines for) and adding a new optimized converter should not retrigger the re-compilation of each and every pix-object (this is time consuming)
otoh, i see that there are special cases like with pix_2pdp where you need low level access. if it is possible to include both headers (and i don't see a (non-social) reason why this should not work), then think it is the cleaner way.
mfg.asdf. IOhannes
-
IOhannes m zmoelnig -
james tittle