I'm not sure if this should stay on gem-dev or what...
Anyhow I've traced the issue and here is where the problem lies. My original code outputted the symbol like so:
sys_vgui("pd [concat entry%p output [.x%x.c.s%x get 0.0 end] \;]\n", x, x->x_glist, x);
Johannes made the valiant effort to escape "," and ";" so that are not seperated into descrete messages in PD. Basically meaning you can't type a message for the entry widget containing messages for it, and you can't send to a receive directly from the widget. I think this is ok, but I did not see much reason to change it. His change looks like this:
sys_vgui("pd [concat entry%p output [string map {"," "\\," ";" "\\;} [.x%x.c.s%x get 0.0 end]]" \;]\n", x, x->x_glist, x);
I tried removing the
"
at:
end]]"
thinking that may be the problem, but indeed I can't make this code work with PD complaining about unmatches quotes. Worse than that is that the code works fine on my 8.4 interpreter, just not in PD...
So Johannes, since you introduced the bug, care to fix it?
Also the good news is that my original "unfixed" code worked fine on PD 0.39, so the issue was only Johannes's changes. Which also explains why popup works on 0.39, since it uses the same code to output.
Johannes, I really do appreciate your effort here, thanks for logging your changes also. Please do let me know when you make such future changes in an email though so I can make sure they work myself soon after you commit them.
Since you did write the extra code for escaping I'm sure your the best person to fix it.
Unless someone sees any reason why not I'll change the code back to the way it used to be and re-commit. I fear how many distros are running out there with broken [entry]s. :( Looks like it was commited in August.
Johannes, does this code really work on your machine?!?!! It certainly does not work on my linux machine, and the mac, and Han's reported it also not working on windows.
Johannes please reply to this email if you would not like me to recommit back to the code before your changes! (and provide a reason why) just to make sure you have the revision somewhere on your machine, though I guess you can get it from CVS. (revision 1.4 would be yours)
Thanks all for reporting this!
b.
Hans-Christoph Steiner wrote:
By the way, the same thing happens with the Windows build, which is built against Tcl/Tk 8.4.11
.hc
On Dec 3, 2005, at 1:28 PM, Hans-Christoph Steiner wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
I assume by not working, you mean that it doesn't output text. But everything else about it seems to work fine.
How did you compile [entry]? The only difference that I can see between externals/bbogart/entry/makefile and externals/build/darwin/makefile is this:
externals/build/darwin/makefile: LDFLAGS = -bundle -bundle_loader $(PDEXECUTABLE) -L/sw/lib
externals/bbogart/entry/makefile cc -bundle -undefined suppress -flat_namespace -o $*.pd_darwin $*.o
The compiled size is much different:
hans@sla:entry > ls -l entry.pd_darwin
- -rw-r--r-- 1 hans staff 14268 Dec 3 13:09
entry.pd_darwin hans@sla:entry > ls -l /Applications/Pd-0.38.4-extended-RC5.app/Contents/Resources/extra/ entry.pd_darwin
- -rwxr-xr-x 1 hans admin 34960 Nov 27 00:09
/Applications/Pd-0.38.4-extended-RC5.app/Contents/Resources/extra/ entry.pd_darwin*
I tried the directly compiled version (i.e. the smaller one) and it behaves the same, no text output).
What version of Tcl/Tk did you use for pixelTANGO? I am compiling against 8.4.9.
.hc
On Dec 3, 2005, at 11:56 AM, B. Bogart wrote:
Hi James and Hans,
Seems that the version of [entry] included in the RC4 and RC5 installers is broken on OSX. I wanted to send this email before looking into it further. The fix is to use the entry I compiled for OSX included in pixelTANGO.
Just replace the RC4/5 entry with the pixelTANGO entry.pd_darwin and you should be in shape.
I'll try and figure out why hans's build is created a broken binary somehow..? My entry was just compiled from CVS!!
I'll look into this as soon as I can.
Thanks for noticing Jamie!
b.
james tittle wrote:
hey ben,
...bringing this back:
On Oct 20, 2005, at 6:23 AM, B. Bogart wrote:
Indeed it seems entry is broken on .39, I'm still using .38
Anyone feel free to take a look and see whats up, as I'll probably not have time to look at it any time soon. I guess something in gcanvas is not working as in 38...
...grrr, turns out I can't get it to behave with pd-extended-RC5, which is 0.38-4...so any idea which pd it last worked on? When hitting bang, I get "unmatched open quote in list"...also, does this mean it just outputs the text as a list of symbols?
james
GEM-dev mailing list GEM-dev@iem.at http://lists.puredata.info/listinfo/gem-dev
GEM-dev mailing list GEM-dev@iem.at http://lists.puredata.info/listinfo/gem-dev
"The arc of history bends towards justice." - Dr. Martin Luther King, Jr.