On 2014-01-07 00:07, me.grimm wrote:
cool. just do a pull request once you are ready
done! compiled fine after the changes....
(and nobody else was faster...)
ha! i guess not!!!
thanks for the quick fixes. however, some of the patches are not in a form that i can accept :-(
+ ad5c6cd - adds a file "gemdefaultwindow.pd" which - has nothing to do with fixing the compilation problem - is generated during the build process (and will differ on various platforms) and is thus intentionally not included in the repository
+ 31b8bc0 - simply disables and thus breaks the functionality of the method it modifies
a more cosmetic remark: i would prefer to have more descriptive titles of the commits. e.g. "remove default arguments from definitions" rather than "Fix on error: addition of default argument on redeclaration makes this". the problem is mainly, that the title of the commit (the first line in the commit message) should be terse and not contain more than 50 characters.
these things are easy enough to fix (do a *mixed* reset of your branch to the split-point and factor new commits from there). i could do that myself, but then the authorship of the patches would be lost and i'd rather leave that intact, so you get proper credits for your work.
fgadsr IOhannes