Patches item #3596865, was opened at 2012-12-17 02:58 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3596865...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata-dev Group: None Status: Open Resolution: None Priority: 7 Private: No Submitted By: IOhannes m zmölnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) Summary: re-adding sys_close() for ABI compatibility

Initial Comment: in a recent patch to Pd-0.44, the sys_close() function was removed (and replaced by a macro to close()) on non-w32 platforms.

this breaks ABI-compatibility for externals that use sys_close() and have been compiled against Pd-0.43 (e.g. Gem, as currently packaged in Debian).

the attached patch re-introduces sys_close() and also provides implementations for sys_open(), sys_fopen() and sys_fclose() on non-w32 platforms.

the patch reduces the total number of ifdefs in the code :-)

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)

Date: 2012-12-17 07:43

Message: makes sense to me, I'm including it in Pd-extended

----------------------------------------------------------------------

Comment By: IOhannes m zmölnig (zmoelnig) Date: 2012-12-17 03:05

Message: raising priority since it really prevents some externals from being loaded

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3596865...