Hey Thomas & Franks + any other memento users.
I found a bug in pool 0.2.1pre where if a value is set as scientific notation (ie 1e-09) and saved in a file, when the file is loaded the value is seen as a symbol and not a float.
This is quite anoying when using memento because magically out of nowhere some params don't update because they are not getting floats at all!
It would be great to get this fixed soon, since I'm almost satisfied with my memento use in pixelTANGO.
See attached patch for an example.
Thanks, Ben
#N canvas 436 383 467 407 10; #X msg 26 91 set 0 $1; #X msg 169 223 get 0; #X obj 77 251 pool test; #X obj 60 349 hsl 128 15 0 127 0 0 empty empty empty -2 -6 0 8 -262144 -1 -1 0 1; #X msg 26 68 1e-09; #X msg 69 121 save test.dat; #X msg 146 189 load test.dat; #X floatatom 92 316 5 0 0 0 - - -; #X msg 117 153 reset; #X symbolatom 126 287 10 0 0 0 - - -; #X text 19 13 Pool sends Scientific notation numbers out as symbols (rather than floats) after loading from file. Seems to store them fine interally. (without saving/reloading); #X text 97 90 1 Set "0" to Scientific Notation Float; #X text 175 120 2 Save data; #X text 172 156 3 Clear Data; #X text 252 190 4 Load data; #X text 213 225 5 Get Value; #X connect 0 0 2 0; #X connect 1 0 2 0; #X connect 2 0 7 0; #X connect 2 0 3 0; #X connect 2 0 9 0; #X connect 4 0 0 0; #X connect 5 0 2 0; #X connect 6 0 2 0; #X connect 8 0 2 0;
Hallo, B. Bogart hat gesagt: // B. Bogart wrote:
I found a bug in pool 0.2.1pre where if a value is set as scientific notation (ie 1e-09) and saved in a file, when the file is loaded the value is seen as a symbol and not a float.
This is quite anoying when using memento because magically out of nowhere some params don't update because they are not getting floats at all!
The easy fix would be, to accept scientific notation as float.
But I think, this might be a general problem with [pool]: It doesn't care about data types at all, however as soon as the data comes out again, it is used typed in Pd. Maybe a solution could be to add types at least for the basic pd types symbol, float and lists. Hoewver, handling lists of mixed float and symbol values still isn't solved with these alone.
Ciao
Hi Ben, thanks for the report... i fixed and optimized atom parsing.. it should be in the SF CVS tomorrow. best greetings, Thomas
----- Original Message ----- From: "B. Bogart" ben@ekran.org To: "pd-dev" pd-dev@iem.at Sent: Wednesday, November 17, 2004 5:06 AM Subject: [PD-dev] pool bug messing with my memento!
Hey Thomas & Franks + any other memento users.
I found a bug in pool 0.2.1pre where if a value is set as scientific
notation
(ie 1e-09) and saved in a file, when the file is loaded the value is seen
as a
symbol and not a float.
This is quite anoying when using memento because magically out of nowhere
some
params don't update because they are not getting floats at all!
It would be great to get this fixed soon, since I'm almost satisfied with
my
memento use in pixelTANGO.
See attached patch for an example.
Thanks, Ben
---------------------------------------------------------------------------- ----
#N canvas 436 383 467 407 10; #X msg 26 91 set 0 $1; #X msg 169 223 get 0; #X obj 77 251 pool test; #X obj 60 349 hsl 128 15 0 127 0 0 empty empty empty -2 -6 0 8 -262144 -1 -1 0 1; #X msg 26 68 1e-09; #X msg 69 121 save test.dat; #X msg 146 189 load test.dat; #X floatatom 92 316 5 0 0 0 - - -; #X msg 117 153 reset; #X symbolatom 126 287 10 0 0 0 - - -; #X text 19 13 Pool sends Scientific notation numbers out as symbols (rather than floats) after loading from file. Seems to store them fine interally. (without saving/reloading); #X text 97 90 1 Set "0" to Scientific Notation Float; #X text 175 120 2 Save data; #X text 172 156 3 Clear Data; #X text 252 190 4 Load data; #X text 213 225 5 Get Value; #X connect 0 0 2 0; #X connect 1 0 2 0; #X connect 2 0 7 0; #X connect 2 0 3 0; #X connect 2 0 9 0; #X connect 4 0 0 0; #X connect 5 0 2 0; #X connect 6 0 2 0; #X connect 8 0 2 0;
-
B. Bogart -
Frank Barknecht -
Thomas Grill