PD_VERSION_CODE was added and shows up in the grep output as a second line. The fix is to simply filter it out when grabbing the values. A fix is here:
https://github.com/pure-data/pure-data/pull/2298
On May 8, 2024, at 9:27 PM, pd-dev-request@lists.iem.at wrote:
Message: 4 Date: Wed, 8 May 2024 21:29:43 +0200 From: Miller Puckette <mpuckette@cloud.ucsd.edu mailto:mpuckette@cloud.ucsd.edu> To: Alexandre Torres Porres <porres@gmail.com mailto:porres@gmail.com> Cc: pd-dev <pd-dev@lists.iem.at mailto:pd-dev@lists.iem.at> Subject: Re: [PD-dev] trouble with Pd version strings Message-ID: <58043f32-0a8d-4aa9-9a03-a070d6c4594c@cloud.ucsd.edu mailto:58043f32-0a8d-4aa9-9a03-a070d6c4594c@cloud.ucsd.edu> Content-Type: text/plain; charset=UTF-8; format=flowed
No, it's a conflict between doc/Makefile.am and recent changes in m_pd.h.? doc/Makefile.am is quite fragile and a seemingly reasonablechange to m_pd.h broke it.? I have to get to a couple of other things now but will try to figure out what to do tomorrow... possibly just take the version-number-setting hack out of the doc :)
cheers
M
-------- Dan Wilcox danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
On 5/8/24 22:50, Dan Wilcox wrote:
PD_VERSION_CODE was added and shows up in the grep output as a second line. The fix is to simply filter it out when grabbing the values. A fix is here:
i missed your PR and submitted my own version for the fix, with a slightly different approach: - use autotools $(VERSION) rather than doing the brittle calculations ourselves (this shifts the authoritative source for the version from m_pd.h to configure.ac; i think this is no great loss, as they must be in sync anyhow) - also implement a fix for the non-autotools buildsystems (src/makefile.*) - here i tightened the search filter to only include #defines of (e.g.) 'PD_MAJOR_VERSION' itself, and not some arbitrary line that contains the "PD_MAJOR_VERSION" string (and filtering out known false-positives, like lines containing also "PD_VERSION_CODE")
https://github.com/pure-data/pure-data/pull/2299
gfmdsr IOhannes
-
Dan Wilcox -
IOhannes m zmölnig