Patches item #1244757, was opened at 2005-07-25 22:26 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1244757...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: None Status: Open Resolution: None Priority: 5 Submitted By: IOhannes m zmölnig (zmoelnig) Assigned to: Nobody/Anonymous (nobody) Summary: {open,save}panel with settable path
Initial Comment: this patch (against the current 25/07/2005) HEAD of the CVS (pd-0.39test4) allows the current path of [openpanel]/[savepanel] to be set. once the path is set, it will not change anymore "automatically"; however, this patch gives even more wird tcl/tk output about "unknown commands" than the unpatched version does. there is clearly some bug in the u_main.tk
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1244757...
SourceForge.net wrote:
Initial Comment: this patch (against the current 25/07/2005) HEAD of the CVS (pd-0.39test4) allows the current path of [openpanel]/[savepanel] to be set. once the path is set, it will not change anymore "automatically"; however, this patch gives even more wird tcl/tk output about "unknown commands" than the unpatched version does. there is clearly some bug in the u_main.tk
which reminds me: could someone fix the u_main.tk so that it stops spitting out errors now and then. i guess matju or somebody has already done so, but then continued and remade everything.... most likely it is just a matter of proper escaping/quoting.
just in case somebody doesn't know how to reproduce it: create an [openpanel], bang it, select a filename and click "open": you will get a "unknown command: .e" (or similar) at the stderr.
mfg.a.sdrt IOhannes
PS: btw, does anybody know how to suppress those tabs in the subjects of sf-tracker mails ?
On Tue, 26 Jul 2005, IOhannes m zmoelnig wrote:
just in case somebody doesn't know how to reproduce it: create an [openpanel], bang it, select a filename and click "open": you will get a "unknown command: .e" (or similar) at the stderr.
FYI, I can't reproduce it on Pd version 0.39 TEST 4 Does it need to be a specific filename, with spaces or such ?
Guenter
mfg.a.sdrt IOhannes
PS: btw, does anybody know how to suppress those tabs in the subjects of sf-tracker mails ?
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
Guenter Geiger wrote:
On Tue, 26 Jul 2005, IOhannes m zmoelnig wrote:
just in case somebody doesn't know how to reproduce it: create an [openpanel], bang it, select a filename and click "open": you will get a "unknown command: .e" (or similar) at the stderr.
FYI, I can't reproduce it on Pd version 0.39 TEST 4 Does it need to be a specific filename, with spaces or such ?
my file-names do not look special at all: e.g. "/vmlinuz" will yield the same error as "/Net/iem/Users/zmoelnig/pd/Gem/examples/data/fractal.JPG"
it appears on my machines (all of them) at least with pd-0.37-0, pd-0.39test4, pd-0.38-4 (debian package), pd-0.38-4 (self made)
the exact error message i get is: invalid command name "e"
this error does not appear in pd's built in console but at the stderr (this is: the xterm is start pd from)
it appears to be coming after the pdtk_opendialog() is executed (this is: putting a 'puts "done"' at the end of pdtk_opendialog will print: done invalid command name "e"
it seems like with vanilla pd it is always "e".
with my settable-path patch applied, the errors get weirder: invalid command name "ength" (once i even got "-width")
but normally the invalid commands are just some reference like "1213f8.t8121ce0R" (this is a real quote)
mfg.a.sdr IOhannes
On Tue, 26 Jul 2005, IOhannes m zmoelnig wrote:
it appears on my machines (all of them) at least with pd-0.37-0, pd-0.39test4, pd-0.38-4 (debian package), pd-0.38-4 (self made)
You are sure ? Only openpanel and bang in a patch, no guis, externals ?
The invalid command name might come from a GUI sending a bogus command to tcl when doing an update after the patch got a redraw when closing the openpanel dialog. Can you send an example patch that shows this behaviour ?
Guenter
the exact error message i get is: invalid command name "e"
this error does not appear in pd's built in console but at the stderr (this is: the xterm is start pd from)
it appears to be coming after the pdtk_opendialog() is executed (this is: putting a 'puts "done"' at the end of pdtk_opendialog will print: done invalid command name "e"
it seems like with vanilla pd it is always "e".
with my settable-path patch applied, the errors get weirder: invalid command name "ength" (once i even got "-width")
but normally the invalid commands are just some reference like "1213f8.t8121ce0R" (this is a real quote)
mfg.a.sdr IOhannes
Guenter Geiger wrote:
On Tue, 26 Jul 2005, IOhannes m zmoelnig wrote:
You are sure ? Only openpanel and bang in a patch, no guis, externals ?
yes.
The invalid command name might come from a GUI sending a bogus command to tcl when doing an update after the patch got a redraw when closing the openpanel dialog. Can you send an example patch that shows this behaviour ?
i attached one (that is surprisingly small ;-))
my xterm looks like: <xterm> sh-3.00$ /usr/bin/pd -verbose openbug.pd Pd version 0.38.4 compiled 17:55:45 Apr 8 2005 port 5403 TCL_LIBRARY="/usr/lib/pd/tcl/library" TK_LIBRARY="/usr/lib/pd/tk/library" "/usr/lib/pd/bin/pd-gui" 5403 Waiting for connection request... ... connected OSS: requested audio buffer size 8820 limited to 8192 OSS: issuing first ADC 'read' ... ...done. invalid command name "e" </xterm>
my pd-console looks like <pd> reading startup file: /Net/iem/Benutzer/zmoelnig/.pdrc input channels = 2, output channels = 2 Opened Alsa Client 128 in:1 out:1 input channels = 2, output channels = 2 opened /dev/dsp for reading and writing
opened audio output on /dev/dsp; got 2 channels bytes per sample = 2 setting nfrags = 8, fragsize 1024
audiobuffer set to 50 msec opened audio input device /dev/dsp; got 2 channels bytes per sample = 2 tried /tmp/openbug.pd and succeeded </pd>
i have installed (on the machine i am currently on): puredata (0.38.4+amidi-3) unstable; urgency=low tcl8.4 (8.4.9-1) unstable; urgency=low tk8.4 (8.4.9-1) unstable; urgency=low
my setup is a sarge/etch mix.
mfg.asdr. IOhannes
#N canvas 0 0 450 300 10; #X obj 105 106 openpanel; #X msg 105 81 bang; #X connect 1 0 0 0;
On Tue, 26 Jul 2005, IOhannes m zmoelnig wrote:
i attached one (that is surprisingly small ;-))
Yeah, mine is a bit bigger, I attached it too ... you will see :)
Guenter
my xterm looks like:
<xterm> sh-3.00$ /usr/bin/pd -verbose openbug.pd Pd version 0.38.4 compiled 17:55:45 Apr 8 2005 port 5403 TCL_LIBRARY="/usr/lib/pd/tcl/library" TK_LIBRARY="/usr/lib/pd/tk/library" "/usr/lib/pd/bin/pd-gui" 5403 Waiting for connection request... ... connected OSS: requested audio buffer size 8820 limited to 8192 OSS: issuing first ADC 'read' ... ...done. invalid command name "e" </xterm>
my pd-console looks like
<pd> reading startup file: /Net/iem/Benutzer/zmoelnig/.pdrc input channels = 2, output channels = 2 Opened Alsa Client 128 in:1 out:1 input channels = 2, output channels = 2 opened /dev/dsp for reading and writing
opened audio output on /dev/dsp; got 2 channels bytes per sample = 2 setting nfrags = 8, fragsize 1024
audiobuffer set to 50 msec opened audio input device /dev/dsp; got 2 channels bytes per sample = 2 tried /tmp/openbug.pd and succeeded
</pd>
i have installed (on the machine i am currently on): puredata (0.38.4+amidi-3) unstable; urgency=low tcl8.4 (8.4.9-1) unstable; urgency=low tk8.4 (8.4.9-1) unstable; urgency=low
my setup is a sarge/etch mix.
mfg.asdr. IOhannes
Hi,
The bug seems to be in the message object, if you put the message_float() function call at the end of static void message_click() instead of the beginning, the problem goes away.
I am not sure if this is a fix or a workaround, though, as I can't fully understand what causes the problem :( someone should investigate.
Guenter
On Tue, 26 Jul 2005, IOhannes m zmoelnig wrote:
Guenter Geiger wrote:
On Tue, 26 Jul 2005, IOhannes m zmoelnig wrote:
You are sure ? Only openpanel and bang in a patch, no guis, externals ?
yes.
The invalid command name might come from a GUI sending a bogus command to tcl when doing an update after the patch got a redraw when closing the openpanel dialog. Can you send an example patch that shows this behaviour ?
i attached one (that is surprisingly small ;-))
my xterm looks like:
<xterm> sh-3.00$ /usr/bin/pd -verbose openbug.pd Pd version 0.38.4 compiled 17:55:45 Apr 8 2005 port 5403 TCL_LIBRARY="/usr/lib/pd/tcl/library" TK_LIBRARY="/usr/lib/pd/tk/library" "/usr/lib/pd/bin/pd-gui" 5403 Waiting for connection request... ... connected OSS: requested audio buffer size 8820 limited to 8192 OSS: issuing first ADC 'read' ... ...done. invalid command name "e" </xterm>
my pd-console looks like
<pd> reading startup file: /Net/iem/Benutzer/zmoelnig/.pdrc input channels = 2, output channels = 2 Opened Alsa Client 128 in:1 out:1 input channels = 2, output channels = 2 opened /dev/dsp for reading and writing
opened audio output on /dev/dsp; got 2 channels bytes per sample = 2 setting nfrags = 8, fragsize 1024
audiobuffer set to 50 msec opened audio input device /dev/dsp; got 2 channels bytes per sample = 2 tried /tmp/openbug.pd and succeeded
</pd>
i have installed (on the machine i am currently on): puredata (0.38.4+amidi-3) unstable; urgency=low tcl8.4 (8.4.9-1) unstable; urgency=low tk8.4 (8.4.9-1) unstable; urgency=low
my setup is a sarge/etch mix.
mfg.asdr. IOhannes
Guenter Geiger wrote:
Hi,
The bug seems to be in the message object, if you put the message_float() function call at the end of static void message_click() instead of the beginning, the problem goes away.
yes indeed that fixes it. btw, [bng] does it exactly like this (starting the whole visual-feedback before the actual "control")
I am not sure if this is a fix or a workaround, though, as I can't fully understand what causes the problem :( someone should investigate.
me neither. but i want to mention, that sometimes the [bang( hung when highlighted (with my openpanel-patch); this could have put me on the right track earlier.
mf.asd.r IOhannes
PS: off(line) for a 3week holiday for now; enjoy!
Johannes, could you send me a test patch so I can try it on my sarge machine?
B>
IOhannes m zmoelnig wrote:
Guenter Geiger wrote:
On Tue, 26 Jul 2005, IOhannes m zmoelnig wrote:
just in case somebody doesn't know how to reproduce it: create an [openpanel], bang it, select a filename and click "open": you will get a "unknown command: .e" (or similar) at the stderr.
FYI, I can't reproduce it on Pd version 0.39 TEST 4 Does it need to be a specific filename, with spaces or such ?
my file-names do not look special at all: e.g. "/vmlinuz" will yield the same error as "/Net/iem/Users/zmoelnig/pd/Gem/examples/data/fractal.JPG"
it appears on my machines (all of them) at least with pd-0.37-0, pd-0.39test4, pd-0.38-4 (debian package), pd-0.38-4 (self made)
the exact error message i get is: invalid command name "e"
this error does not appear in pd's built in console but at the stderr (this is: the xterm is start pd from)
it appears to be coming after the pdtk_opendialog() is executed (this is: putting a 'puts "done"' at the end of pdtk_opendialog will print: done invalid command name "e"
it seems like with vanilla pd it is always "e".
with my settable-path patch applied, the errors get weirder: invalid command name "ength" (once i even got "-width")
but normally the invalid commands are just some reference like "1213f8.t8121ce0R" (this is a real quote)
mfg.a.sdr IOhannes
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
Thanks... it turned out pd_readsocket (in t_tkcnd.c) was getting called reentrantly, which I didn't anticipate when writing it. Should now be fixed in CVS.
cheers Miller
On Tue, Jul 26, 2005 at 12:59:25PM +0200, IOhannes m zmoelnig wrote:
Guenter Geiger wrote:
On Tue, 26 Jul 2005, IOhannes m zmoelnig wrote:
just in case somebody doesn't know how to reproduce it: create an [openpanel], bang it, select a filename and click "open": you will get a "unknown command: .e" (or similar) at the stderr.
FYI, I can't reproduce it on Pd version 0.39 TEST 4 Does it need to be a specific filename, with spaces or such ?
my file-names do not look special at all: e.g. "/vmlinuz" will yield the same error as "/Net/iem/Users/zmoelnig/pd/Gem/examples/data/fractal.JPG"
it appears on my machines (all of them) at least with pd-0.37-0, pd-0.39test4, pd-0.38-4 (debian package), pd-0.38-4 (self made)
the exact error message i get is: invalid command name "e"
this error does not appear in pd's built in console but at the stderr (this is: the xterm is start pd from)
it appears to be coming after the pdtk_opendialog() is executed (this is: putting a 'puts "done"' at the end of pdtk_opendialog will print: done invalid command name "e"
it seems like with vanilla pd it is always "e".
with my settable-path patch applied, the errors get weirder: invalid command name "ength" (once i even got "-width")
but normally the invalid commands are just some reference like "1213f8.t8121ce0R" (this is a real quote)
mfg.a.sdr IOhannes
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
-
B. Bogart -
Guenter Geiger -
IOhannes m zmoelnig -
Miller Puckette -
SourceForge.net