Patches item #1881907, was opened at 2008-01-29 08:24 Message generated for change (Comment added) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1881907...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: None
Status: Closed Resolution: Accepted
Priority: 5 Private: No Submitted By: IOhannes m zmlnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) Summary: more t_float/t_sample fixes
Initial Comment: pd-0.41 has a lot of cleanup regarding the types of numbers (see patch-#1822001 'use of t_float/t_sample instead of "float"')
however, some things have been left out by the original patches, here are some more:
m_pd.h: seems like the t_float-enabling of postfloat() was forgotten in the declaration
d_math.c: here it is the other way round: while the declarations in m_pd.h use t_float, the definitions do not
g_array.c g_template.c: here my patch was a bit rash: scanf() doesn't like to get pointers to double (if "t_float" is set to "double") if the format string is really "%f" (or "%g"); the new patches use an internal _double_ variable and the format string "%lf" ("%lg"); the _double_ variable is then cast to (t_float). this should be on the save side; the alternatives would have been using an internal _float_ variable, and/or to change the format-string depending on the used type.
d_fftroutine.c: this needed a bit more changes, but luckily enough, the original code already was aware of possible type-changes; i have currently used "t_float" (in line with the m_pd.h declaration of "pd_fft()"), but i am not sure whether this really should be "t_sample". changes should be rather simple: just change the defines of FLOAT and SAMPLE in the beginning... (and don't forget the declaration in m_pd.h)
with these changes, Pd compiles without (additional) warnings with t_float/t_floatarg and t_sample set to "double". (there is still work to do in d_ugen.c though, to make it really usable...)
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2010-07-24 19:17
Message: I adopted changes where they looked right.. I then tried actually running Pd in 64 bit and found lots of problems. So I'll mark this 'accepted' but there's more to do here.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-01-01 17:43
Message: it seems that some of this stuff has been accepted and some not, perhaps they should be reformated?
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig) Date: 2008-01-29 09:54
Message: Logged In: YES user_id=564396 Originator: YES
File Added: sigmund~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig) Date: 2008-01-29 09:12
Message: Logged In: YES user_id=564396 Originator: YES
added a fix for extra/sigmung~ File Added: sigmund~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig) Date: 2008-01-29 09:11
Message: Logged In: YES user_id=564396 Originator: YES
added a fix for pique File Added: pique.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig) Date: 2008-01-29 09:09
Message: Logged In: YES user_id=564396 Originator: YES
added a fix for extra/lrshift~
File Added: lrshift~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig) Date: 2008-01-29 09:08
Message: Logged In: YES user_id=564396 Originator: YES
added a fix for extra/loop~
(the core code originally was not dependent on Pd; i therefore introduced an additional "#define t_sample float" in case it is not compiled for Pd) File Added: loop~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig) Date: 2008-01-29 09:06
Message: Logged In: YES user_id=564396 Originator: YES
added a fix for extra/choice File Added: choice.c.diff
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1881907...
-
SourceForge.net