Bugs item #2127854, was opened at 2008-09-25 03:55 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2127854...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: pd-extended Group: None

Status: Closed Resolution: Fixed

Priority: 5 Private: No Submitted By: IOhannes m zmlnig (zmoelnig) Assigned to: Hans-Christoph Steiner (eighthave) Summary: autobuild: partconv~

Initial Comment: partconv~ has stopped the auto-builds for a rather long period now.

please somene do one of the following: - remove [partconv~] from the auto-build system - install fftw on the auto-build machines - make the dependency on fftw optional

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)

Date: 2008-10-07 14:03

Message: all of the build servers have fftw3 now AFAIK, so I am closing this.

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave) Date: 2008-10-01 05:08

Message: I agree that partconv~ shouldn't be built if fftw3 isn't found, but that should be handled by the build system (i.e. something like ./configure), not the compiler.

As for including it in Pd-extended, I think it is more useful to have a working partconv~ that is not perfectly optimized than none at all. People who can figure out how to build fftw3 for their CPU, then build partconv~ using that fftw3 can easily figure out how to replace the included partconv~.

----------------------------------------------------------------------

Comment By: IOhannes m zmlnig (zmoelnig) Date: 2008-10-01 03:43

Message: ok i have reverted my change.

however, the #ifdef's do not make the object more unuseable then how it already is, if fftw3 is missing, so i don't fully understand the arguing.

attached is a simplified patch that fully disables the object when no HAVE_FFTW3_H is not defined (leaving only the _setup function to tell the user what went wrong) File Added: partconv~.diff

----------------------------------------------------------------------

Comment By: christopher clepper (cclepper) Date: 2008-09-30 14:08

Message: FFTW is required for partconv~ to work so the #ifdef additions will make it unusable. FFTW is tricky to include with binaries since it has such extensive optimizations for each CPU. You could attempt to statically link a generic x87 version, but that would result in pretty poor performance and partconv~ needs really good code to work with longer impulse responses.

I would recommend leaving it out of the autobuild and letting those who want it build it on their own. The other option would be to make some static linked binaries for various CPUs and stick them in the build

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave) Date: 2008-09-30 05:42

Message: does partconv~ work with out FFTW3? If this just builds a dummy object, I don't think it is useful to include this hack.

----------------------------------------------------------------------

Comment By: IOhannes m zmlnig (zmoelnig) Date: 2008-09-30 03:43

Message: i have added a number of #ifdef's to the original code (i hope nobody minds), so now the object should compile again on systems without fftw3 installed.

the drawback is, that you have to explicitely define the HAVE_FFTW3_H at the command-line in order to enable it! (so hack the externals/Makefile which i don't dare)

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave) Date: 2008-09-26 12:00

Message: I am working on it, but I have limited access to that machine, since it is a lab machine of a university. Plus there are still some bugs in Apple's gcc causing fftw3 not to build., so hopefully that's been fixed.

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2127854...