Hi all,
Tried sending a couple of e-mails not realizing I am not subscribed to dev list... DOH! So, please prepare for a small salvo of e-mails :-)
Topic #1: tcl/tk 8.5 help browser bug
This help browser bug using CVS and tcl/tk 8.5 has been present since at least last fall. After digging through the code, I found the following:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better # destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
The comment before "destroy" in effect disables destroying of children widgets and causes errors whenever I have more than one column open and try to click on a column preceding one that is already created. The error reported is that the "listbox1-list already exists" and the only way around is to close the help browser and reopen it. This obviously prevents going up the file tree once a particular subfolder has been opened which obviously means it is a non-lethal bug, but nonetheless annoying.
The fix is obvious, remove the comment from the offending line and everything works like a charm:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
It would be great if one of the devs/maintiners would please commit this change (I'd do it but I have not bothered to get the CVS dev access).
Many thanks!
Best wishes,
Ico
Make a patch using diff -uw and submit it to the patch tracker.
.hc
On Feb 18, 2007, at 10:58 PM, ico@vt.edu wrote:
Hi all,
Tried sending a couple of e-mails not realizing I am not subscribed to dev list... DOH! So, please prepare for a small salvo of e-mails :-)
Topic #1: tcl/tk 8.5 help browser bug
This help browser bug using CVS and tcl/tk 8.5 has been present since at least last fall. After digging through the code, I found the following:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better # destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
The comment before "destroy" in effect disables destroying of children widgets and causes errors whenever I have more than one column open and try to click on a column preceding one that is already created. The error reported is that the "listbox1-list already exists" and the only way around is to close the help browser and reopen it. This obviously prevents going up the file tree once a particular subfolder has been opened which obviously means it is a non-lethal bug, but nonetheless annoying.
The fix is obvious, remove the comment from the offending line and everything works like a charm:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
It would be great if one of the devs/maintiners would please commit this change (I'd do it but I have not bothered to get the CVS dev access).
Many thanks!
Best wishes,
Ico
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
------------------------------------------------------------------------
All information should be free. - the hacker ethic
Make a patch using diff -uw and submit it to the patch tracker.
Since I am not familiar with the patch tracker, below is the plain-text version. Please also see attached file if this list also accepts attachments like gem-dev does. The fix is rather simple and should be straightforward to understand.
P.S. This is a patch applied against a freshly updated CVS checkout.
Many thanks!
Best wishes,
Ico
--- u_main.tk 2007-02-20 22:20:41.000000000 -0500 +++ u_main.tk.new 2007-02-18 18:37:09.000000000 -0500 @@ -435,7 +435,7 @@ # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better -# destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] + destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else { if { [catch { eval destroy [lrange [winfo children $base] \ [expr { 2 * $count }] end] } \
Personally, if it's not in the patch tracker, there is a very good chance that I will overlook it, even if it's just a one line change. That's what I use to keep track of patches.
.hc
On Feb 20, 2007, at 10:31 PM, ico@vt.edu wrote:
Make a patch using diff -uw and submit it to the patch tracker.
Since I am not familiar with the patch tracker, below is the plain- text version. Please also see attached file if this list also accepts attachments like gem-dev does. The fix is rather simple and should be straightforward to understand.
P.S. This is a patch applied against a freshly updated CVS checkout.
Many thanks!
Best wishes,
Ico
--- u_main.tk 2007-02-20 22:20:41.000000000 -0500 +++ u_main.tk.new 2007-02-18 18:37:09.000000000 -0500 @@ -435,7 +435,7 @@ # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better -# destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end]
destroy {expand}[lrange [winfo children $base] [expr {2 *$count}] end] } else { if { [catch { eval destroy [lrange [winfo children $base] \ [expr { 2 * $count }] end] } \ <u_main.tk.patch>
------------------------------------------------------------------------
Computer science is no more related to the computer than astronomy is related to the telescope. -Edsger Dykstra
Hi all,
I don't know how the help browser works (Hans-Christophe wrote it) and don't know whether that comment character is in there for some reason or not. So I'm scared to fix this without hearing from HC.
I wonder if the old-fashioned idea of just using the file browser should be available as at least an option...
cheers Miller
On Sun, Feb 18, 2007 at 10:58:32PM -0500, ico@vt.edu wrote:
Hi all,
Tried sending a couple of e-mails not realizing I am not subscribed to dev list... DOH! So, please prepare for a small salvo of e-mails :-)
Topic #1: tcl/tk 8.5 help browser bug
This help browser bug using CVS and tcl/tk 8.5 has been present since at least last fall. After digging through the code, I found the following:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better # destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
The comment before "destroy" in effect disables destroying of children widgets and causes errors whenever I have more than one column open and try to click on a column preceding one that is already created. The error reported is that the "listbox1-list already exists" and the only way around is to close the help browser and reopen it. This obviously prevents going up the file tree once a particular subfolder has been opened which obviously means it is a non-lethal bug, but nonetheless annoying.
The fix is obvious, remove the comment from the offending line and everything works like a charm:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
It would be great if one of the devs/maintiners would please commit this change (I'd do it but I have not bothered to get the CVS dev access).
Many thanks!
Best wishes,
Ico
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
Well, I know that on the Mac, there is the trouble of having to deal with Applications being "somewhat" like folders, but when you are using an Application Open dialog, you can't get into the Application AS a folder. This prevents the opening of patches from withing PD that are contained in the Application Bundle, unless you go at it from a Finder window.
Mike M
On 2/21/07, Miller Puckette mpuckett@imusic1.ucsd.edu wrote:
Hi all,
I don't know how the help browser works (Hans-Christophe wrote it) and don't know whether that comment character is in there for some reason or not. So I'm scared to fix this without hearing from HC.
I wonder if the old-fashioned idea of just using the file browser should be available as at least an option...
cheers Miller
On Sun, Feb 18, 2007 at 10:58:32PM -0500, ico@vt.edu wrote:
Hi all,
Tried sending a couple of e-mails not realizing I am not subscribed to dev list... DOH! So, please prepare for a small salvo of e-mails :-)
Topic #1: tcl/tk 8.5 help browser bug
This help browser bug using CVS and tcl/tk 8.5 has been present since at least last fall. After digging through the code, I found the following:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better # destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
The comment before "destroy" in effect disables destroying of children widgets and causes errors whenever I have more than one column open and try to click on a column preceding one that is already created. The error reported is that the "listbox1-list already exists" and the only way around is to close the help browser and reopen it. This obviously prevents going up the file tree once a particular subfolder has been opened which obviously means it is a non-lethal bug, but nonetheless annoying.
The fix is obvious, remove the comment from the offending line and everything works like a charm:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
It would be great if one of the devs/maintiners would please commit this change (I'd do it but I have not bothered to get the CVS dev access).
Many thanks!
Best wishes,
Ico
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
On Feb 21, 2007, at 4:47 PM, Frank Barknecht wrote:
Hallo, Miller Puckette hat gesagt: // Miller Puckette wrote:
I wonder if the old-fashioned idea of just using the file browser should be available as at least an option...
Yesssss! ;)
Sure, just add the old links to the Help menu. Should be trivial to do.
.hc
Ciao
Frank Barknecht _ ______footils.org_ __goto10.org__
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
------------------------------------------------------------------------
All information should be free. - the hacker ethic
On Feb 25, 2007, at 4:49 AM, Frank Barknecht wrote:
Hallo, Hans-Christoph Steiner hat gesagt: // Hans-Christoph Steiner wrote:
Sure, just add the old links to the Help menu. Should be trivial to do.
What old "links"?
The ones that used to be in the help menu that opened up the file browser. I guess they are more properly called "menu items".
.hc
Ciao
Frank Barknecht _ ______footils.org_ __goto10.org__
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
------------------------------------------------------------------------
The arc of history bends towards justice. - Dr. Martin Luther King, Jr.
I don't know how the help browser works (Hans-Christophe wrote it) and don't know whether that comment character is in there for some reason or not. So I'm scared to fix this without hearing from HC.
I wonder if the old-fashioned idea of just using the file browser should be available as at least an option...
The preceding 'if' statement applies that part of the code only if you have Tcl/Tk >= 8.5. Hence it will be a non-issue for most current users who might be relying upon the 8.4 version of the toolkit. I am currently using 8.5 and I can tell you that before this fix every time I wanted to go up one level by clicking onto a column which is followed by an existing child column (obviously one which I was browsing prior to requesting going up on level), the browser fails reporting error that the new listview1 of the newly requested folder cannot be created as one already exists (since 8.4 code below destroys children views but 8.5 does nothing, hence the error). So, this code in effect destroys sub-folder views in order to recreate new one only under 8.5. The only way to circumvent this problem without this fix is to close the help browser and open a new one which is a total pain as your path restarts in the root doc folder. Removing this comment simply makes it possible to do browsing the same like you would do with Tcl/Tk 8.4. FWIW, I now use this fix on a daily basis and I am yet to experience any side-effects.
For this reason, I think this is a fix that is critical for Tcl/Tk >=8.5 users, while others will never see any difference.
Best wishes,
Ico
That line causes Tcl/Tk 8.4 to choke, since it uses special 8.5 syntax. Someone would need to figure out how to make it only visible to 8.5, otherwise it needs to remain commented out until Pd switches to 8.5.
.hc
On Feb 21, 2007, at 2:34 PM, Miller Puckette wrote:
Hi all,
I don't know how the help browser works (Hans-Christophe wrote it) and don't know whether that comment character is in there for some reason or not. So I'm scared to fix this without hearing from HC.
I wonder if the old-fashioned idea of just using the file browser should be available as at least an option...
cheers Miller
On Sun, Feb 18, 2007 at 10:58:32PM -0500, ico@vt.edu wrote:
Hi all,
Tried sending a couple of e-mails not realizing I am not subscribed to dev list... DOH! So, please prepare for a small salvo of e-mails :-)
Topic #1: tcl/tk 8.5 help browser bug
This help browser bug using CVS and tcl/tk 8.5 has been present since at least last fall. After digging through the code, I found the following:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better # destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
The comment before "destroy" in effect disables destroying of children widgets and causes errors whenever I have more than one column open and try to click on a column preceding one that is already created. The error reported is that the "listbox1-list already exists" and the only way around is to close the help browser and reopen it. This obviously prevents going up the file tree once a particular subfolder has been opened which obviously means it is a non-lethal bug, but nonetheless annoying.
The fix is obvious, remove the comment from the offending line and everything works like a charm:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
It would be great if one of the devs/maintiners would please commit this change (I'd do it but I have not bothered to get the CVS dev access).
Many thanks!
Best wishes,
Ico
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
------------------------------------------------------------------------
Interesting. Even if the line is preceded with an if statement which checks for tclversion 8.5?
Ico
-----Original Message----- From: Hans-Christoph Steiner [mailto:hans@eds.org] Sent: Sunday, February 25, 2007 1:47 AM To: Miller Puckette Cc: ico@vt.edu; pd-dev@iem.at Subject: Re: [PD-dev] tcl 8.5 help browser bug and a fix
That line causes Tcl/Tk 8.4 to choke, since it uses special 8.5 syntax. Someone would need to figure out how to make it only visible to 8.5, otherwise it needs to remain commented out until Pd switches to 8.5.
.hc
On Feb 21, 2007, at 2:34 PM, Miller Puckette wrote:
Hi all,
I don't know how the help browser works (Hans-Christophe wrote it) and don't know whether that comment character is in there for some reason or not. So I'm scared to fix this without hearing from HC.
I wonder if the old-fashioned idea of just using the file browser should be available as at least an option...
cheers Miller
On Sun, Feb 18, 2007 at 10:58:32PM -0500, ico@vt.edu wrote:
Hi all,
Tried sending a couple of e-mails not realizing I am not subscribed to dev list... DOH! So, please prepare for a small salvo of e-mails :-)
Topic #1: tcl/tk 8.5 help browser bug
This help browser bug using CVS and tcl/tk 8.5 has been present since at least last fall. After digging through the code, I found the following:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better # destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
The comment before "destroy" in effect disables destroying of children widgets and causes errors whenever I have more than one column open and try to click on a column preceding one that is already created. The error reported is that the "listbox1-list already exists" and the only way around is to close the help browser and reopen it. This obviously prevents going up the file tree once a particular subfolder has been opened which obviously means it is a non-lethal bug, but nonetheless annoying.
The fix is obvious, remove the comment from the offending line and everything works like a charm:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
It would be great if one of the devs/maintiners would please commit this change (I'd do it but I have not bothered to get the CVS dev access).
Many thanks!
Best wishes,
Ico
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
http://at.or.at/hans/
IIRC, I believe it's a change in syntax, so that 8.4 understands it as a syntax error.
.hc
On Feb 25, 2007, at 11:20 AM, Ivica Ico Bukvic wrote:
Interesting. Even if the line is preceded with an if statement which checks for tclversion 8.5?
Ico
-----Original Message----- From: Hans-Christoph Steiner [mailto:hans@eds.org] Sent: Sunday, February 25, 2007 1:47 AM To: Miller Puckette Cc: ico@vt.edu; pd-dev@iem.at Subject: Re: [PD-dev] tcl 8.5 help browser bug and a fix
That line causes Tcl/Tk 8.4 to choke, since it uses special 8.5 syntax. Someone would need to figure out how to make it only visible to 8.5, otherwise it needs to remain commented out until Pd switches to 8.5.
.hc
On Feb 21, 2007, at 2:34 PM, Miller Puckette wrote:
Hi all,
I don't know how the help browser works (Hans-Christophe wrote it) and don't know whether that comment character is in there for some reason or not. So I'm scared to fix this without hearing from HC.
I wonder if the old-fashioned idea of just using the file browser should be available as at least an option...
cheers Miller
On Sun, Feb 18, 2007 at 10:58:32PM -0500, ico@vt.edu wrote:
Hi all,
Tried sending a couple of e-mails not realizing I am not subscribed to dev list... DOH! So, please prepare for a small salvo of e-mails :-)
Topic #1: tcl/tk 8.5 help browser bug
This help browser bug using CVS and tcl/tk 8.5 has been present since at least last fall. After digging through the code, I found the following:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better # destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
The comment before "destroy" in effect disables destroying of children widgets and causes errors whenever I have more than one column open and try to click on a column preceding one that is already created. The error reported is that the "listbox1-list already exists" and the only way around is to close the help browser and reopen it. This obviously prevents going up the file tree once a particular subfolder has been opened which obviously means it is a non-lethal bug, but nonetheless annoying.
The fix is obvious, remove the comment from the offending line and everything works like a charm:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
It would be great if one of the devs/maintiners would please commit this change (I'd do it but I have not bothered to get the CVS dev access).
Many thanks!
Best wishes,
Ico
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
http://at.or.at/hans/
------------------------------------------------------------------------
Man has survived hitherto because he was too ignorant to know how to realize his wishes. Now that he can realize them, he must either change them, or perish. -William Carlos Williams
I see. This begs for one more question:
Is 8.5 backwards compatible so that it can use 8.4 syntax? If so, this way we could keep the 8.5 syntax commented out, but also adjust the "if" call so that 8.4 syntax affects all versions. As it is right now, 8.5 is broken.
Ico
-----Original Message----- From: Hans-Christoph Steiner [mailto:hans@eds.org] Sent: Sunday, February 25, 2007 10:30 PM To: Ivica Ico Bukvic Cc: 'Miller Puckette'; pd-dev@iem.at Subject: Re: [PD-dev] tcl 8.5 help browser bug and a fix
IIRC, I believe it's a change in syntax, so that 8.4 understands it as a syntax error.
.hc
On Feb 25, 2007, at 11:20 AM, Ivica Ico Bukvic wrote:
Interesting. Even if the line is preceded with an if statement which checks for tclversion 8.5?
Ico
-----Original Message----- From: Hans-Christoph Steiner [mailto:hans@eds.org] Sent: Sunday, February 25, 2007 1:47 AM To: Miller Puckette Cc: ico@vt.edu; pd-dev@iem.at Subject: Re: [PD-dev] tcl 8.5 help browser bug and a fix
That line causes Tcl/Tk 8.4 to choke, since it uses special 8.5 syntax. Someone would need to figure out how to make it only visible to 8.5, otherwise it needs to remain commented out until Pd switches to 8.5.
.hc
On Feb 21, 2007, at 2:34 PM, Miller Puckette wrote:
Hi all,
I don't know how the help browser works (Hans-Christophe wrote it) and don't know whether that comment character is in there for some reason or not. So I'm scared to fix this without hearing from HC.
I wonder if the old-fashioned idea of just using the file browser should be available as at least an option...
cheers Miller
On Sun, Feb 18, 2007 at 10:58:32PM -0500, ico@vt.edu wrote:
Hi all,
Tried sending a couple of e-mails not realizing I am not subscribed to dev list... DOH! So, please prepare for a small salvo of e-mails :-)
Topic #1: tcl/tk 8.5 help browser bug
This help browser bug using CVS and tcl/tk 8.5 has been present since at least last fall. After digging through the code, I found the following:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better # destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
The comment before "destroy" in effect disables destroying of children widgets and causes errors whenever I have more than one column open and try to click on a column preceding one that is already created. The error reported is that the "listbox1-list already exists" and the only way around is to close the help browser and reopen it. This obviously prevents going up the file tree once a particular subfolder has been opened which obviously means it is a non-lethal bug, but nonetheless annoying.
The fix is obvious, remove the comment from the offending line and everything works like a charm:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
It would be great if one of the devs/maintiners would please commit this change (I'd do it but I have not bothered to get the CVS dev access).
Many thanks!
Best wishes,
Ico
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
http://at.or.at/hans/
Man has survived hitherto because he was too ignorant to know how to realize his wishes. Now that he can realize them, he must either change them, or perish. -William Carlos Williams
I don't know exactly. I thought 8.5 was backwards compatible, but I could be wrong.
.hc
On Feb 26, 2007, at 9:42 AM, Ivica Ico Bukvic wrote:
I see. This begs for one more question:
Is 8.5 backwards compatible so that it can use 8.4 syntax? If so, this way we could keep the 8.5 syntax commented out, but also adjust the "if" call so that 8.4 syntax affects all versions. As it is right now, 8.5 is broken.
Ico
-----Original Message----- From: Hans-Christoph Steiner [mailto:hans@eds.org] Sent: Sunday, February 25, 2007 10:30 PM To: Ivica Ico Bukvic Cc: 'Miller Puckette'; pd-dev@iem.at Subject: Re: [PD-dev] tcl 8.5 help browser bug and a fix
IIRC, I believe it's a change in syntax, so that 8.4 understands it as a syntax error.
.hc
On Feb 25, 2007, at 11:20 AM, Ivica Ico Bukvic wrote:
Interesting. Even if the line is preceded with an if statement which checks for tclversion 8.5?
Ico
-----Original Message----- From: Hans-Christoph Steiner [mailto:hans@eds.org] Sent: Sunday, February 25, 2007 1:47 AM To: Miller Puckette Cc: ico@vt.edu; pd-dev@iem.at Subject: Re: [PD-dev] tcl 8.5 help browser bug and a fix
That line causes Tcl/Tk 8.4 to choke, since it uses special 8.5 syntax. Someone would need to figure out how to make it only visible to 8.5, otherwise it needs to remain commented out until Pd switches to 8.5.
.hc
On Feb 21, 2007, at 2:34 PM, Miller Puckette wrote:
Hi all,
I don't know how the help browser works (Hans-Christophe wrote it) and don't know whether that comment character is in there for some reason or not. So I'm scared to fix this without hearing from HC.
I wonder if the old-fashioned idea of just using the file browser should be available as at least an option...
cheers Miller
On Sun, Feb 18, 2007 at 10:58:32PM -0500, ico@vt.edu wrote:
Hi all,
Tried sending a couple of e-mails not realizing I am not subscribed to dev list... DOH! So, please prepare for a small salvo of e-mails :-)
Topic #1: tcl/tk 8.5 help browser bug
This help browser bug using CVS and tcl/tk 8.5 has been present since at least last fall. After digging through the code, I found the following:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better # destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
The comment before "destroy" in effect disables destroying of children widgets and causes errors whenever I have more than one column open and try to click on a column preceding one that is already created. The error reported is that the "listbox1-list already exists" and the only way around is to close the help browser and reopen it. This obviously prevents going up the file tree once a particular subfolder has been opened which obviously means it is a non-lethal bug, but nonetheless annoying.
The fix is obvious, remove the comment from the offending line and everything works like a charm:
proc doc_make_listbox {base dir count} { # check for [file readable]? if { [info tclversion] >= 8.5 } { # requires Tcl 8.5 but probably deals with special chars better destroy {expand}[lrange [winfo children $base] [expr {2 * $count}] end] } else {
It would be great if one of the devs/maintiners would please commit this change (I'd do it but I have not bothered to get the CVS dev access).
Many thanks!
Best wishes,
Ico
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
--
http://at.or.at/hans/
Man has survived hitherto because he was too ignorant to know how to realize his wishes. Now that he can realize them, he must either change them, or perish. -William Carlos Williams
------------------------------------------------------------------------
The arc of history bends towards justice. - Dr. Martin Luther King, Jr.
Quoting Hans-Christoph Steiner hans@eds.org:
I don't know exactly. I thought 8.5 was backwards compatible, but I could be wrong.
OK, so how about the following patch then? I just checked this out and the 8.4 syntax does work on 8.5 but in the current code it is never accessed due to the existing "if" statement. The new fix simply comments the "if" and "else" statements making the 8.4 style of closing children widgets mandatory for all versions, and since it appears that 8.4 works fine with this code, this appears to be a universal fix for this issue.
Please see attached (diff -uw against the fresh CVS checkout).
Best wishes,
Ico
On Feb 27, 2007, at 1:17 PM, ico@vt.edu wrote:
Quoting Hans-Christoph Steiner hans@eds.org:
I don't know exactly. I thought 8.5 was backwards compatible, but I could be wrong.
OK, so how about the following patch then? I just checked this out and the 8.4 syntax does work on 8.5 but in the current code it is never accessed due to the existing "if" statement. The new fix simply comments the "if" and "else" statements making the 8.4 style of closing children widgets mandatory for all versions, and since it appears that 8.4 works fine with this code, this appears to be a universal fix for this issue.
Please see attached (diff -uw against the fresh CVS checkout).
Best wishes,
Ico <u_main.tk.patch2>
You'll have better luck uploading this to the patch tracker. I'll take a look when I get a moment.
.hc
------------------------------------------------------------------------
There is no way to peace, peace is the way. -A.J. Muste
-
Frank Barknecht -
Hans-Christoph Steiner -
ico＠vt.edu -
IOhannes m zmoelnig -
Ivica Ico Bukvic
-
Mike McGonagle -
Miller Puckette