Howdy Miller,
sorry, I can't make a PR for this right now but just a note: it looks like the CI Windows build fails because Windows does not define M_PI by default, although this might be for an *older* version of Windows/VS.
I think it would be safe to check if M_PI exists in d_osc.c then define a reasonable default if not.
-------- Dan Wilcox danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
OK, I'll do that... I had figured everyone would have it by now (and indeed, mingw, which I've used recently, does provide it. I should have tested compiling using MSVC but never got around to that this time.)
cheers
Miller
On 6/2/24 2:50 PM, Dan Wilcox wrote:
Howdy Miller,
sorry, I can't make a PR for this right now but just a note: it looks like the CI Windows build fails because Windows does not define M_PI by default, although this might be for an *older* version of Windows/VS.
I think it would be safe to check if M_PI exists in d_osc.c then define a reasonable default if not.
Dan Wilcox danomatika.com http://danomatika.com robotcowboy.com http://robotcowboy.com
Hi, I was not sure if I had to open an issue in Pd or pd-lib-builder, and I ended up opening on the latter (see https://github.com/pure-data/pd-lib-builder/issues/81), but I am also raising it up here and asking what's going on. It seems CLASS_MAINSIGNALIN has changed, is that it? Why?
thanks
Here's my answer: https://github.com/pure-data/pd-lib-builder/issues/81#issuecomment-214404113...
On 02.06.2024 17:52, Alexandre Torres Porres wrote:
Hi, I was not sure if I had to open an issue in Pd or pd-lib-builder, and I ended up opening on the latter (see https://github.com/pure-data/pd-lib-builder/issues/81), but I am also raising it up here and asking what's going on. It seems CLASS_MAINSIGNALIN has changed, is that it? Why?
thanks
Pd-dev mailing list Pd-dev@lists.iem.at https://lists.puredata.info/listinfo/pd-dev
-
Alexandre Torres Porres -
Christof Ressi -
Dan Wilcox -
Miller Puckette