Can we close those PRs that have been merged upstream? It's a little confusing right now...
-------- Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
I have one request that was basically fully merged upstream, but the [midiclkin] object
https://github.com/pure-data/pure-data/pull/41
the thing about the [midiclkin] object is that miller plans to just remove it, and this hasn't been done yet, but I think you can go ahead and delete it, then I'll add an issue just as a reminder. Later I could try a PR for removing midiclkin as well
cheers
2017-06-27 23:29 GMT-03:00 Dan Wilcox danomatika@gmail.com:
Can we close those PRs that have been merged upstream? It's a little confusing right now...
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com robotcowboy.com
Pd-dev mailing list Pd-dev@lists.iem.at https://lists.puredata.info/listinfo/pd-dev
On 06/28/2017 04:56 AM, Alexandre Torres Porres wrote:
I have one request that was basically fully merged upstream, but the [midiclkin] object
i think we should differentiate between pull requests and issues. an issue is a "problem description", whereas a pull request is an "action". the PR should be closed if the "action" has either been accepted or not, regardless of whether the underlying "problem" has been resolved.
the PR is about fixing the [midiclkin] object. removing the object is something different (although somewhat related), not tackled by this PR. i'd suggest to create a new *issue* about removing the object, and close the pull-request.
you can *then* create a new PR that removes the object and closes your ticket.
gfmards IOhannes
2017-06-28 6:25 GMT-03:00 IOhannes m zmölnig zmoelnig@iem.at:
i'd suggest to create a new *issue* about removing the object, and close
the pull-request.
you can *then* create a new PR that removes the object and closes your ticket.
that is exactly what I meant
-
Alexandre Torres Porres -
Dan Wilcox -
IOhannes m zmölnig