hi miller, hi all.
i noticed that there is a small bug in my alternative classname loader code in s_loader.c, which prevents externals with a filename that needs to be escaped from being loaded.
such file will successfully be opened, however, since the brackets after the if statement are missing (line 81-92), the loader keeps believing that it failed.
the attached diff sets the brackets correctly.
mf,.g.asdr IOhannes
Index: s_loader.c =================================================================== RCS file: /cvsroot/pure-data/pd/src/s_loader.c,v retrieving revision 1.7 diff -u -r1.7 s_loader.c --- s_loader.c 31 Dec 2005 20:55:25 -0000 1.7 +++ s_loader.c 13 Mar 2006 15:35:55 -0000 @@ -78,6 +78,7 @@ { if ((fd = open_via_path(dirname, altname, sys_dllextent, dirbuf, &nameptr, MAXPDSTRING, 1)) < 0) + {
/* next try (alternative_classname)/(alternative_classname).(sys_dllextent) ... */ strncpy(classname2, altname, MAXPDSTRING); @@ -89,6 +90,7 @@ dirbuf, &nameptr, MAXPDSTRING, 1)) < 0) { return 0; + } } } else
I was wondering what was going on, I noticed this in Pd-extended too, but never really looked into it.
Any chance you could fix packages/patches/loaderHEX-0.39-1.patch also? That is being used in Pd-0.39.2-extended.
.hc
IOhannes m zmoelnig wrote:
hi miller, hi all.
i noticed that there is a small bug in my alternative classname loader code in s_loader.c, which prevents externals with a filename that needs to be escaped from being loaded.
such file will successfully be opened, however, since the brackets after the if statement are missing (line 81-92), the loader keeps believing that it failed.
the attached diff sets the brackets correctly.
mf,.g.asdr IOhannes
Index: s_loader.c
RCS file: /cvsroot/pure-data/pd/src/s_loader.c,v retrieving revision 1.7 diff -u -r1.7 s_loader.c --- s_loader.c 31 Dec 2005 20:55:25 -0000 1.7 +++ s_loader.c 13 Mar 2006 15:35:55 -0000 @@ -78,6 +78,7 @@ { if ((fd = open_via_path(dirname, altname, sys_dllextent, dirbuf, &nameptr, MAXPDSTRING, 1)) < 0)
{ /* next try (alternative_classname)/(alternative_classname).(sys_dllextent) ... */ strncpy(classname2, altname, MAXPDSTRING);@@ -89,6 +90,7 @@ dirbuf, &nameptr, MAXPDSTRING, 1)) < 0) { return 0;
} } } else
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
Hans-Christoph Steiner wrote:
I was wondering what was going on, I noticed this in Pd-extended too, but never really looked into it.
Any chance you could fix packages/patches/loaderHEX-0.39-1.patch also? That is being used in Pd-0.39.2-extended.
thanks for the suggestion. i have changed the patch, but haven't found the time to check whether it really works.
(don't know whether it is such a good idea to directly edit diff-files...)
mf.asdr. IOhannes
On Mar 14, 2006, at 7:42 AM, IOhannes m zmoelnig wrote:
Hans-Christoph Steiner wrote:
I was wondering what was going on, I noticed this in Pd-extended too, but never really looked into it.
Any chance you could fix packages/patches/loaderHEX-0.39-1.patch also? That is being used in Pd-0.39.2-extended.
thanks for the suggestion. i have changed the patch, but haven't found the time to check whether it really works.
(don't know whether it is such a good idea to directly edit diff- files...)
Donno if it works perfectly yet, but it applies and compiles on Mac OS X>
.hc
________________________________________________________________________ ____
"Looking at things from a more basic level, you can come up with a more direct solution... It may sound small in theory, but it in practice, it can change entire economies." - Amy Smith
OK, I updated that.
I can't seem to write to CVS today though...
cheers Miller
On Mon, Mar 13, 2006 at 04:42:01PM +0100, IOhannes m zmoelnig wrote:
hi miller, hi all.
i noticed that there is a small bug in my alternative classname loader code in s_loader.c, which prevents externals with a filename that needs to be escaped from being loaded.
such file will successfully be opened, however, since the brackets after the if statement are missing (line 81-92), the loader keeps believing that it failed.
the attached diff sets the brackets correctly.
mf,.g.asdr IOhannes
Index: s_loader.c
RCS file: /cvsroot/pure-data/pd/src/s_loader.c,v retrieving revision 1.7 diff -u -r1.7 s_loader.c --- s_loader.c 31 Dec 2005 20:55:25 -0000 1.7 +++ s_loader.c 13 Mar 2006 15:35:55 -0000 @@ -78,6 +78,7 @@ { if ((fd = open_via_path(dirname, altname, sys_dllextent, dirbuf, &nameptr, MAXPDSTRING, 1)) < 0)
{ /* next try (alternative_classname)/(alternative_classname).(sys_dllextent) ... */ strncpy(classname2, altname, MAXPDSTRING);@@ -89,6 +90,7 @@ dirbuf, &nameptr, MAXPDSTRING, 1)) < 0) { return 0;
} } } else
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
Yeah, me too. Guess SourceForge is having difficulties...
.hc
On Mar 30, 2006, at 8:18 PM, Miller Puckette wrote:
OK, I updated that.
I can't seem to write to CVS today though...
cheers Miller
On Mon, Mar 13, 2006 at 04:42:01PM +0100, IOhannes m zmoelnig wrote:
hi miller, hi all.
i noticed that there is a small bug in my alternative classname loader code in s_loader.c, which prevents externals with a filename that needs to be escaped from being loaded.
such file will successfully be opened, however, since the brackets after the if statement are missing (line 81-92), the loader keeps believing that it failed.
the attached diff sets the brackets correctly.
mf,.g.asdr IOhannes
Index: s_loader.c
RCS file: /cvsroot/pure-data/pd/src/s_loader.c,v retrieving revision 1.7 diff -u -r1.7 s_loader.c --- s_loader.c 31 Dec 2005 20:55:25 -0000 1.7 +++ s_loader.c 13 Mar 2006 15:35:55 -0000 @@ -78,6 +78,7 @@ { if ((fd = open_via_path(dirname, altname, sys_dllextent, dirbuf, &nameptr, MAXPDSTRING, 1)) < 0)
{ /* next try (alternative_classname)/(alternative_classname).(sys_dllextent) ... */ strncpy(classname2, altname, MAXPDSTRING); @@ -89,6 +90,7 @@ dirbuf, &nameptr, MAXPDSTRING, 1)) < 0) { return 0;
} } } else
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
________________________________________________________________________ ____
"Computer science is no more related to the computer than astronomy is related to the telescope." -Edsger Dykstra
-
Hans-Christoph Steiner -
IOhannes m zmoelnig -
Miller Puckette