Patches item #1224768, was opened at 2005-06-21 11:57 Message generated for change (Settings changed) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1224768...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata-dev Group: bugfix

Status: Closed Resolution: Rejected

Priority: 5 Submitted By: IOhannes m zmölnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) Summary: checks for NULL-pointers in g_rtext.c & g_graph.c

Initial Comment: most funtions in g_rtext.c do not check whether a passed pointer is non-zero and thus crash with NULL-pointers.

the added patch performs these checks. is this a performance hog ???

this should fix BUG-1186531 (which i wasn't able to reproduce at all)

----------------------------------------------------------------------

Comment By: Tim Blechmann (timblech) Date: 2005-07-16 11:52

Message: Logged In: YES user_id=326084

what about asserts?

i think, this is, what they are for ... tim

----------------------------------------------------------------------

Comment By: Miller Puckette (millerpuckette) Date: 2005-07-16 02:32

Message: Logged In: YES user_id=313747

I think that adding speculative checks for NULL pointers will delay Pd crashing but whatever the problem was will manifest itself some other way later (and be even harder to reproduce and fix)... so for now I'd like to leave it so that it crashes right away if this ever happens...

----------------------------------------------------------------------

Comment By: IOhannes m zmölnig (zmoelnig) Date: 2005-06-30 20:27

Message: Logged In: YES user_id=564396

the same for g_graph.c

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1224768...