Patches item #3042363, was opened at 2010-08-10 04:40 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3042363...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata-dev Group: None

Status: Closed Resolution: Accepted

Priority: 7 Private: No Submitted By: IOhannes m zmlnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) Summary: finalized automake support

Initial Comment: this patch finishes the automake support for pd-0.43

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)

Date: 2010-08-20 17:51

Message: accepted in git commits: d128213141ac687ab98e17aab4ac10e3bdbb0f9d 20e829e15df256467815d99e96b9557d2d0d3ae4

----------------------------------------------------------------------

Comment By: Miller Puckette (millerpuckette) Date: 2010-08-18 17:35

Message: ok, tried again (didn't know about "git am" which was the magic I needed)

----------------------------------------------------------------------

Comment By: IOhannes m zmlnig (zmoelnig) Date: 2010-08-18 16:18

Message: as it is a git-patch the patch should be applied with $ git am 0001-finished-automake-2nd-attempt.patch

if you want to apply it with $ patch < 0001-finished-automake-2nd-attempt.patch you have to first create an m4/ directory

there are still some warnings about trailing whitespaces and the commit-log not being properly utf-8

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-08-18 16:15

Message: works for me on Ubuntu/Lucid

----------------------------------------------------------------------

Comment By: IOhannes m zmlnig (zmoelnig) Date: 2010-08-18 15:54

Message: i just ran iconv to convert it to utf-8; i hope it's ok now

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-08-18 15:49

Message: 0001-finished-automake-2nd-attempt.patch is not UTF-8, but something else that gedit had trouble recognizing which encoding is used. I think your best bet is to remove the ö and replace it with oe like you have elsewhere in the patch.

----------------------------------------------------------------------

Comment By: IOhannes m zmlnig (zmoelnig) Date: 2010-08-18 14:09

Message: unfortunately parts of the patch were not applied. attached is an updated version against the current git.

----------------------------------------------------------------------

Comment By: Miller Puckette (millerpuckette) Date: 2010-08-18 00:14

Message: The patch got a complaint about pd.pc.in getting supplied twice. I applied the patch anyway, and hope it will all work OK :)

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3042363...