Patches item #3418895, was opened at 2011-10-05 04:30 Message generated for change (Comment added) made by ricardofabbri You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3418895...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: externals Group: bugfix
Status: Closed Resolution: Accepted
Priority: 5 Private: No Submitted By: Ricardo Fabbri (ricardofabbri) Assigned to: lluís gómez i bigordà (lluisbigorda) Summary: updated configure.ac for puredata_opencv
Initial Comment: basically newer autoconf require AC_INIT to have some mandatory arguments, so this patch is strictly necessary for continuing development of puredata_opencv. without this patch autoconf will not generate configure from configure.ac.
----------------------------------------------------------------------
Comment By: Ricardo Fabbri (ricardofabbri)
Date: 2011-10-17 16:45
Message: Dear Lluis,
thank you.
The AC_PREREQ(2.65) is fine if it has worked for you. There was no specific reason for 2.67, other than the fact that I tested on mine and was only sure it worked on 2.67 in practice.
I tested the commit on my system and it seems to work fine.
----------------------------------------------------------------------
Comment By: lluís gómez i bigordà (lluisbigorda) Date: 2011-10-17 07:37
Message: hi ricardo,
the patch is working here, however I'm not able to use your configure.ac's as my configure is still 2.65 (ubuntu 10.4)
I changed the value of AC_PREREQ to 2.65 and now works here ... I don't know if there is any reason to require 2.67 .. is it?
tha patch is applied but this way (AC_PREREQ(2.65)) , ok?
thanks, ll.
----------------------------------------------------------------------
Comment By: Ricardo Fabbri (ricardofabbri) Date: 2011-10-16 21:59
Message: Dear Lluis,
I uploaded a newer patch where I squashed two commits into a single one before generating the patch.
I hope it works now.
I will write to Hans so that he can give me commit access to do some of these small changes. That way I take less of your time (while keeping you informed, of course).
This patch is very important as I've been having to e-mail the new "configure" files around so that people working with me and also other friends can compile pix-opencv with the latest OpenCV.
Thanks.
----------------------------------------------------------------------
Comment By: lluís gómez i bigordà (lluisbigorda) Date: 2011-10-16 19:34
Message: hi ricardo,
I'm sorry but this patch file is giving me an error when applyed against the latest svn ::
$ patch -p1 < /home/lluis/Downloads/configure-update.patch patching file externals/pdp_opencv/configure Hunk #1 FAILED at 1. Hunk #2 FAILED at 228. Hunk #3 FAILED at 547. Hunk #4 FAILED at 688. Hunk #5 FAILED at 1190. Hunk #6 FAILED at 1238. Hunk #7 FAILED at 1259. Hunk #8 FAILED at 1290. Hunk #9 FAILED at 1353. Hunk #10 FAILED at 1533. Hunk #11 FAILED at 5021. Hunk #12 FAILED at 5068. 12 out of 12 hunks FAILED -- saving rejects to file externals/pdp_opencv/configure.rej patching file externals/pdp_opencv/configure.ac Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file externals/pdp_opencv/configure.ac.rej patching file externals/pix_opencv/configure Hunk #1 FAILED at 1. Hunk #2 FAILED at 228. Hunk #3 FAILED at 547. Hunk #4 FAILED at 688. Hunk #5 FAILED at 1190. Hunk #6 FAILED at 1238. Hunk #7 FAILED at 1259. Hunk #8 FAILED at 1290. Hunk #9 FAILED at 1353. Hunk #10 FAILED at 1533. Hunk #11 FAILED at 5021. Hunk #12 FAILED at 5068. 12 out of 12 hunks FAILED -- saving rejects to file externals/pix_opencv/configure.rej patching file externals/pix_opencv/configure.ac Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file externals/pix_opencv/configure.ac.rej
------------
waiting to fix this one also to apply #3418902
----
anyway it seems good work, thanks ricardo!
maybe I can try to fix by myself but the actual configure is not by me and I have no much time these days ...
let's see...
thanks.
----------------------------------------------------------------------
Comment By: Ricardo Fabbri (ricardofabbri) Date: 2011-10-07 22:22
Message: guessing lluis is the right person..
----------------------------------------------------------------------
Comment By: Ricardo Fabbri (ricardofabbri) Date: 2011-10-05 04:35
Message: I took the initiative to put lluiz's email in the configure.ac AC_INIT; If you're not comfortable with that I can put my email, although I am not the main dev.
----------------------------------------------------------------------
Comment By: Ricardo Fabbri (ricardofabbri) Date: 2011-10-05 04:32
Message: BTW this is against the latest svn.
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3418895...
-
SourceForge.net