I think you might have missed my point. The '1' will result in a 'float' message, and from what I can see of your code, this would get lost, as your float method doesn't insert it into the sqlStringStore. Could you test this?
You're right, i did miss the point! BUT, the float method was just used for debugging, and should be taken out. If you look at the bottom of the source file, psql_float() doesn't actually get added to the class's methods. So, the external does the 'right thing' forwarding the ,1, as part of the query. BTW, '1' is not a valid column name (neither are names starting with a number), at least not in Postgres.
Jamie
And yet, I know that it is NOT a valid column name, I am not certain if it is part of the 1992 SQL spec (which seems to be the "bible"), but I know that it will just return the number as a CONSTANT in both MySQL and SQLite. I will have to check on if this is in the spec.
Also, did you catch the other subtle problem with the class method names like 'close'? If you add any class methods, those symbols used to identify those methods can't be used in a comma separated list in the SQL.
Mike
On 11/13/07, jamie@postlude.co.uk jamie@postlude.co.uk wrote:
I think you might have missed my point. The '1' will result in a 'float' message, and from what I can see of your code, this would get lost, as your float method doesn't insert it into the sqlStringStore. Could you test this?
You're right, i did miss the point! BUT, the float method was just used for debugging, and should be taken out. If you look at the bottom of the source file, psql_float() doesn't actually get added to the class's methods. So, the external does the 'right thing' forwarding the ,1, as part of the query. BTW, '1' is not a valid column name (neither are names starting with a number), at least not in Postgres.
Jamie
And yet, I know that it is NOT a valid column name, I am not certain if it is part of the 1992 SQL spec (which seems to be the "bible"), but I know that it will just return the number as a CONSTANT in both MySQL and SQLite. I will have to check on if this is in the spec.
Well either way [psql] handles ',1 ,' correctly, forwarding it to the server as part of the query.
Also, did you catch the other subtle problem with the class method names like 'close'? If you add any class methods, those symbols used to identify those methods can't be used in a comma separated list in the SQL.
Yup this is a bug. I'll be committing a fix for this (as well as the other changes I mentioned) tonight when I'm not behind a firewall any more!
Jamie
-
jamie＠postlude.co.uk -
Mike McGonagle